Fix error handling in nwfilterStateInitialize

[libvirt PATCH 0/5] Fix error handling in nwfilterStateInitialize

Tim Wiederhake posted 5 patches 2 years ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220408131248.48609-1-twiederh@redhat.com

src/conf/virnwfilterobj.c         |  3 ++
src/conf/virnwfilterobj.h         |  1 +
src/nwfilter/nwfilter_dhcpsnoop.c | 15 +++++++--
src/nwfilter/nwfilter_driver.c    | 55 ++++++++++++++-----------------
4 files changed, 41 insertions(+), 33 deletions(-)

Expand all Fold all

[libvirt PATCH 0/5] Fix error handling in nwfilterStateInitialize

Posted by Tim Wiederhake 2 years ago

See patch 5 for description.

Tim Wiederhake (5):
  virNWFilterObjListFree: Prevent null pointer derefernce
  virNWFilterSnoopState: Prevent mutex leak
  nwfilterDriverRemoveDBusMatches: Prevent unsubscribing from null id
  virNWFilterDriverState: Destroy mutex safely
  nwfilterStateInitialize: Simplify and fix error handling

 src/conf/virnwfilterobj.c         |  3 ++
 src/conf/virnwfilterobj.h         |  1 +
 src/nwfilter/nwfilter_dhcpsnoop.c | 15 +++++++--
 src/nwfilter/nwfilter_driver.c    | 55 ++++++++++++++-----------------
 4 files changed, 41 insertions(+), 33 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 0/5] Fix error handling in nwfilterStateInitialize

Posted by Michal Prívozník 2 years ago

On 4/8/22 15:12, Tim Wiederhake wrote:
> See patch 5 for description.
> 
> Tim Wiederhake (5):
>   virNWFilterObjListFree: Prevent null pointer derefernce
>   virNWFilterSnoopState: Prevent mutex leak
>   nwfilterDriverRemoveDBusMatches: Prevent unsubscribing from null id
>   virNWFilterDriverState: Destroy mutex safely
>   nwfilterStateInitialize: Simplify and fix error handling
> 
>  src/conf/virnwfilterobj.c         |  3 ++
>  src/conf/virnwfilterobj.h         |  1 +
>  src/nwfilter/nwfilter_dhcpsnoop.c | 15 +++++++--
>  src/nwfilter/nwfilter_driver.c    | 55 ++++++++++++++-----------------
>  4 files changed, 41 insertions(+), 33 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal