virsh: Add some completers

[PATCH 0/3] virsh: Add some completers

Amneesh Singh posted 3 patches 2 years ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220402103147.428242-1-natto@weirdnatto.in

Test syntax-check passed

src/util/virarch.c              |  2 +-
src/util/virarch.h              |  2 +-
tools/virsh-completer-host.c    | 24 ++++++++++++++++++++++++
tools/virsh-completer-host.h    | 10 ++++++++++
tools/virsh-completer-nodedev.c | 11 +++++++++++
tools/virsh-completer-nodedev.h |  4 ++++
tools/virsh-host.c              |  8 ++++++++
tools/virsh-nodedev.c           |  2 ++
8 files changed, 61 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH 0/3] virsh: Add some completers

Posted by Amneesh Singh 2 years ago

Add some basic completers

Amneesh Singh (3):
  virsh: Provide completer for virtualization types
  virsh: Provide completer for CPU architectures
  virsh: Provide completer for PCI backend drivers

 src/util/virarch.c              |  2 +-
 src/util/virarch.h              |  2 +-
 tools/virsh-completer-host.c    | 24 ++++++++++++++++++++++++
 tools/virsh-completer-host.h    | 10 ++++++++++
 tools/virsh-completer-nodedev.c | 11 +++++++++++
 tools/virsh-completer-nodedev.h |  4 ++++
 tools/virsh-host.c              |  8 ++++++++
 tools/virsh-nodedev.c           |  2 ++
 8 files changed, 61 insertions(+), 2 deletions(-)

-- 
2.35.1

Re: [PATCH 0/3] virsh: Add some completers

Posted by Michal Prívozník 2 years ago

On 4/2/22 12:31, Amneesh Singh wrote:
> Add some basic completers
> 
> Amneesh Singh (3):
>   virsh: Provide completer for virtualization types
>   virsh: Provide completer for CPU architectures
>   virsh: Provide completer for PCI backend drivers
> 
>  src/util/virarch.c              |  2 +-
>  src/util/virarch.h              |  2 +-
>  tools/virsh-completer-host.c    | 24 ++++++++++++++++++++++++
>  tools/virsh-completer-host.h    | 10 ++++++++++
>  tools/virsh-completer-nodedev.c | 11 +++++++++++
>  tools/virsh-completer-nodedev.h |  4 ++++
>  tools/virsh-host.c              |  8 ++++++++
>  tools/virsh-nodedev.c           |  2 ++
>  8 files changed, 61 insertions(+), 2 deletions(-)
> 

I'm fixing all the small nits I've raised in my review and pushing.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Congratulations on your first libvirt contribution!

Michal