[PATCH 0/2] domain, qemu: add support for clearing TSC on reset

Paolo Bonzini posted 2 patches 2 years, 1 month ago
Test syntax-check passed
Failed in applying to current master (apply log)
...equency.xml => cpu-tsc-clear-on-reset.xml} |  2 +-
tests/qemuxml2argvtest.c                      |  2 ++
14 files changed, 89 insertions(+), 16 deletions(-)
copy tests/qemuxml2argvdata/{cpu-tsc-frequency.args => cpu-tsc-clear-on-reset.args} (97%)
copy tests/qemuxml2argvdata/{virtio-rng-builtin.x86_64-latest.args => cpu-tsc-clear-on-reset.x86_64-7.0.0.args} (77%)
copy tests/qemuxml2argvdata/{cpu-tsc-frequency.xml => cpu-tsc-clear-on-reset.xml} (95%)
[PATCH 0/2] domain, qemu: add support for clearing TSC on reset
Posted by Paolo Bonzini 2 years, 1 month ago
Some versions of Windows hang on reboot if their TSC value is greater
than 2^54.  The workaround is to reset the TSC to a small value, and
is implemented by QEMU and ESXi.  This series adds a domain attribute
for this, and implements it in QEMU.

Paolo

Paolo Bonzini (2):
  domain: add tsc.on_reboot element
  qemu: add support for tsc.on_reboot element

 docs/formatdomain.rst                         |  4 +++
 src/conf/domain_conf.c                        | 22 ++++++++++++
 src/conf/domain_conf.h                        | 10 ++++++
 src/conf/schemas/domaincommon.rng             |  9 +++++
 src/qemu/qemu_capabilities.c                  |  2 ++
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       |  4 +++
 src/qemu/qemu_validate.c                      | 36 +++++++++++++------
 .../caps_7.0.0.x86_64.replies                 |  4 +++
 .../caps_7.0.0.x86_64.xml                     |  1 +
 ...uency.args => cpu-tsc-clear-on-reset.args} |  2 +-
 ... cpu-tsc-clear-on-reset.x86_64-7.0.0.args} |  6 ++--
 ...equency.xml => cpu-tsc-clear-on-reset.xml} |  2 +-
 tests/qemuxml2argvtest.c                      |  2 ++
 14 files changed, 89 insertions(+), 16 deletions(-)
 copy tests/qemuxml2argvdata/{cpu-tsc-frequency.args => cpu-tsc-clear-on-reset.args} (97%)
 copy tests/qemuxml2argvdata/{virtio-rng-builtin.x86_64-latest.args => cpu-tsc-clear-on-reset.x86_64-7.0.0.args} (77%)
 copy tests/qemuxml2argvdata/{cpu-tsc-frequency.xml => cpu-tsc-clear-on-reset.xml} (95%)

-- 
2.35.1
Re: [PATCH 0/2] domain, qemu: add support for clearing TSC on reset
Posted by Michal Prívozník 2 years, 1 month ago
On 3/24/22 10:48, Paolo Bonzini wrote:
> Some versions of Windows hang on reboot if their TSC value is greater
> than 2^54.  The workaround is to reset the TSC to a small value, and
> is implemented by QEMU and ESXi.  This series adds a domain attribute
> for this, and implements it in QEMU.
> 
> Paolo
> 
> Paolo Bonzini (2):
>   domain: add tsc.on_reboot element
>   qemu: add support for tsc.on_reboot element
> 
>  docs/formatdomain.rst                         |  4 +++
>  src/conf/domain_conf.c                        | 22 ++++++++++++
>  src/conf/domain_conf.h                        | 10 ++++++
>  src/conf/schemas/domaincommon.rng             |  9 +++++
>  src/qemu/qemu_capabilities.c                  |  2 ++
>  src/qemu/qemu_capabilities.h                  |  1 +
>  src/qemu/qemu_command.c                       |  4 +++
>  src/qemu/qemu_validate.c                      | 36 +++++++++++++------
>  .../caps_7.0.0.x86_64.replies                 |  4 +++
>  .../caps_7.0.0.x86_64.xml                     |  1 +
>  ...uency.args => cpu-tsc-clear-on-reset.args} |  2 +-
>  ... cpu-tsc-clear-on-reset.x86_64-7.0.0.args} |  6 ++--
>  ...equency.xml => cpu-tsc-clear-on-reset.xml} |  2 +-
>  tests/qemuxml2argvtest.c                      |  2 ++
>  14 files changed, 89 insertions(+), 16 deletions(-)
>  copy tests/qemuxml2argvdata/{cpu-tsc-frequency.args => cpu-tsc-clear-on-reset.args} (97%)
>  copy tests/qemuxml2argvdata/{virtio-rng-builtin.x86_64-latest.args => cpu-tsc-clear-on-reset.x86_64-7.0.0.args} (77%)
>  copy tests/qemuxml2argvdata/{cpu-tsc-frequency.xml => cpu-tsc-clear-on-reset.xml} (95%)
> 

I'm fixing all the small issues I've raised in review and pushing these.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Thanks!

Michal
Re: [PATCH 0/2] domain, qemu: add support for clearing TSC on reset
Posted by Paolo Bonzini 2 years, 1 month ago
On 3/25/22 16:35, Michal Prívozník wrote:
> I'm fixing all the small issues I've raised in review and pushing these.
> 
> Reviewed-by: Michal Privoznik<mprivozn@redhat.com>

No, please don't!  The property is not yet part of QEMU, this should 
have been tagged RFC.

Sorry about the confusion.

Paolo

Re: [PATCH 0/2] domain, qemu: add support for clearing TSC on reset
Posted by Michal Prívozník 2 years, 1 month ago
On 3/25/22 17:49, Paolo Bonzini wrote:
> On 3/25/22 16:35, Michal Prívozník wrote:
>> I'm fixing all the small issues I've raised in review and pushing these.
>>
>> Reviewed-by: Michal Privoznik<mprivozn@redhat.com>
> 
> No, please don't!  The property is not yet part of QEMU, this should
> have been tagged RFC.
> 
> Sorry about the confusion.


Oops, should have followed conversation on qemu-devel more closely:

https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06077.html

So let me revert these.

Michal