[PATCH] gitpublish: Drop "libvirt" from prefix

Andrea Bolognani posted 1 patch 2 years, 1 month ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220322101142.155515-1-abologna@redhat.com
.gitpublish | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] gitpublish: Drop "libvirt" from prefix
Posted by Andrea Bolognani 2 years, 1 month ago
We're now using GitLab MRs for all subprojects, which makes
having "libvirt" in the prefix no longer necessary and a
pointless deviation from git-format-patch's default, which
some people still use.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .gitpublish | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitpublish b/.gitpublish
index d37bf4174a..2c9a6e909e 100644
--- a/.gitpublish
+++ b/.gitpublish
@@ -1,4 +1,4 @@
 [gitpublishprofile "default"]
 base = master
 to = libvir-list@redhat.com
-prefix = libvirt PATCH
+prefix = PATCH
-- 
2.35.1
Re: [PATCH] gitpublish: Drop "libvirt" from prefix
Posted by Daniel P. Berrangé 2 years, 1 month ago
On Tue, Mar 22, 2022 at 11:11:42AM +0100, Andrea Bolognani wrote:
> We're now using GitLab MRs for all subprojects, which makes
> having "libvirt" in the prefix no longer necessary and a
> pointless deviation from git-format-patch's default, which
> some people still use.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .gitpublish | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

My view is unchanged from the last time you proposed this

  https://listman.redhat.com/archives/libvir-list/2021-March/216307.html

This change is worse for no gain.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] gitpublish: Drop "libvirt" from prefix
Posted by Andrea Bolognani 2 years, 1 month ago
On Tue, Mar 22, 2022 at 10:35:41AM +0000, Daniel P. Berrangé wrote:
> On Tue, Mar 22, 2022 at 11:11:42AM +0100, Andrea Bolognani wrote:
> > We're now using GitLab MRs for all subprojects, which makes
> > having "libvirt" in the prefix no longer necessary and a
> > pointless deviation from git-format-patch's default, which
> > some people still use.
> >
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> >  .gitpublish | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> My view is unchanged from the last time you proposed this
>
>   https://listman.redhat.com/archives/libvir-list/2021-March/216307.html
>
> This change is worse for no gain.

Alright, I'll post this again in a year, when I've completely
forgotten about having already done so in the past O:-)

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH] gitpublish: Drop "libvirt" from prefix
Posted by Pavel Hrdina 2 years, 1 month ago
On Tue, Mar 22, 2022 at 11:11:42AM +0100, Andrea Bolognani wrote:
> We're now using GitLab MRs for all subprojects, which makes
> having "libvirt" in the prefix no longer necessary and a
> pointless deviation from git-format-patch's default, which
> some people still use.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .gitpublish | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NACK as I still think it's good to have the project name as part of
the prefix.

For example if some other mailing list is added to CC like we get mails
from QEMU project without proper prefix.

Pavel

> diff --git a/.gitpublish b/.gitpublish
> index d37bf4174a..2c9a6e909e 100644
> --- a/.gitpublish
> +++ b/.gitpublish
> @@ -1,4 +1,4 @@
>  [gitpublishprofile "default"]
>  base = master
>  to = libvir-list@redhat.com
> -prefix = libvirt PATCH
> +prefix = PATCH
> -- 
> 2.35.1
>