run: include 'src' in $PATH for the daemons

[PATCH] run: include 'src' in $PATH for the daemons

Daniel P. Berrangé posted 1 patch 2 years, 1 month ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220309105442.788666-1-berrange@redhat.com

run.in | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] run: include 'src' in $PATH for the daemons

Posted by Daniel P. Berrangé 2 years, 1 month ago

Currently the 'run' script modifies $PATH to add the 'tools'
directly to pick up client programs. It fails to add the 'src'
directory to pick up the daemons.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 run.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/run.in b/run.in
index 174b191675..3be7818d32 100644
--- a/run.in
+++ b/run.in
@@ -70,6 +70,7 @@ env = os.environ
 prepend(env, "LD_LIBRARY_PATH", os.path.join(here, "src"))
 prepend(env, "PKG_CONFIG_PATH", os.path.join(here, "src"))
 prepend(env, "PATH", os.path.join(here, "tools"))
+prepend(env, "PATH", os.path.join(here, "src"))
 
 # Ensure that any 3rd party apps using libvirt.so from the build tree get
 # files resolved to the build/source tree too. Typically useful for language
-- 
2.35.1

Re: [PATCH] run: include 'src' in $PATH for the daemons

Posted by Ján Tomko 2 years, 1 month ago

On a Wednesday in 2022, Daniel P. Berrangé wrote:
>Currently the 'run' script modifies $PATH to add the 'tools'
>directly to pick up client programs. It fails to add the 'src'
>directory to pick up the daemons.
>

I did not realize I don't have to type the 'tools/' part.
(Added by commit a5b1b1fa4887dae12aca6817386a72f6c6b37f06
for libguestfs test suite)

>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> run.in | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/run.in b/run.in
>index 174b191675..3be7818d32 100644
>--- a/run.in
>+++ b/run.in
>@@ -70,6 +70,7 @@ env = os.environ
> prepend(env, "LD_LIBRARY_PATH", os.path.join(here, "src"))
> prepend(env, "PKG_CONFIG_PATH", os.path.join(here, "src"))
> prepend(env, "PATH", os.path.join(here, "tools"))
>+prepend(env, "PATH", os.path.join(here, "src"))
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano