From nobody Sat May 11 04:31:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646655452; cv=none; d=zohomail.com; s=zohoarc; b=n+DZaspZWx2QKHXdMifvI7yJudK4jawp2+MRyfsiqNCz6qJUC7LhxwneU3fQQp70j2yxJXftPRdFzaqb2b4c0liGOUwy6CwpGgtlnT4jZbRUhKcfc+2NO+DIuUdhvEuDTyzIyYp7lm/hIImGYx5zCBRqND1rAtZ0xwZrHB3ci+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646655452; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=zlhAfAwzDZkAOeDkukgVtU+YNj1ikHPn7axkPb4h9/E=; b=OOhqaFCEVwJtWSRI9bsGWkiv+l6z3S2FgbnifnYLuKVnwKOPvqkTr3/G14mltIVpR/98Zq/wr3l1GLMBuTS9eOREn1OtkuTO0Wa6uMhl0JvfCeP52ZcEPR/RIo8qC5dEvvc9+aUXOINzWFH5hLS+LKTr0SATLv14Lseq3/+zLXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1646655452159594.4167690300886; Mon, 7 Mar 2022 04:17:32 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-f0mgJNm0Oy6Eee-Zwl8HEA-1; Mon, 07 Mar 2022 07:17:04 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60ED23C0219D; Mon, 7 Mar 2022 12:17:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0680240146E; Mon, 7 Mar 2022 12:17:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C9EC11931BE9; Mon, 7 Mar 2022 12:17:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 22E7A1931BE7 for ; Mon, 7 Mar 2022 12:16:58 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8EC2C1037F4E; Mon, 7 Mar 2022 12:16:58 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.193.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF2D91037F4B for ; Mon, 7 Mar 2022 12:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646655451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zlhAfAwzDZkAOeDkukgVtU+YNj1ikHPn7axkPb4h9/E=; b=LYwXEKuH4z77SyUvOR9ZNpLRZ9xA8rBmAGJI/Kf8X4JUT770SHtLnEibL8bOJjxioCufLR Gyjkq8OKvEjt1EvrXVapPgeghlfEGzI5nGbQwbRTta2xdUA+h1oav08bNGBJO2IleknzFh PTz+cDgaL3HX9NwbHTXNJD1JJvOebiE= X-MC-Unique: f0mgJNm0Oy6Eee-Zwl8HEA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] Drop YouCompleteMe and color_coded integration Date: Mon, 7 Mar 2022 13:16:40 +0100 Message-Id: <20220307121640.76802-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646655457682100003 Content-Type: text/plain; charset="utf-8" I introduced support for these vim plugins several years ago but have since moved away from them. These days developers are likely better served by lsp-based tooling, which doesn't require additional per-project configuration. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- .color_coded.in | 38 --------------------------------- .ycm_extra_conf.py.in | 43 -------------------------------------- build-aux/syntax-check.mk | 1 - docs/developer-tooling.rst | 13 ------------ docs/hacking.rst | 1 - docs/meson.build | 1 - meson.build | 19 ----------------- 7 files changed, 116 deletions(-) delete mode 100644 .color_coded.in delete mode 100644 .ycm_extra_conf.py.in delete mode 100644 docs/developer-tooling.rst diff --git a/.color_coded.in b/.color_coded.in deleted file mode 100644 index f39c6860ab..0000000000 --- a/.color_coded.in +++ /dev/null @@ -1,38 +0,0 @@ --I@abs_top_builddir@ --I@abs_top_srcdir@ --I@abs_top_builddir@/include --I@abs_top_srcdir@/include --I@abs_top_builddir@/src --I@abs_top_srcdir@/src --I@abs_top_builddir@/src/access --I@abs_top_srcdir@/src/access --I@abs_top_builddir@/src/admin --I@abs_top_srcdir@/src/admin --I@abs_top_builddir@/src/bhyve --I@abs_top_srcdir@/src/bhyve --I@abs_top_builddir@/src/conf --I@abs_top_srcdir@/src/conf --I@abs_top_builddir@/src/libxl --I@abs_top_srcdir@/src/libxl --I@abs_top_builddir@/src/locking --I@abs_top_srcdir@/src/locking --I@abs_top_builddir@/src/logging --I@abs_top_srcdir@/src/logging --I@abs_top_builddir@/src/lxc --I@abs_top_srcdir@/src/lxc --I@abs_top_builddir@/src/qemu --I@abs_top_srcdir@/src/qemu --I@abs_top_builddir@/src/remote --I@abs_top_srcdir@/src/remote --I@abs_top_builddir@/src/rpc --I@abs_top_srcdir@/src/rpc --I@abs_top_builddir@/src/secret --I@abs_top_srcdir@/src/secret --I@abs_top_builddir@/src/security --I@abs_top_srcdir@/src/security --I@abs_top_builddir@/src/util --I@abs_top_srcdir@/src/util --I@abs_top_builddir@/src/vmx --I@abs_top_srcdir@/src/vmx --I@abs_top_builddir@/src/xenconfig --I@abs_top_srcdir@/src/xenconfig diff --git a/.ycm_extra_conf.py.in b/.ycm_extra_conf.py.in deleted file mode 100644 index 2e24334079..0000000000 --- a/.ycm_extra_conf.py.in +++ /dev/null @@ -1,43 +0,0 @@ -flags =3D [ - '-I@abs_top_builddir@', - '-I@abs_top_srcdir@', - '-I@abs_top_builddir@/include', - '-I@abs_top_srcdir@/include', - '-I@abs_top_builddir@/src', - '-I@abs_top_srcdir@/src', - '-I@abs_top_builddir@/src/access', - '-I@abs_top_srcdir@/src/access', - '-I@abs_top_builddir@/src/admin', - '-I@abs_top_srcdir@/src/admin', - '-I@abs_top_builddir@/src/bhyve', - '-I@abs_top_srcdir@/src/bhyve', - '-I@abs_top_builddir@/src/conf', - '-I@abs_top_srcdir@/src/conf', - '-I@abs_top_builddir@/src/libxl', - '-I@abs_top_srcdir@/src/libxl', - '-I@abs_top_builddir@/src/locking', - '-I@abs_top_srcdir@/src/locking', - '-I@abs_top_builddir@/src/logging', - '-I@abs_top_srcdir@/src/logging', - '-I@abs_top_builddir@/src/lxc', - '-I@abs_top_srcdir@/src/lxc', - '-I@abs_top_builddir@/src/qemu', - '-I@abs_top_srcdir@/src/qemu', - '-I@abs_top_builddir@/src/remote', - '-I@abs_top_srcdir@/src/remote', - '-I@abs_top_builddir@/src/rpc', - '-I@abs_top_srcdir@/src/rpc', - '-I@abs_top_builddir@/src/secret', - '-I@abs_top_srcdir@/src/secret', - '-I@abs_top_builddir@/src/security', - '-I@abs_top_srcdir@/src/security', - '-I@abs_top_builddir@/src/util', - '-I@abs_top_srcdir@/src/util', - '-I@abs_top_builddir@/src/vmx', - '-I@abs_top_srcdir@/src/vmx', - '-I@abs_top_builddir@/src/xenconfig', - '-I@abs_top_srcdir@/src/xenconfig', -] - -def FlagsForFile(filename, **kwargs): - return { 'flags': flags, 'do_cache': True } diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index a8c9153b20..fac1338589 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -921,7 +921,6 @@ http_sites +=3D www.javvin.com # 404 links http_sites +=3D publib.boulder.ibm.com http_sites +=3D kerneltrap.org -http_sites +=3D valloric.github.io http_sites +=3D www.microsoft.com http_sites +=3D xenbits.xen.org http_sites +=3D lovezutto.googlepages.com diff --git a/docs/developer-tooling.rst b/docs/developer-tooling.rst deleted file mode 100644 index c8980e3e4f..0000000000 --- a/docs/developer-tooling.rst +++ /dev/null @@ -1,13 +0,0 @@ -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D -Developer tooling -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - -libvirt includes support for some useful development tools right -in its source repository, meaning users will be able to take -advantage of them without little or no configuration. Examples -include: - -- `color_coded `__, a vim - plugin for libclang-powered semantic syntax highlighting; -- `YouCompleteMe `__, a - vim plugin for libclang-powered semantic code completion. diff --git a/docs/hacking.rst b/docs/hacking.rst index cd009c4c73..1be9daab80 100644 --- a/docs/hacking.rst +++ b/docs/hacking.rst @@ -72,7 +72,6 @@ This page only covers the very basics, so it's recommende= d that you also take a look at the following documents: =20 - `Programming languages `__ -- `Developer tooling `__ - `Advanced test suite usage `__ - `Adoption of GLib APIs `__ - `Committer guidelines `__ diff --git a/docs/meson.build b/docs/meson.build index 7e070d68ad..690715a12e 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -95,7 +95,6 @@ docs_rst_files =3D [ 'committer-guidelines', 'compiling', 'daemons', - 'developer-tooling', 'drvqemu', 'drvch', 'formatbackup', diff --git a/meson.build b/meson.build index 519a928c9a..987d8a393f 100644 --- a/meson.build +++ b/meson.build @@ -2215,25 +2215,6 @@ configure_file( run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true) =20 =20 -# generate developer tooling files -tooling_files =3D [ - '.color_coded.in', - '.ycm_extra_conf.py.in', -] - -tooling_conf =3D configuration_data() -tooling_conf.set('abs_top_builddir', meson.build_root()) -tooling_conf.set('abs_top_srcdir', meson.source_root()) - -foreach file : tooling_files - configure_file( - input: file, - output: '@BASENAME@', - configuration: tooling_conf, - ) -endforeach - - # print configuration summary =20 driver_summary =3D { --=20 2.35.1