[libvirt PATCH v2 00/10] Automatic mutex management - part 3

Tim Wiederhake posted 10 patches 2 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220304172840.66057-1-twiederh@redhat.com
src/admin/admin_server_dispatch.c   |   3 +-
src/esx/esx_stream.c                |  65 ++++------
src/esx/esx_vi.c                    | 109 +++++++---------
src/openvz/openvz_driver.c          |  91 +++++---------
src/remote/remote_daemon_dispatch.c | 187 +++++++++-------------------
src/storage/storage_driver.c        |  32 ++---
src/test/test_driver.c              |  15 +--
src/util/virnetdev.c                |  20 ++-
src/util/virnodesuspend.c           |  54 +++-----
9 files changed, 193 insertions(+), 383 deletions(-)
[libvirt PATCH v2 00/10] Automatic mutex management - part 3
Posted by Tim Wiederhake 2 years, 1 month ago
Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD
to simplify mutex management.

v1: https://listman.redhat.com/archives/libvir-list/2022-February/msg00674.html

Changed since v1:
* Removed locking / unlocking in storage driver initialization and cleanup
  instead of working around the issue of the lifetime of the mutex.

Tim Wiederhake (10):
  test: Use automatic mutex management
  openvz: Use automatic mutex management
  remote_daemon_dispatch: Use automatic mutex management
  netdev: Use automatic mutex management
  nodesuspend: Use automatic mutex management
  admin: Use automatic mutex management
  esx_stream: Use automatic mutex management
  esx_vi: Use automatic mutex management
  storage: Removing mutex locking in initialization and cleanup
  storage: Use automatic mutex management

 src/admin/admin_server_dispatch.c   |   3 +-
 src/esx/esx_stream.c                |  65 ++++------
 src/esx/esx_vi.c                    | 109 +++++++---------
 src/openvz/openvz_driver.c          |  91 +++++---------
 src/remote/remote_daemon_dispatch.c | 187 +++++++++-------------------
 src/storage/storage_driver.c        |  32 ++---
 src/test/test_driver.c              |  15 +--
 src/util/virnetdev.c                |  20 ++-
 src/util/virnodesuspend.c           |  54 +++-----
 9 files changed, 193 insertions(+), 383 deletions(-)

-- 
2.31.1
Re: [libvirt PATCH v2 00/10] Automatic mutex management - part 3
Posted by Tim Wiederhake 2 years, 1 month ago
ping

On Fri, 2022-03-04 at 18:28 +0100, Tim Wiederhake wrote:
> Use the recently implemented VIR_LOCK_GUARD and
> VIR_WITH_MUTEX_LOCK_GUARD
> to simplify mutex management.
> 
> v1:
> https://listman.redhat.com/archives/libvir-list/2022-February/msg00674.html
> 
> Changed since v1:
> * Removed locking / unlocking in storage driver initialization and
> cleanup
>   instead of working around the issue of the lifetime of the mutex.
> 
> Tim Wiederhake (10):
>   test: Use automatic mutex management
>   openvz: Use automatic mutex management
>   remote_daemon_dispatch: Use automatic mutex management
>   netdev: Use automatic mutex management
>   nodesuspend: Use automatic mutex management
>   admin: Use automatic mutex management
>   esx_stream: Use automatic mutex management
>   esx_vi: Use automatic mutex management
>   storage: Removing mutex locking in initialization and cleanup
>   storage: Use automatic mutex management
> 
>  src/admin/admin_server_dispatch.c   |   3 +-
>  src/esx/esx_stream.c                |  65 ++++------
>  src/esx/esx_vi.c                    | 109 +++++++---------
>  src/openvz/openvz_driver.c          |  91 +++++---------
>  src/remote/remote_daemon_dispatch.c | 187 +++++++++-----------------
> --
>  src/storage/storage_driver.c        |  32 ++---
>  src/test/test_driver.c              |  15 +--
>  src/util/virnetdev.c                |  20 ++-
>  src/util/virnodesuspend.c           |  54 +++-----
>  9 files changed, 193 insertions(+), 383 deletions(-)
> 
> -- 
> 2.31.1
> 
> 


Re: [libvirt PATCH v2 00/10] Automatic mutex management - part 3
Posted by Michal Prívozník 2 years, 1 month ago
On 3/4/22 18:28, Tim Wiederhake wrote:
> Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD
> to simplify mutex management.
> 
> v1: https://listman.redhat.com/archives/libvir-list/2022-February/msg00674.html
> 
> Changed since v1:
> * Removed locking / unlocking in storage driver initialization and cleanup
>   instead of working around the issue of the lifetime of the mutex.
> 
> Tim Wiederhake (10):
>   test: Use automatic mutex management
>   openvz: Use automatic mutex management
>   remote_daemon_dispatch: Use automatic mutex management
>   netdev: Use automatic mutex management
>   nodesuspend: Use automatic mutex management
>   admin: Use automatic mutex management
>   esx_stream: Use automatic mutex management
>   esx_vi: Use automatic mutex management
>   storage: Removing mutex locking in initialization and cleanup
>   storage: Use automatic mutex management
> 
>  src/admin/admin_server_dispatch.c   |   3 +-
>  src/esx/esx_stream.c                |  65 ++++------
>  src/esx/esx_vi.c                    | 109 +++++++---------
>  src/openvz/openvz_driver.c          |  91 +++++---------
>  src/remote/remote_daemon_dispatch.c | 187 +++++++++-------------------
>  src/storage/storage_driver.c        |  32 ++---
>  src/test/test_driver.c              |  15 +--
>  src/util/virnetdev.c                |  20 ++-
>  src/util/virnodesuspend.c           |  54 +++-----
>  9 files changed, 193 insertions(+), 383 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal