From nobody Tue May 14 23:16:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1645124186077718.2046883415087; Thu, 17 Feb 2022 10:56:26 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-WopHCfAgOKil25B8wvlliw-1; Thu, 17 Feb 2022 13:56:23 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB6D51091DA2; Thu, 17 Feb 2022 18:56:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FA167DE34; Thu, 17 Feb 2022 18:56:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DEC2A4BB7C; Thu, 17 Feb 2022 18:56:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21HIuALL032620 for ; Thu, 17 Feb 2022 13:56:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3B9864022C8; Thu, 17 Feb 2022 18:56:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 375C048FB08 for ; Thu, 17 Feb 2022 18:56:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BBF11C01E97 for ; Thu, 17 Feb 2022 18:56:10 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-7DnA8mkROGiK-AthwuI1Dg-1; Thu, 17 Feb 2022 13:56:08 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-12-0DZ1-pEfMfCNRsUxMS887A-1; Thu, 17 Feb 2022 19:56:05 +0100 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) by DBBPR04MB7580.eurprd04.prod.outlook.com (2603:10a6:10:1f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Thu, 17 Feb 2022 18:56:04 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::9940:7464:6d80:5578]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::9940:7464:6d80:5578%6]) with mapi id 15.20.4995.018; Thu, 17 Feb 2022 18:56:04 +0000 X-MC-Unique: WopHCfAgOKil25B8wvlliw-1 X-MC-Unique: 7DnA8mkROGiK-AthwuI1Dg-1 X-MC-Unique: 0DZ1-pEfMfCNRsUxMS887A-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Fix libvirtd crash on domain restore Date: Thu, 17 Feb 2022 11:56:01 -0700 Message-ID: <20220217185601.12531-1-jfehlig@suse.com> X-ClientProxiedBy: AM5PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::14) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 161fb755-9dc3-4b4f-30ed-08d9f2472618 X-MS-TrafficTypeDiagnostic: DBBPR04MB7580:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: M2SK1PZ/ZZyH0rpQLF/wv3Bv/K7V2Lf3nAHmVaQGDOHOwsl9qYIOvS00P5COLJ1satO/ENDewSnGZzMsPw9REZuy6S3wUDBmns8qbfsT7IyqIy+hKDNfjQ9InWyZBPojk6TfHPNgdt3uWJMXtJHSs15FAIkq7p50oUohGImcQ80yZ14w1Wev7+2oSPUuVn8OsBNAJlNFGV1LryG/kX2H2Supxc2ITmwirnh10kzqnyyiK2r2lTCP3vzf9RDvtF6rL6D7pVkMX0wPI3hZhv5FakkkaVzSSeRXdLqoZM5+osITlzJ0ZUz1elr/IsiNED9OwqVDJmZWpfvhM2zOtIIDaG1/zybyWYs+sKX1+BeUgABah5GhanSAGnuZh3RboxUNJG+CFQ+eqbtrSLicDlrnA9VSB1iRyMPnt11Wj1dkVtUxUFea6jNLpjYA0bpKZHFmAUKqEMWL1UfdggCY8ha7grqHu1Wzymk6qAy8ZpVlSX/vJiRVtvmyAOecO+Oj0yncM6W5fWVnQjP1xHsJwu3J+nxt25YENMgqQ3rQLzaTt8NzIs+5yUUVm7YBGqf4J0L6Y7s+90a17R6Lm18VfrFNntetdhE5QID3IpJu13hOvMh+gEmgexfHtqsvJUtHnHuqEWdGK9MvdDNHN4mOIfBj8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4899.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(66556008)(6512007)(2616005)(36756003)(83380400001)(66946007)(6916009)(66476007)(8936002)(5660300002)(6506007)(1076003)(26005)(86362001)(186003)(6666004)(6486002)(8676002)(4744005)(38100700002)(2906002)(508600001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q99ahI8o8KAVgRQgASfwkw2kXxoZfcWYMWxNNWQYjvV9wNWe7Nx/wuE5qSAj?= =?us-ascii?Q?Cyfrh9ra/WxbJlZR8YSSzhrQp2zAOYcPNN1CfVNQrS7H+HBV3M3hNTVV2nOA?= =?us-ascii?Q?Slbj9p1LWawXZDz+hwO30ZHncfTXNzBtAqc6gZ+4BBRTTO7KHxbQgqi7rvDC?= =?us-ascii?Q?4t2S0E0DB5j+uiXvOhdOfmT0yzV08Ggvy+NGdE8MC5E4dtSl63BDbqp//Dxp?= =?us-ascii?Q?xTt/O5k0GFXywKKqU8qjvnExFrtpNzd9LTv4DH/F7+vRmeBGP/tEUQZfWZU5?= =?us-ascii?Q?Eww67UiKCdE14jk03Ty/bw3OWgM1KsNyDUj5tFC3cFlmczgI/jJJs1TMyDDA?= =?us-ascii?Q?g4yb6DX734eFAd8ouGYbLFvAbrdJhPfbn0EuCT75ysjoI/RygiusuCdvxe5g?= =?us-ascii?Q?SOCsqYwNuryqF6eIQqCKD6Rw5ilwsLgraHxnkQ79LBsD6V8doVx1ZnEQned2?= =?us-ascii?Q?ZnkcoUsE6NHS+6zGuTIpSjkw0S0zWnjxgkHO6sSXgfLt8aDLw1D6nDF9QEcw?= =?us-ascii?Q?TVlgA9HA1XIJfVnAoot9r4mz2zu5NiObAlR2l5izhnwItJevKmX2qcuMliiR?= =?us-ascii?Q?vDwxrGq5kA+pRHAdMU2PIACSYxdUedwMzjCg48A/3/OzsPUTGPIDMowTtpTR?= =?us-ascii?Q?67MVSWxuz19OPImHrOFz6mC28FykbvTIZmNlzJ32hP2QAUC1ztPsMG00pHrK?= =?us-ascii?Q?akh4Nc23n5tW+/uCGOWB8r+rGrkxa0bPCSOkIi0cbL4TmvJD+PVjXZn4WOV9?= =?us-ascii?Q?UqhCck8XK8l5PrHat0ns4wTMjckPQ6EevOVwDUZokhylcB1mZJYEioa6+J2+?= =?us-ascii?Q?K2AZuuGdbqJVHe1ZI20UtbIDIFDD5mMfep9f78MpQ4wk/vxuRx3KidVeRA/7?= =?us-ascii?Q?C6vrjvD1fsV3keDOTDjOwlYbg0Bt2aIKwHrlho3XRxIXpStagfrYG7isaoER?= =?us-ascii?Q?2Ky/VtQKTggjEAXqsIk/qRqjzQJOAgVG1iHLk5DujId+WkgABVMjhx/5+eN8?= =?us-ascii?Q?JzL2Ic2e2LO1NPJjo3v910KVM4g257BjkMFADg0fwk9eBmCbGO3Dv5nuF7t/?= =?us-ascii?Q?48+amDTFW7E3JUfxmBLAPBJsOV1mIaNMqn37Ay5grL667TLWO3RYWL66sBaC?= =?us-ascii?Q?kVjlui/HmIxgnbAJuTATw4r4ovC+Q+/vWSpOftUTC/eENhzKmXooXAnIhCie?= =?us-ascii?Q?/DvS4Ewqn/XyIftY959RyEa3U06kwDQjYiRvpyi8lcr2oFvTR7Cs0OZ27DCV?= =?us-ascii?Q?yY33IaHiyDwyDbzDXsLpv7DVR/467vs+a9de5P9FFN/48GM+fWxgMLjyx1r4?= =?us-ascii?Q?DmD7zbCcIiTZgxmFMcO0VpSnMBqIBXMrs7bsIjT3Owy1LrT+/W1OD1br+pnz?= =?us-ascii?Q?ytQTs4cfT9q8cjV67fpd2kO6xaTuBd+N5fzDKS2AioaWle7G1qjGPTAKcIAN?= =?us-ascii?Q?8flyL/dD2BkkIM+cqSn9tjSkDVkeH4LUMFuNO5dpFV8oLiXhKvoFaQd7gq3M?= =?us-ascii?Q?mXx3Q3gvHsAzj/7mD8nSZalskEHHcV9Dgs598SXU6kiok06hgdgnqUAZT5Zk?= =?us-ascii?Q?1PmTeYG/XKJxcbojS9Dxgrpj6mhGEXL9q/tO7udByWvw1sOXrg8cs11+DqrB?= =?us-ascii?Q?SRhoIGNGGfAeXtgnU/fWfts=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 161fb755-9dc3-4b4f-30ed-08d9f2472618 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 18:56:04.6448 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RXjntvXzEv7D23eELFHwag0OoAlwn6DLz6GmskjXGYjFmOxmKew4avDPFc5EKoU7IGg8EoSGjoiOhwQHdE8fiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7580 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 21HIuALL032620 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1645124186805100001 Content-Type: text/plain; charset="utf-8" Commit cc2a3c2a94 missed one case in the libxl driver where virDomainDef is returned from libxlDomainSaveImageOpen and a g_steal_pointer is needed. Without it, the virDomainDef object is freed and the driver crashes later in the restore process when accessing the object. Signed-off-by: Jim Fehlig Reviewed-by: J=C3=A1n Tomko --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index c91e531a9a..ee031267ca 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -811,7 +811,7 @@ libxlDomainSaveImageOpen(libxlDriverPrivate *driver, VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE= ))) goto error; =20 - *ret_def =3D def; + *ret_def =3D g_steal_pointer(&def); *ret_hdr =3D hdr; =20 return fd; --=20 2.35.1