[v1] Fix the dupliacated cpus used in different cells issue

[PATCH] Fix the dupliacated cpus used in different cells issue

Posted by Jing Qi 2 years, 2 months ago

Signed-off-by: Jing Qi <jinqi@redhat.com>
---
 docs/formatdomain.rst | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 24611f0f09..f69957d8c3 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -1662,14 +1662,13 @@ ACPI Heterogeneous Memory Attribute Table
    <cpu>
      ...
      <numa>
-       <cell id='0' cpus='0-3' memory='512000' unit='KiB' discard='yes'/>
-       <cell id='1' cpus='4-7' memory='512000' unit='KiB' memAccess='shared'/>
-       <cell id='3' cpus='0-3' memory='2097152' unit='KiB'>
+       <cell id='0' cpus='0-3' memory='2097152' unit='KiB'>
          <cache level='1' associativity='direct' policy='writeback'>
            <size value='10' unit='KiB'/>
            <line value='8' unit='B'/>
          </cache>
        </cell>
+       <cell id='1' cpus='4-7' memory='512000' unit='KiB' memAccess='shared'/>
        <interconnects>
          <latency initiator='0' target='0' type='access' value='5'/>
          <latency initiator='0' target='0' cache='1' type='access' value='10'/>
-- 
2.32.0

Re: [PATCH] Fix the dupliacated cpus used in different cells issue

Posted by Michal Prívozník 2 years, 2 months ago

On 2/10/22 08:02, Jing Qi wrote:
> Signed-off-by: Jing Qi <jinqi@redhat.com>
> ---
>  docs/formatdomain.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 24611f0f09..f69957d8c3 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -1662,14 +1662,13 @@ ACPI Heterogeneous Memory Attribute Table
>     <cpu>
>       ...
>       <numa>
> -       <cell id='0' cpus='0-3' memory='512000' unit='KiB' discard='yes'/>
> -       <cell id='1' cpus='4-7' memory='512000' unit='KiB' memAccess='shared'/>
> -       <cell id='3' cpus='0-3' memory='2097152' unit='KiB'>
> +       <cell id='0' cpus='0-3' memory='2097152' unit='KiB'>

This drops discard attribute.

>           <cache level='1' associativity='direct' policy='writeback'>
>             <size value='10' unit='KiB'/>
>             <line value='8' unit='B'/>
>           </cache>
>         </cell>
> +       <cell id='1' cpus='4-7' memory='512000' unit='KiB' memAccess='shared'/>
>         <interconnects>
>           <latency initiator='0' target='0' type='access' value='5'/>
>           <latency initiator='0' target='0' cache='1' type='access' value='10'/>


Fixed the commit message and pushed.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal