qemu: Improve swtpm internal API

[libvirt PATCH 00/14] qemu: Improve swtpm internal API

Posted by Andrea Bolognani 2 years, 2 months ago

Clean up inconsistencies to make navigating the module easier.

Andrea Bolognani (14):
  qemu: Rename qemuExtTPMStartEmulator()
  qemu: Fully document qemuTPMEmulatorStart()
  qemu: Rename qemuTPM{Create,Delete}EmulatorStorage()
  qemu: Document qemuTPMEmulatorDeleteStorage()
  qemu: Drop qemuTPMEmulatorInitStorage()
  qemu: Make qemuTPMEmulatorCreateStorage() take a virDomainTPMDef*
  qemu: Introduce qemuExtTPMEmulatorSetupCgroup()
  qemu: Introduce qemuTPMEmulatorCleanupHost()
  qemu: Rename path-building functions
  qemu: Call virDomainDefGetShortName() less frequently
  qemu: Fix description of swtpmStateDir
  qemu: Move utility functions close together
  qemu: Move entry points close together
  qemu: Move high-level actions close together

 src/qemu/qemu_tpm.c | 606 +++++++++++++++++++++++---------------------
 1 file changed, 323 insertions(+), 283 deletions(-)

-- 
2.34.1

Re: [libvirt PATCH 00/14] qemu: Improve swtpm internal API

Posted by Ján Tomko 2 years, 2 months ago

On a Friday in 2022, Andrea Bolognani wrote:
>Clean up inconsistencies to make navigating the module easier.
>
>Andrea Bolognani (14):
>  qemu: Rename qemuExtTPMStartEmulator()
>  qemu: Fully document qemuTPMEmulatorStart()
>  qemu: Rename qemuTPM{Create,Delete}EmulatorStorage()
>  qemu: Document qemuTPMEmulatorDeleteStorage()
>  qemu: Drop qemuTPMEmulatorInitStorage()
>  qemu: Make qemuTPMEmulatorCreateStorage() take a virDomainTPMDef*
>  qemu: Introduce qemuExtTPMEmulatorSetupCgroup()
>  qemu: Introduce qemuTPMEmulatorCleanupHost()
>  qemu: Rename path-building functions
>  qemu: Call virDomainDefGetShortName() less frequently
>  qemu: Fix description of swtpmStateDir
>  qemu: Move utility functions close together
>  qemu: Move entry points close together
>  qemu: Move high-level actions close together
>
> src/qemu/qemu_tpm.c | 606 +++++++++++++++++++++++---------------------
> 1 file changed, 323 insertions(+), 283 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano