syntax-check: Suggest correct replacement for str(n)dup()

[libvirt PATCH] syntax-check: Suggest correct replacement for str(n)dup()

Andrea Bolognani posted 1 patch 2 years, 2 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220203141726.400756-1-abologna@redhat.com

build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] syntax-check: Suggest correct replacement for str(n)dup()

Posted by Andrea Bolognani 2 years, 2 months ago

As of 610963cd0411 VIR_STRDUP() no longer exists.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 build-aux/syntax-check.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index d5cdb3c70e..b96d126bdc 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -244,7 +244,7 @@ sc_prohobit_vsnprintf:
 
 sc_prohibit_strdup:
 	@prohibit='\<strn?dup\> *\(' \
-	halt='use VIR_STRDUP, not strdup' \
+	halt='use g_str(n)dup, not str(n)dup' \
 	  $(_sc_search_regexp)
 
 # Prefer virSetUIDGID.
-- 
2.34.1

Re: [libvirt PATCH] syntax-check: Suggest correct replacement for str(n)dup()

Posted by Ján Tomko 2 years, 2 months ago

On a Thursday in 2022, Andrea Bolognani wrote:
>As of 610963cd0411 VIR_STRDUP() no longer exists.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> build-aux/syntax-check.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano