From nobody Sun May 19 11:31:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1633495341281845.5836525868729; Tue, 5 Oct 2021 21:42:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-9vLsFRsFOJ6qxS6IGnjNsA-1; Wed, 06 Oct 2021 00:42:18 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47E411808310; Wed, 6 Oct 2021 04:42:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA13A10013D7; Wed, 6 Oct 2021 04:42:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB86E1800FE4; Wed, 6 Oct 2021 04:42:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1964fxaY023355 for ; Wed, 6 Oct 2021 00:41:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0BE931112C19; Wed, 6 Oct 2021 04:41:59 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 068B21112C1E for ; Wed, 6 Oct 2021 04:41:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A32F811E7A for ; Wed, 6 Oct 2021 04:41:56 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-dHTF_dPBOsi9KDseRYJvHw-1; Wed, 06 Oct 2021 00:41:54 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-7-MZje2rgAMKKqHh8EDzpQQA-1; Wed, 06 Oct 2021 06:41:52 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR04MB6674.eurprd04.prod.outlook.com (2603:10a6:208:17a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct 2021 04:41:51 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::2ce6:80e:c776:afbf]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::2ce6:80e:c776:afbf%5]) with mapi id 15.20.4566.022; Wed, 6 Oct 2021 04:41:51 +0000 Received: from localhost (192.150.159.35) by AM6PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:20b:6e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 04:41:50 +0000 X-MC-Unique: 9vLsFRsFOJ6qxS6IGnjNsA-1 X-MC-Unique: dHTF_dPBOsi9KDseRYJvHw-1 X-MC-Unique: MZje2rgAMKKqHh8EDzpQQA-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] tools: Fix virt-host-validate SEV detection Date: Tue, 5 Oct 2021 22:41:47 -0600 Message-ID: <20211006044147.4176-1-jfehlig@suse.com> X-ClientProxiedBy: AM6PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:20b:6e::31) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e3cb761-8aa0-4d71-645d-08d988839d44 X-MS-TrafficTypeDiagnostic: AM0PR04MB6674: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:989 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: qnF/SQGXsQNXqUNYd9zaQiosygqFub00vwDpBshF/2/PhnjahVyxLYlifViW0p/ceLTe25ZHWVVa/sqXpvOjQcqTPy9rPWv746E2qOco4GzgPbglqRPLyIH0Esa++qTf8fh7bo/AD9OplTjYAaCYB6CPGIXmILQO9tPKc7hS3WX0j334RPOsPmhF9kmiDorROCwPyXrKa6CHMqjLSjIp+1ZkV1Lccg4N5fnWDfYL4DB1SR1BcuzYBrGk1LCvG6JAXv93cUjrB960pEXtm1Oy/F1jLtwF37JSk8K+xSY0Uxyw+bagKLsNY4XpdmlCy9Wq6AX1FCQBJteoma5rG1Kz3xxsr03Rj2NcS9lNT44gptX3n7x2tZ3nEXRliu8y9JZgrJrWTDqk1U9f/K0febqO2CeH8zuUhhFtJ/U9fMy58Bs2744QaOZKm7Zg30ds1kwo0YiBappVSmaEUsNiN8cHczZ16LbJnC9DSSfebuFGOnZAFaG4eaMdO+j13YxG/vR8L2JBn7nD4EYIHZoGPJpbHIxgJgpeREpRAf0gweE4FVSmL3TuUX435YyOdkzPaTEPvM29JVuHZOhjvmpfF57GyX45rmZJ5XGIg+LcFEJlMbqQD/+qbpdKs8GYac//M9SU6HdLspYdEPQnQZcCmE1bTCVqgudxOCcHVoH+/8t+YWaB3j0JI2taF7FgEBooDI7KjyEcoh8L2tqwp9pOWBPc2VbKtxLXfbkOqsuzqk19BXE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(15650500001)(2616005)(83380400001)(2906002)(86362001)(508600001)(6496006)(966005)(956004)(1076003)(8676002)(316002)(6486002)(36756003)(6916009)(6666004)(38100700002)(186003)(5660300002)(66476007)(66556008)(66946007)(26005); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QAo4q2JlezgctHejIlAR8dF+qmVWpqN3HfKHXsGA84O74M5v5p3MJsOGfMLj?= =?us-ascii?Q?uABE3P0hicEJ8KUFalOK32VEgZ6p9/eR9W6OpQ7x6XFTQbWDk/zxoFtup0wA?= =?us-ascii?Q?jQ3DhQXmt0OfH0U5Kh4NIjfRFrqdJ6GnWEYCER1aKaWO+T/6Nb0PwM6Q2vDX?= =?us-ascii?Q?lXtZk4PC4WjMJIfgCs2xIBLdjQe/fPHxy8VMaBhAyx6h5kmqDfVeJTNf4ifI?= =?us-ascii?Q?d2oZ+Yd7iC3opFvkvPoWu0GaTRUc0/E4E8GFo4zQT2tIt+0D9AAdQb/C/pPI?= =?us-ascii?Q?zzrhtDDsHVixwLGkd6VF/Tlb3vF4Rqkf79bUaPZuyFS3eNyQQYYUXlSmAJ6H?= =?us-ascii?Q?t7h2p9RJVP+k33mcVEMhrhVU+SaU3mZsxuA2QNTfDeM9w5o33jcmpHpMT//T?= =?us-ascii?Q?alVPbB8fTtzSh8wFivGsD0P85y0PAM8+rXtbjtX6Zad7Kt7UlxL3xFwGjEJ3?= =?us-ascii?Q?cnwAQyywhX++cUWubC6Lu6oG0CQ6Pfq4I8V5iXdQC9UHO4btaHBR/XkPxC5J?= =?us-ascii?Q?GFgdmtPPF1IcblcSKpZhG1a7b4C9NMgzia1qvfBrzucs90g1qdRg84/TnSMf?= =?us-ascii?Q?uRVrR2AD1B94UoLK8hhNOs+O/u0Juf0I4dEskJN08x5UYYdkO2lFhLtm7v0S?= =?us-ascii?Q?3ghUruYXXvOa9bxQmi6RACXfExq4De2802QttMzRFl0XhAMl63NwjODt2L3w?= =?us-ascii?Q?04p3CZF11bdMHz2n03FmvmoTr65HefrXkqbxSg4geMI1We1wPkdT9WYgm3WK?= =?us-ascii?Q?xAgJ6HCmad8btS/dnxr2b+RSno5SKLA0vMSsxfOWmE2JpwZGdONcXlKMZFVh?= =?us-ascii?Q?iDmntd+XsYdEmj7jC22DNgpcIdEJiiGXzcgUON7cR+Ltq8MZxpNk3udhOiTl?= =?us-ascii?Q?RZKJWm/c8WQv9bpxePA1KsK2k99zZoF1wvebXcZNfZ5Pgv2LAfrQigiajGbp?= =?us-ascii?Q?gwuK4zUXseWTiNxB85Zs/iZEw6gTBzkc85fBxC+F4r3vl8jS8pWo7+TLwABu?= =?us-ascii?Q?JhoHn6QG7tzty2i4vmZw8W5tOFjExu4nTpXeHEbTOGAtgmvJsjN20yf+1ZkC?= =?us-ascii?Q?n6LifMUGmDtf6vo6M+S0P0nSI5rT8CQPX5vK4ywCj3RnzrCSlnEq4j761wsp?= =?us-ascii?Q?X7jC1iBxCBCHS3wzvLozAU52hxM++K6khGs/yDsB9X2VQw2QiRoF1JaaJhp6?= =?us-ascii?Q?Vo6Z1TBV+rsOW5nhJwY0n2n03AbTr43VnX/0f79RXgGKCTglJZxwWYmqz2sR?= =?us-ascii?Q?ZETivAMg2b8Bdxxtq8Ve+9I3SCNu/CBMUxfZ22phou8n3SsoNNLk9xSUnY0u?= =?us-ascii?Q?dpS1qfM9o9TOobkFR+AJQ6r/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e3cb761-8aa0-4d71-645d-08d988839d44 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 04:41:51.1628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q2DXjusiNAiFM0qTYKqyznwj1Z/LW9KaVXW1/rFumKljAE+Pe+T+/7mK6LRHSZkDlJjG5ag9yMgLJo6RxGKa+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6674 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1964fxaY023355 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1633495343031100001 Content-Type: text/plain; charset="utf-8" virt-host-validate checks if AMD SEV is enabled by verifying /sys/module/kvm_amd/parameters/sev is set to '1'. On a system running kernel 5.13, the parameter is reported as 'Y'. To be extra paranoid, add a check for 'y' along with 'Y' to complement the existing check for '1'. Fixes: https://bugzilla.opensuse.org/show_bug.cgi?id=3D1188715 Signed-off-by: Jim Fehlig Reviewed-by: Andrea Bolognani --- tools/virt-host-validate-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-c= ommon.c index 556223242d..ba7f54b4ce 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -501,7 +501,7 @@ int virHostValidateSecureGuests(const char *hvname, return VIR_HOST_VALIDATE_FAILURE(level); } =20 - if (mod_value[0] !=3D '1') { + if (mod_value[0] !=3D '1' && mod_value[0] !=3D 'Y' && mod_value[0]= !=3D 'y') { virHostMsgFail(level, "AMD Secure Encrypted Virtualization appears to= be " "disabled in kernel. Add kvm_amd.sev=3D1 " --=20 2.33.0