[libvirt PATCH 00/10] virHashNew refactorings - part III

Tim Wiederhake posted 10 patches 2 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210712093417.12622-1-twiederh@redhat.com
tests/nwfilterxml2firewalltest.c |  3 --
tests/qemumonitorjsontest.c      | 73 +++++++++++---------------------
2 files changed, 24 insertions(+), 52 deletions(-)
[libvirt PATCH 00/10] virHashNew refactorings - part III
Posted by Tim Wiederhake 2 years, 9 months ago
"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

Tim Wiederhake (10):
  testCompareXMLToArgvFiles: `virHashNew` cannot return NULL
  testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: Use automatic
    memory management
  testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: Remove
    superfluous `goto`s
  testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: `virHashNew`
    cannot return NULL
  testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: Use automatic memory
    management
  testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: Remove superfluous
    `goto`s
  testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: `virHashNew` cannot
    return NULL
  testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: Use automatic memory
    management
  testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: Remove superfluous
    `goto`s
  testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: `virHashNew` cannot
    return NULL

 tests/nwfilterxml2firewalltest.c |  3 --
 tests/qemumonitorjsontest.c      | 73 +++++++++++---------------------
 2 files changed, 24 insertions(+), 52 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/10] virHashNew refactorings - part III
Posted by Peter Krempa 2 years, 9 months ago
On Mon, Jul 12, 2021 at 11:34:07 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>