On 6/11/21 12:49 PM, Han Han wrote:
> On Fri, Jun 11, 2021 at 4:55 PM Michal Prívozník <mprivozn@redhat.com>
> wrote:
>
>> On 6/9/21 10:32 AM, Han Han wrote:
>>> Diff from v1:
>>> - Leave qemuBuildVirtioDevStr() unmodified
>>> - New patch: qemu_validate: Validate virtio*gl* devices for 3d
>>> accerlation
>>> - Use DO_TEST_CAPS_LATEST instead of DO_TEST
>>> - Save video-virtio-vga-gpu-gl.x86_64-latest.xml as the sym link of
>> tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml
>>>
>>> v1:
>> https://listman.redhat.com/archives/libvir-list/2021-June/msg00181.html
>>>
>>> Han Han (6):
>>> qemu_capabilities: Add QEMU_CAPS_VIRTIO_GPU_GL_PCI
>>> qemu_capabilities: Add QEMU_CAPS_VIRTIO_VGA_GL
>>> qemu_validate: Validate virtio*gl* devices for 3d accerlation
>>> qemu: Adapt to virtio-gpu-gl-pci device
>>> qemu: Adapt to virtio-vga-gl device
>>> tests: Tests for virtio-vga-gl and virtio-gpu-gl-pci device
>>>
>>> src/qemu/qemu_capabilities.c | 4 ++
>>> src/qemu/qemu_capabilities.h | 2 +
>>> src/qemu/qemu_command.c | 8 ++++
>>> src/qemu/qemu_validate.c | 4 +-
>>> .../caps_6.1.0.x86_64.xml | 2 +
>>> ...video-virtio-vga-gpu-gl.x86_64-latest.args | 35 ++++++++++++++
>>> .../video-virtio-vga-gpu-gl.xml | 46 +++++++++++++++++++
>>> tests/qemuxml2argvtest.c | 1 +
>>> .../video-virtio-vga-gpu-gl.x86_64-latest.xml | 1 +
>>> tests/qemuxml2xmltest.c | 1 +
>>> 10 files changed, 103 insertions(+), 1 deletion(-)
>>> create mode 100644
>> tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.x86_64-latest.args
>>> create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml
>>> create mode 120000
>> tests/qemuxml2xmloutdata/video-virtio-vga-gpu-gl.x86_64-latest.xml
>>>
>>
>> Patches look good. Please let me know if you agree with me squashing in
>> suggested diffs.
>>
> Only a trivial suggestion to your diffs. Others look good to me.
Cool, in that case:
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
and pushed.
Michal