1. Patchew
  2. Libvirt
  3. View series

[libvirt PATCH 00/26] meson: Various fixes and improvements

Andrea Bolognani posted 26 patches 2 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210601083757.10194-1-abologna@redhat.com
libvirt.spec.in            |   3 +
meson.build                | 301 +++++++++++++++++++------------------
meson_options.txt          |   6 +-
mingw-libvirt.spec.in      |   2 +
src/locking/meson.build    |   4 +-
src/qemu/qemu_namespace.c  |   2 +-
src/util/virfile.c         |   8 +-
src/util/virnetdevbridge.c |  18 ---
8 files changed, 166 insertions(+), 178 deletions(-)
[libvirt PATCH 00/26] meson: Various fixes and improvements
Posted by Andrea Bolognani 2 years, 11 months ago 
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056

Andrea Bolognani (26):
  spec: Be explicit about more features
  meson: Whitespace tweaks
  meson: Don't use 'required: true'
  meson: Drop curl workaround
  meson: Drop netinet workaround
  meson: Use get_pkgconfig_variable('cflags')
  meson: Use built-in pcap detection
  meson: Make libm a required dependency
  meson: Drop numactl_version
  meson: Fix vstorage detection
  meson: Fix sanlock detection
  meson: Rewrite polkit check
  meson: Tweak XDR check
  meson: Fix disabling netcf
  meson: Rewrite firewalld check
  meson: Fix firewalld check
  meson: Rewrite libacl check
  meson: Use dependency() when possible
  meson: Rewrite apparmor_profiles check
  meson: Turn apparmor_profiles into a feature
  meson: Switch to autodetection for apparmor_profiles
  meson: Switch to autodetection for driver_remote
  meson: Switch to autodetection for driver_test
  meson: Style tweaks
  meson: Reorganize summary
  meson: Don't include warning flags in summary

 libvirt.spec.in            |   3 +
 meson.build                | 301 +++++++++++++++++++------------------
 meson_options.txt          |   6 +-
 mingw-libvirt.spec.in      |   2 +
 src/locking/meson.build    |   4 +-
 src/qemu/qemu_namespace.c  |   2 +-
 src/util/virfile.c         |   8 +-
 src/util/virnetdevbridge.c |  18 ---
 8 files changed, 166 insertions(+), 178 deletions(-)

-- 
2.31.1
Re: [libvirt PATCH 00/26] meson: Various fixes and improvements
Posted by Pavel Hrdina 2 years, 11 months ago 
On Tue, Jun 01, 2021 at 10:37:31AM +0200, Andrea Bolognani wrote:
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056
> 
> Andrea Bolognani (26):
>   spec: Be explicit about more features
>   meson: Whitespace tweaks
>   meson: Don't use 'required: true'
>   meson: Drop curl workaround
>   meson: Drop netinet workaround
>   meson: Use get_pkgconfig_variable('cflags')
>   meson: Use built-in pcap detection
>   meson: Make libm a required dependency
>   meson: Drop numactl_version
>   meson: Fix vstorage detection
>   meson: Fix sanlock detection
>   meson: Rewrite polkit check
>   meson: Tweak XDR check
>   meson: Fix disabling netcf
>   meson: Rewrite firewalld check
>   meson: Fix firewalld check
>   meson: Rewrite libacl check
>   meson: Use dependency() when possible
>   meson: Rewrite apparmor_profiles check
>   meson: Turn apparmor_profiles into a feature
>   meson: Switch to autodetection for apparmor_profiles
>   meson: Switch to autodetection for driver_remote
>   meson: Switch to autodetection for driver_test
>   meson: Style tweaks

For the above patches with the issues fixed.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

>   meson: Reorganize summary

I would post the changes as separate series so it's not blocking this
one.

>   meson: Don't include warning flags in summary

Once we have some other opinions as well.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Re: [libvirt PATCH 00/26] meson: Various fixes and improvements
Posted by Andrea Bolognani 2 years, 11 months ago 
On Tue, Jun 01, 2021 at 11:41:37AM +0200, Pavel Hrdina wrote:
> On Tue, Jun 01, 2021 at 10:37:31AM +0200, Andrea Bolognani wrote:
> > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056
> >
> > Andrea Bolognani (26):
> >   spec: Be explicit about more features
> >   meson: Whitespace tweaks
> >   meson: Don't use 'required: true'
> >   meson: Drop curl workaround
> >   meson: Drop netinet workaround
> >   meson: Use get_pkgconfig_variable('cflags')
> >   meson: Use built-in pcap detection
> >   meson: Make libm a required dependency
> >   meson: Drop numactl_version
> >   meson: Fix vstorage detection
> >   meson: Fix sanlock detection
> >   meson: Rewrite polkit check
> >   meson: Tweak XDR check
> >   meson: Fix disabling netcf
> >   meson: Rewrite firewalld check
> >   meson: Fix firewalld check
> >   meson: Rewrite libacl check
> >   meson: Use dependency() when possible
> >   meson: Rewrite apparmor_profiles check
> >   meson: Turn apparmor_profiles into a feature
> >   meson: Switch to autodetection for apparmor_profiles
> >   meson: Switch to autodetection for driver_remote
> >   meson: Switch to autodetection for driver_test
> >   meson: Style tweaks
>
> For the above patches with the issues fixed.
>
> Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

Thanks, I've pushed these now.

> >   meson: Reorganize summary
>
> I would post the changes as separate series so it's not blocking this
> one.

Fair point. I actually have more changes lined up that would alter
the summary further, so I might end up rolling the two together.

> >   meson: Don't include warning flags in summary
>
> Once we have some other opinions as well.
>
> Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

I'll rework this so that it's stand-alone and repost it.

Thanks again!

-- 
Andrea Bolognani / Red Hat / Virtualization

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.