From nobody Tue May 21 16:28:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622134597; cv=none; d=zohomail.com; s=zohoarc; b=LomIZxfr7QvU1tZOkCEw/bfJUBn4nqpqVGhrxhf/XQ0dYIjm2M+Kz0KRRknH8tEAMlgP9efx9Ja7EQDEmfJWPY1Tdj8z34yvjLRroFZEucEQiZcmPBNWCgZgDl9o3ho49op2bJery15ERFQ6IU8egFLR7aDjTb48VOq61JhPVKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622134597; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HoQ9KnB9EPS4PjX2iv6t0eNetY4PvQvhzYeTlPMZUt0=; b=j1Gw7sb46HpHibHqOtaMIfWhU5iRosZUhLyWkOH7/GCxuJCS+MlG61YwFosyc7h4O77TdGyuQJHC6P8B4ws+LFmUcJsWr6/XzcWDsB5r+eYpOoLy2N3xQZQag+Bvk6pr69lgufebXIPO2/gZtAbjjEO0eHXL50kYSu6EjDhwj1c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1622134597329234.40308686953028; Thu, 27 May 2021 09:56:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-DKLez3E2MhCnqEkagiXYQg-1; Thu, 27 May 2021 12:56:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 493FF800D55; Thu, 27 May 2021 16:56:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1460E60864; Thu, 27 May 2021 16:56:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9BBE61800BB4; Thu, 27 May 2021 16:56:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14RGuQHn009301 for ; Thu, 27 May 2021 12:56:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1770020ED7FD; Thu, 27 May 2021 16:56:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1303820ED7FB for ; Thu, 27 May 2021 16:56:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D7B190DE33 for ; Thu, 27 May 2021 16:56:22 +0000 (UTC) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-MHPzk65zOHOjw18K9mTuAA-1; Thu, 27 May 2021 12:56:20 -0400 Received: by mail-qk1-f173.google.com with SMTP id 82so1309688qki.8 for ; Thu, 27 May 2021 09:56:20 -0700 (PDT) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id w196sm1736512qkb.90.2021.05.27.09.56.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 May 2021 09:56:19 -0700 (PDT) X-MC-Unique: DKLez3E2MhCnqEkagiXYQg-1 X-MC-Unique: MHPzk65zOHOjw18K9mTuAA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HoQ9KnB9EPS4PjX2iv6t0eNetY4PvQvhzYeTlPMZUt0=; b=IUUljsDC+xF5A/o7DYYx+ykD4li7FAzIeCpp+7tsD9wKrDO4wAz/tMl8pTeomIj9cW 1JG4GIxcJ/DBl9K1iXZV2V18KfraLqtBrSphPee5LaY4V6LKrEmceb1ucrdyjfzdH03B UKGKbzam9dSKnfyf0cHteyUGRSsGG8MEPV1yXSkndcOqoZ1PHJiftBSYdP79uEFzGcxn UgCeb90WqQI2mL19JrYSkck0dFbP/rtsg2ABtCfdkIS5SstA8AZppciID4iihc0EUHO5 okyzr73qJIlSlqAh+En1MYX8VU9nVzAW49r+BmGwNPwg3ZR+iei/VVuRgpj1+ro9setp 3PzQ== X-Gm-Message-State: AOAM530QFvJbN0SgUrAFnvdtAb2EvVySvNRRJqanhahXTDYOZjAUppj7 9+DjsoxQDLIfm74RpbhL8P0aQ983og== X-Google-Smtp-Source: ABdhPJzrREhvNTdVVRAYMmchyXu7DjpuHjJizNJiE4RtCgwzr+MDDkfM7o10/pAAWmLokaUWbqy1dQ== X-Received: by 2002:a05:620a:4486:: with SMTP id x6mr4474415qkp.229.1622134579659; Thu, 27 May 2021 09:56:19 -0700 (PDT) From: Masayoshi Mizuma To: libvir-list@redhat.com Subject: [PATCH] qemuProcessSetupDisksTransientSnapshot: Skip enabling transientOverlayCreated flag Date: Thu, 27 May 2021 12:55:12 -0400 Message-Id: <20210527165512.569813-1-msys.mizuma@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma QEMU_DOMAIN_DISK_PRIVATE(disk)->transientOverlayCreated flag gets true unexpectedly on qemuProcessSetupDisksTransientSnapshot() when the disk has option. The flag should be enabled on qemuDomainAttachDiskGeneric() after the overlay setup is completed. Skip enabling transientOverlayCreated for the disk here. Fixes: 75871da0ecb8b552f9e304d0f83e216839bbf82d Signed-off-by: Masayoshi Mizuma Reviewed-by: Peter Krempa =20 --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9b069fe7ce..c37687f249 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7039,7 +7039,8 @@ qemuProcessSetupDisksTransientSnapshot(virDomainObj *= vm, for (i =3D 0; i < vm->def->ndisks; i++) { virDomainDiskDef *domdisk =3D vm->def->disks[i]; =20 - if (!domdisk->transient) + if (!domdisk->transient || + domdisk->transientShareBacking =3D=3D VIR_TRISTATE_BOOL_YES) continue; =20 QEMU_DOMAIN_DISK_PRIVATE(domdisk)->transientOverlayCreated =3D tru= e; --=20 2.27.0