[libvirt PATCH 00/10] remote: various refactoring & bugs for remote driver

Daniel P. Berrangé posted 10 patches 2 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210526132017.273817-1-berrange@redhat.com
src/admin/admin_remote.c            |   2 +-
src/locking/lock_driver_lockd.c     |   1 -
src/logging/log_manager.c           |   1 -
src/lxc/lxc_monitor.c               |   2 +-
src/qemu/qemu_migration.c           |   3 +-
src/remote/remote_daemon_dispatch.c |   4 +-
src/remote/remote_driver.c          | 135 ++++++++++++----------------
src/remote/remote_sockets.c         |  95 +++++++++++++-------
src/remote/remote_sockets.h         |  15 ++--
src/remote/remote_ssh_helper.c      |  16 ++--
src/rpc/virnetclient.c              |   5 +-
src/rpc/virnetclient.h              |   3 +-
src/rpc/virnetsocket.c              |  26 ++----
src/rpc/virnetsocket.h              |   3 +-
tests/virnetsockettest.c            |   4 +-
15 files changed, 157 insertions(+), 158 deletions(-)
[libvirt PATCH 00/10] remote: various refactoring & bugs for remote driver
Posted by Daniel P. Berrangé 2 years, 11 months ago
This is in prep for switching to use the modular daemons by default. In
testing that setup I hit a couple of minor bugs.

Daniel P. Berrangé (10):
  remote: use absolute path to check for daemons
  remote: stop checking for errors from socket allocations
  remote: move open flags enum to sockets header
  remote: consistently use flags for passing ro/user/autostart props
  remote: change socket helper to return full daemon path
  remote: don't populate daemon path if autostart is not required
  rpc: remove "spawnDaemon" parameter
  remote: move proxy/mode defaults after URI parsing
  remote: fix regression connecting to remote session daemon
  remote: use virtproxyd if no URI is given

 src/admin/admin_remote.c            |   2 +-
 src/locking/lock_driver_lockd.c     |   1 -
 src/logging/log_manager.c           |   1 -
 src/lxc/lxc_monitor.c               |   2 +-
 src/qemu/qemu_migration.c           |   3 +-
 src/remote/remote_daemon_dispatch.c |   4 +-
 src/remote/remote_driver.c          | 135 ++++++++++++----------------
 src/remote/remote_sockets.c         |  95 +++++++++++++-------
 src/remote/remote_sockets.h         |  15 ++--
 src/remote/remote_ssh_helper.c      |  16 ++--
 src/rpc/virnetclient.c              |   5 +-
 src/rpc/virnetclient.h              |   3 +-
 src/rpc/virnetsocket.c              |  26 ++----
 src/rpc/virnetsocket.h              |   3 +-
 tests/virnetsockettest.c            |   4 +-
 15 files changed, 157 insertions(+), 158 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/10] remote: various refactoring & bugs for remote driver
Posted by Ján Tomko 2 years, 11 months ago
On a Wednesday in 2021, Daniel P. Berrangé wrote:
>This is in prep for switching to use the modular daemons by default. In
>testing that setup I hit a couple of minor bugs.
>
>Daniel P. Berrangé (10):
>  remote: use absolute path to check for daemons
>  remote: stop checking for errors from socket allocations
>  remote: move open flags enum to sockets header
>  remote: consistently use flags for passing ro/user/autostart props
>  remote: change socket helper to return full daemon path
>  remote: don't populate daemon path if autostart is not required
>  rpc: remove "spawnDaemon" parameter
>  remote: move proxy/mode defaults after URI parsing
>  remote: fix regression connecting to remote session daemon
>  remote: use virtproxyd if no URI is given
>
> src/admin/admin_remote.c            |   2 +-
> src/locking/lock_driver_lockd.c     |   1 -
> src/logging/log_manager.c           |   1 -
> src/lxc/lxc_monitor.c               |   2 +-
> src/qemu/qemu_migration.c           |   3 +-
> src/remote/remote_daemon_dispatch.c |   4 +-
> src/remote/remote_driver.c          | 135 ++++++++++++----------------
> src/remote/remote_sockets.c         |  95 +++++++++++++-------
> src/remote/remote_sockets.h         |  15 ++--
> src/remote/remote_ssh_helper.c      |  16 ++--
> src/rpc/virnetclient.c              |   5 +-
> src/rpc/virnetclient.h              |   3 +-
> src/rpc/virnetsocket.c              |  26 ++----
> src/rpc/virnetsocket.h              |   3 +-
> tests/virnetsockettest.c            |   4 +-
> 15 files changed, 157 insertions(+), 158 deletions(-)
>

With the unused variable fixed:
Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano