Refactor more XML parsing boilerplate code, part XII

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XII

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainAudioPulseAudioParse: Use virXMLProp*
  virDomainAudioDef: Change type of "type" to virDomainAudioType
  virDomainAudioDef: Change type of "sdl.driver" to
    virDomainAudioSDLDriver
  virDomainAudioDefParseXML: Use virXMLProp*
  virDomainAudioDefParseXML: Don't ignore return value of
    virDomainAudio*Parse()
  virDomainIOMMUDefParseXML: Use virXMLProp*
  virStorageAdapterParseXML: Use g_autofree
  virStorageAdapterFCHost: Change type of "type" to
    virStorageAdapterType
  virStorageAdapterParseXML: Use virXMLProp*
  virDomainDeviceSpaprVioAddressParseXML: Use virXMLProp*

 src/bhyve/bhyve_command.c       |   2 +-
 src/conf/device_conf.c          |  14 +--
 src/conf/domain_conf.c          | 202 +++++++++++---------------------
 src/conf/domain_conf.h          |   4 +-
 src/conf/storage_adapter_conf.c |  38 ++----
 src/conf/storage_adapter_conf.h |   2 +-
 src/qemu/qemu_command.c         |   4 +-
 src/qemu/qemu_validate.c        |   2 +-
 8 files changed, 97 insertions(+), 171 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XII

Posted by Michal Prívozník 2 years, 11 months ago

On 5/19/21 4:10 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>   virDomainAudioPulseAudioParse: Use virXMLProp*
>   virDomainAudioDef: Change type of "type" to virDomainAudioType
>   virDomainAudioDef: Change type of "sdl.driver" to
>     virDomainAudioSDLDriver
>   virDomainAudioDefParseXML: Use virXMLProp*
>   virDomainAudioDefParseXML: Don't ignore return value of
>     virDomainAudio*Parse()
>   virDomainIOMMUDefParseXML: Use virXMLProp*
>   virStorageAdapterParseXML: Use g_autofree
>   virStorageAdapterFCHost: Change type of "type" to
>     virStorageAdapterType
>   virStorageAdapterParseXML: Use virXMLProp*
>   virDomainDeviceSpaprVioAddressParseXML: Use virXMLProp*
> 
>  src/bhyve/bhyve_command.c       |   2 +-
>  src/conf/device_conf.c          |  14 +--
>  src/conf/domain_conf.c          | 202 +++++++++++---------------------
>  src/conf/domain_conf.h          |   4 +-
>  src/conf/storage_adapter_conf.c |  38 ++----
>  src/conf/storage_adapter_conf.h |   2 +-
>  src/qemu/qemu_command.c         |   4 +-
>  src/qemu/qemu_validate.c        |   2 +-
>  8 files changed, 97 insertions(+), 171 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal