[PATCH] rpm: re-enable ppc64 on RHEL-8

Daniel P. Berrangé posted 1 patch 2 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210514115724.1368285-1-berrange@redhat.com
libvirt.spec.in | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH] rpm: re-enable ppc64 on RHEL-8
Posted by Daniel P. Berrangé 2 years, 11 months ago
Historically PowerPC 64 was always supported with qemu-kvm in RHEL.

In future RHEL-9 it is being discontinued and this was addressed
in

  commit 03cc3c9064322ac4028a2213105cd230fe28c013
  Author: Jiri Denemark <jdenemar@redhat.com>
  Date:   Wed Apr 21 14:55:03 2021 +0200

    spec: Do not build qemu driver for Power on RHEL-9

when the specfile was cleaned up to remove RHEL-7 support:

  commit 0f601d2f868f2017cdd16e0a7ca90a59e7d5e120
  Author: Andrea Bolognani <abologna@redhat.com>
  Date:   Wed May 5 19:30:46 2021 +0200

    spec: Bump min_fedora and min_rhel

it also removed the logic that applied to RHEL-8 wrt arch list
and lost PowerPC 64 support on 8. This reverts that part of the
change but with the condition reversed to prioritize the future
state.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f421828d16..8ac324be0a 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -8,7 +8,11 @@
 
 %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x
 %if 0%{?rhel}
-    %define arches_qemu_kvm     x86_64 aarch64 s390x
+    %if 0%{?rhel} > 8
+        %define arches_qemu_kvm     x86_64 aarch64 s390x
+    %else
+        %define arches_qemu_kvm     x86_64 %{power64} aarch64 s390x
+    %endif
 %endif
 
 %define arches_64bit            x86_64 %{power64} aarch64 s390x riscv64
-- 
2.31.1

Re: [PATCH] rpm: re-enable ppc64 on RHEL-8
Posted by Andrea Bolognani 2 years, 11 months ago
On Fri, May 14, 2021 at 12:57:24PM +0100, Daniel P. Berrangé wrote:
> Historically PowerPC 64 was always supported with qemu-kvm in RHEL.
>
> In future RHEL-9 it is being discontinued and this was addressed
> in
>
>   commit 03cc3c9064322ac4028a2213105cd230fe28c013
>   Author: Jiri Denemark <jdenemar@redhat.com>
>   Date:   Wed Apr 21 14:55:03 2021 +0200
>
>     spec: Do not build qemu driver for Power on RHEL-9
>
> when the specfile was cleaned up to remove RHEL-7 support:
>
>   commit 0f601d2f868f2017cdd16e0a7ca90a59e7d5e120
>   Author: Andrea Bolognani <abologna@redhat.com>
>   Date:   Wed May 5 19:30:46 2021 +0200
>
>     spec: Bump min_fedora and min_rhel
>
> it also removed the logic that applied to RHEL-8 wrt arch list
> and lost PowerPC 64 support on 8. This reverts that part of the
> change but with the condition reversed to prioritize the future
> state.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

My bad! Thanks for catching and fixing this :)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization


Re: [PATCH] rpm: re-enable ppc64 on RHEL-8
Posted by Neal Gompa 2 years, 11 months ago
On Fri, May 14, 2021 at 8:24 AM Andrea Bolognani <abologna@redhat.com> wrote:
>
> On Fri, May 14, 2021 at 12:57:24PM +0100, Daniel P. Berrangé wrote:
> > Historically PowerPC 64 was always supported with qemu-kvm in RHEL.
> >
> > In future RHEL-9 it is being discontinued and this was addressed
> > in
> >
> >   commit 03cc3c9064322ac4028a2213105cd230fe28c013
> >   Author: Jiri Denemark <jdenemar@redhat.com>
> >   Date:   Wed Apr 21 14:55:03 2021 +0200
> >
> >     spec: Do not build qemu driver for Power on RHEL-9
> >
> > when the specfile was cleaned up to remove RHEL-7 support:
> >
> >   commit 0f601d2f868f2017cdd16e0a7ca90a59e7d5e120
> >   Author: Andrea Bolognani <abologna@redhat.com>
> >   Date:   Wed May 5 19:30:46 2021 +0200
> >
> >     spec: Bump min_fedora and min_rhel
> >
> > it also removed the logic that applied to RHEL-8 wrt arch list
> > and lost PowerPC 64 support on 8. This reverts that part of the
> > change but with the condition reversed to prioritize the future
> > state.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  libvirt.spec.in | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
>
> My bad! Thanks for catching and fixing this :)
>
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>

Mechanically, this change is fine, so...

Reviewed-by: Neal Gompa <ngompa13@gmail.com>

But, I'm kind of surprised that this is going away, since IBM has put
special attention on improving PowerKVM support specifically for RHEL,
so this seems really weird...

-- 
真実はいつも一つ!/ Always, there's only one truth!