[v1] Refactor more XML parsing boilerplate code, part X

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part X

Tim Wiederhake posted 10 patches 2 years, 11 months ago

Diff against v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210511150157.26027-1-twiederh@redhat.com

There is a newer version of this series

src/conf/node_device_conf.c                   |  34 +--
src/conf/numa_conf.c                          | 285 +++++-------------
src/conf/storage_adapter_conf.c               |  17 +-
src/conf/storage_conf.c                       |  83 ++---
.../hugepages-memaccess-invalid.err           |   2 +-
5 files changed, 125 insertions(+), 296 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part X

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virNodeDeviceDefParseXML: Use g_auto*
  virDomainNumatuneNodeParseXML: Use virXMLProp*
  virDomainNumatuneNodeParseXML: Use g_autofree
  virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*
  virDomainNumaDefParseXML: Use virXMLProp*
  virDomainNumaDefParseXML: Use g_autofree
  virStorageAdapterParseXMLFCHost: Use virXMLProp*
  virStoragePoolDefParseSource: Use virXMLProp*
  virStoragePoolDefParseSource: Use VIR_XPATH_NODE_AUTORESTORE
  virStoragePoolDefParseXML: Use virXMLProp*

 src/conf/node_device_conf.c                   |  34 +--
 src/conf/numa_conf.c                          | 285 +++++-------------
 src/conf/storage_adapter_conf.c               |  17 +-
 src/conf/storage_conf.c                       |  83 ++---
 .../hugepages-memaccess-invalid.err           |   2 +-
 5 files changed, 125 insertions(+), 296 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part X

Posted by Michal Prívozník 2 years, 11 months ago

On 5/11/21 5:01 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>   virNodeDeviceDefParseXML: Use g_auto*
>   virDomainNumatuneNodeParseXML: Use virXMLProp*
>   virDomainNumatuneNodeParseXML: Use g_autofree
>   virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*
>   virDomainNumaDefParseXML: Use virXMLProp*
>   virDomainNumaDefParseXML: Use g_autofree
>   virStorageAdapterParseXMLFCHost: Use virXMLProp*
>   virStoragePoolDefParseSource: Use virXMLProp*
>   virStoragePoolDefParseSource: Use VIR_XPATH_NODE_AUTORESTORE
>   virStoragePoolDefParseXML: Use virXMLProp*
> 
>  src/conf/node_device_conf.c                   |  34 +--
>  src/conf/numa_conf.c                          | 285 +++++-------------
>  src/conf/storage_adapter_conf.c               |  17 +-
>  src/conf/storage_conf.c                       |  83 ++---
>  .../hugepages-memaccess-invalid.err           |   2 +-
>  5 files changed, 125 insertions(+), 296 deletions(-)
> 

I've pushed reviewed patches (07-10/10).

Michal