From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313739; cv=none; d=zohomail.com; s=zohoarc; b=MKTGmIgawlZzYcX2NMRQntzxgk7yeebr0lkPwAAgt0CXc8uzfXznbh6anzKeTO3cxtmc3AM5l+6zf/nVuPCgSrteKiA7H++PwAZLkRt0WK7M7P6MlrFra8FbP0CWDfXclmR3Iy4scZOh74jJQB0QQjCG9ad2J/F8hiyi0i+5lxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313739; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lkv/c7kOh/se+9zrOWL0+1qmpmvJaYxYC3hp8t4AQL0=; b=Q4DzCsktlrTz2BnrwYoysw/CUrGDMQojUFXby9JZkud2HKUHxr2SqXbxIbOeLXxlX7oc9HDw+EkB3pHWmLbTOKqOigLuUAanKlfnLDuwPWxP19URh6jIZYkXvZZSU7mZ+Ef4xbJWDEC2mgN32m+XALGCVV7HFwY3zcUpBTSAnX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620313739405572.2347508487624; Thu, 6 May 2021 08:08:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-pir0P2MENc-grE11BdjkBA-1; Thu, 06 May 2021 11:08:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EECD107ACE3; Thu, 6 May 2021 15:08:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2DAF6091A; Thu, 6 May 2021 15:08:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7A9B755351; Thu, 6 May 2021 15:08:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8it3008294 for ; Thu, 6 May 2021 11:08:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0A173189A5; Thu, 6 May 2021 15:08:44 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 510CC19C9B; Thu, 6 May 2021 15:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313737; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lkv/c7kOh/se+9zrOWL0+1qmpmvJaYxYC3hp8t4AQL0=; b=YQyAsdq7TXUSisM9ZK0xNLQu423XGGH9Xq6JJvW319j7vCkGbGorjePyJ+2e/Lu4/khPTw eIlcbpK3eGAe/bhh2aTQ/KP0oy0vNOk6Q/1DIsRxK2aBM7ELilwKulREIOqIM2LHYb1/3/ fsoHkH1y/DSsXAD9TIuxxV4tpYYZNdo= X-MC-Unique: pir0P2MENc-grE11BdjkBA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 1/7] meson: Allow larger stack frames when instrumenting Date: Thu, 6 May 2021 17:08:32 +0200 Message-Id: <20210506150838.30129-2-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When enabling sanitizers, gcc adds some instrumentation to the code that may enlarge stack frames. Some function's stack frames are already close to the limit of 4096 and are enlarged past that threshold, e.g. virLXCProcessStart which reaches a frame size of 4624 bytes. Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik Reviewed-by: Pavel Hrdina --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1f97842319..997a23f1b0 100644 --- a/meson.build +++ b/meson.build @@ -224,6 +224,9 @@ alloc_max =3D run_command( 'print(min(2**(@0@ * 8 - 1) - 1, 2**(@1@ * 8) - 1))'.format(ptrdiff_max,= size_max), ) =20 +# sanitizer instrumentation may enlarge stack frames +stack_frame_size =3D get_option('b_sanitize') =3D=3D 'none' ? 4096 : 8192 + cc_flags +=3D [ '-fasynchronous-unwind-tables', '-fexceptions', @@ -278,7 +281,7 @@ cc_flags +=3D [ '-Wformat-y2k', '-Wformat-zero-length', '-Wframe-address', - '-Wframe-larger-than=3D4096', + '-Wframe-larger-than=3D@0@'.format(stack_frame_size), '-Wfree-nonheap-object', '-Whsa', '-Wif-not-aligned', --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313751; cv=none; d=zohomail.com; s=zohoarc; b=FvwHtNuRATqAO676m2FHhIOX9rfA7I2u/CBx0tAlb4HMuRDyneId6jF0JT9MG3kMbUoxk1NydK2yDrQCHsulmcEJcUKYcGKiRimd7SUkeHCIJ7bAL08jdIyj+5q/5XQp5BCiVv2v6NJAyy2L5z9vJ2/jj4QrqHeM+1cUk+oWJ/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313751; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bQb/YtPr8UO6koq6vZ+sxJ+Wh65rla1v1IriL9n37sU=; b=G/oQTmgWjj4NisVrsrIqyUxR2yo+nk/bzuo0UePSqTSBGsT+1EQQ0i+w0x3YRh1LofDL0k4qH1cXu0fWtCC59+0YLKNlfZ9ivAlVoY6p2rQbvP4eIq3pmvWnOR0YWlYac7YuttDthBwOhSIh0xceKwxmWHhBWzbVx95G2R/5LPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620313751496593.9931829727722; Thu, 6 May 2021 08:09:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-Vw9-PUJ0PruTgCFu5OIjzA-1; Thu, 06 May 2021 11:09:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1C88800685; Thu, 6 May 2021 15:09:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BAA157998; Thu, 6 May 2021 15:09:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2BE331800B8A; Thu, 6 May 2021 15:09:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8j7j008304 for ; Thu, 6 May 2021 11:08:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 18B84189A5; Thu, 6 May 2021 15:08:45 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BBBE60657; Thu, 6 May 2021 15:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313749; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bQb/YtPr8UO6koq6vZ+sxJ+Wh65rla1v1IriL9n37sU=; b=XONpIPRrz845hbsUwvoUkdeJqYkt9m0Z8D1InJiK8DWfFNCOUyRWmpBP4Pcp76d3L164oR IkRoIgmr+0gaf97kjKMwX4h9SSdN9ME72+ca0vDIxP+/XvM5OBUN2n9zaXloD/9SUfgAqt ttbIv0XOcwOKBYHNj2UR0VBPxnGk7C8= X-MC-Unique: Vw9-PUJ0PruTgCFu5OIjzA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 2/7] meson: Allow undefined symbols when sanitizers are enabled Date: Thu, 6 May 2021 17:08:33 +0200 Message-Id: <20210506150838.30129-3-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When enabling sanitizers, clang adds some function symbols when instrumenting the code. The exact names of those functions are an implementation detail and should therefore not be added to any syms file. This patch prevents build failures due to those symbols not present in the syms file when building with sanitizers enabled. Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik Reviewed-by: Pavel Hrdina --- meson.build | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 997a23f1b0..02feb0e43d 100644 --- a/meson.build +++ b/meson.build @@ -491,9 +491,12 @@ libvirt_nodelete =3D cc.get_supported_link_arguments([ '-Wl,-z,nodelete', ]) =20 -libvirt_no_undefined =3D cc.get_supported_link_arguments([ - '-Wl,-z,defs', -]) +libvirt_no_undefined =3D [] +if get_option('b_sanitize') =3D=3D 'none' + libvirt_no_undefined +=3D cc.get_supported_link_arguments([ + '-Wl,-z,defs', + ]) +endif =20 libvirt_no_indirect =3D cc.get_supported_link_arguments([ '-Wl,--no-copy-dt-needed-entries', --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313858; cv=none; d=zohomail.com; s=zohoarc; b=jcqYYs1ohlb1+XGPc1BYT9eXUsIVGeJvLGblDQAG0r4n8VI3DGvgC06Z6gUvu6QNMdOy3JagOo3DVD5N2Ix4nofdqCkkjbq4q8Z34vDSV6P9KgwBaQhIU91Pc6455Bfj1CsFYgCBhOwHqtqDAsXopJl9qifNZSPR/Yg+6kHfx38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313858; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=X+STu4Nn0JfYIqJ5SjJVG/CrBjh0Io2WcxloP4WJjS0=; b=doNTvw5CB9ZOAcLyMBVAAKGdZwaM3D7+9yppZxHnel7n2/ll9e+9d+Uo7NRUGfdtl81kHzijnmHm99lcbk/zGvgxphzjpaDzXXKw8R6uiAH2S1mo31gpk1bNPsyw06wRC/gKGLXqLm6QddzL544uYcVBWdkr+Ip74CGzYEFyAN0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620313858658388.39955887131555; Thu, 6 May 2021 08:10:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-VbHOXJg2PwOYzP34vkYFvA-1; Thu, 06 May 2021 11:10:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46A77801B12; Thu, 6 May 2021 15:10:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21C3C5D9C0; Thu, 6 May 2021 15:10:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DECC21800B8A; Thu, 6 May 2021 15:10:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8kZc008310 for ; Thu, 6 May 2021 11:08:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 223BB189A5; Thu, 6 May 2021 15:08:46 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69EEE60657; Thu, 6 May 2021 15:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=X+STu4Nn0JfYIqJ5SjJVG/CrBjh0Io2WcxloP4WJjS0=; b=UaxyDOMH9NMmZ8I9yHBUp9Z6VdWrgDqchO0FtwOHzYFi8DwtTRN/aBMQRxXYvNRSBgHuG5 mTk6iE1momVlnBwXyrOQMFSNh/bnFZcvJf5qS3CqWNKmCRljcaflLCMLTDHuLfRCd0ovGC q5LfLOQI7iYxk+wLxKenPekJtrgEgCY= X-MC-Unique: VbHOXJg2PwOYzP34vkYFvA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 3/7] tests: virfilemock: realpath: Allow non-null second parameter Date: Thu, 6 May 2021 17:08:34 +0200 Message-Id: <20210506150838.30129-4-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When other preloaded libraries wrap and / or make calls to `realpath` (e.g. LLVM's AddessSanitizer), the second parameter is no longer guaranteed to be NULL. Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tests/virfilemock.c | 20 ++++++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 552d639119..03b7599abc 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1740,7 +1740,7 @@ exclude_file_name_regexp--sc_libvirt_unmarked_diagnos= tics =3D \ exclude_file_name_regexp--sc_po_check =3D ^(docs/|src/rpc/gendispatch\.pl$= $|tests/commandtest.c$$) =20 exclude_file_name_regexp--sc_prohibit_PATH_MAX =3D \ - ^build-aux/syntax-check\.mk$$ + ^(build-aux/syntax-check\.mk|tests/virfilemock.c)$$ =20 exclude_file_name_regexp--sc_prohibit_access_xok =3D \ ^(src/util/virutil\.c)$$ diff --git a/tests/virfilemock.c b/tests/virfilemock.c index 7c9174bdd9..bf153ab769 100644 --- a/tests/virfilemock.c +++ b/tests/virfilemock.c @@ -24,7 +24,6 @@ #if WITH_LINUX_MAGIC_H # include #endif -#include =20 #include "virmock.h" #include "virstring.h" @@ -186,15 +185,20 @@ realpath(const char *path, char *resolved) =20 if (getenv("LIBVIRT_MTAB")) { const char *p; - char *ret; =20 - assert(resolved =3D=3D NULL); - if ((p =3D STRSKIP(path, "/some/symlink"))) - ret =3D g_strdup_printf("/gluster%s", p); - else - ret =3D g_strdup(path); + if ((p =3D STRSKIP(path, "/some/symlink"))) { + if (resolved) + g_snprintf(resolved, PATH_MAX, "/gluster%s", p); + else + resolved =3D g_strdup_printf("/gluster%s", p); + } else { + if (resolved) + g_strlcpy(resolved, path, PATH_MAX); + else + resolved =3D g_strdup(path); + } =20 - return ret; + return resolved; } =20 return real_realpath(path, resolved); --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313862; cv=none; d=zohomail.com; s=zohoarc; b=kGzoFZe1WYq9WXNACJpKe1O4THQNshiGw1m6IzQ9TUnRRUUy5HDlkiCWPZxzg+lesAXJvzgFLlSJaBprksOK4RREYwN0ltl0lsRERqGVLLlNnYCCJNkyVODUX9plWlWWbjc2MxGwLkRh70oJYnP5gMIERmdRrVFHRU+3MWEZekM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313862; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uxjKQkFQvXEBROde4g0LOu28a7U0OLtFdLKzl6u8ZNI=; b=WPAKc517nof/YvMVQEv/8rs1aJoZ2AbWmXJ+IvUsCqq46m4yGGfc1Eoulc16oa1100fvkx3iOE5fhP9rapBCTSL1/fl+Zpkbhk+CZw70jTtdqLwm2mq0Le6Lowjmdh7rOCRFjaARaIFRpqge4VYCXgd03wJ3zbfuRJi1w0fik7Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620313862691960.0581511802216; Thu, 6 May 2021 08:11:02 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-lkUhR82VOF6tAYNqun1s5A-1; Thu, 06 May 2021 11:10:58 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0778B8015C6; Thu, 6 May 2021 15:10:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD84160657; Thu, 6 May 2021 15:10:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A4A3B5534E; Thu, 6 May 2021 15:10:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8ldv008318 for ; Thu, 6 May 2021 11:08:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 312BB189A5; Thu, 6 May 2021 15:08:47 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 766F060657; Thu, 6 May 2021 15:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uxjKQkFQvXEBROde4g0LOu28a7U0OLtFdLKzl6u8ZNI=; b=goKAawaMlCn2SgZXd45toP5omdiuygj90brHhHBZHBlr8ceAMySPSfjNeHd6fF6qLVGaNI HzlPEVOraZh4fnNkLZRqGtoC51BxfC+iFsDlPUq6ayjmlkTzRYZZzbx8B6Z9U4KWAQ3P2q wyTZuwlltCXPih9+Ufnxft1dCPNxeXY= X-MC-Unique: lkUhR82VOF6tAYNqun1s5A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 4/7] openvz: Add missing symbols to libvirt_openvz.syms Date: Thu, 6 May 2021 17:08:35 +0200 Message-Id: <20210506150838.30129-5-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik --- src/libvirt_openvz.syms | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirt_openvz.syms b/src/libvirt_openvz.syms index ac0ed0d23e..a1038e51a4 100644 --- a/src/libvirt_openvz.syms +++ b/src/libvirt_openvz.syms @@ -3,10 +3,12 @@ # =20 # openvz/openvz_conf.h +openvzCapsInit; openvzLocateConfFile; openvzReadConfigParam; openvzReadNetworkConf; openvzVEGetStringParam; +openvzXMLOption; =20 # Let emacs know we want case-insensitive sorting # Local Variables: --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313869; cv=none; d=zohomail.com; s=zohoarc; b=Cwk/sNPREB6cZ1LRLLSLMXplAH7V2Ybn7XFVTQvMD/h5JrlF9zsPwpx9j568ANDjVFqvbQIGf8zcx3bV1iNmw2abrM74+1XqPBuHTwV+FtaS8XDdZDrAn9Q/IPJG0WJinhtne1WSHOVbY0bpWumavgt5BxGBpmLEAUtDHXsISaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313869; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qBW4IyisTnMCjtCO3jOCqXpbY1aNbE366V1iIWOQL+Q=; b=U43czQROZtHZ9ynVgKh8npMnPx92Ue1TsKDGxGRSxp0cKAj8Xkuruqsl6LtIHUD9dapSkQ4Wch2oTJ0VzVzrPpBSrWCio0gvmJ5LmaVd+3RUbRLwZqqHVOx/d5iXatN8CErtrlkK6IsAyqSJG1vxXNtmIVQBA12JvYfY/LsWvY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620313869293321.7697314944513; Thu, 6 May 2021 08:11:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-q86szW2ZOkSSWI_WERPGSg-1; Thu, 06 May 2021 11:11:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A3F61006C86; Thu, 6 May 2021 15:10:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBE3316909; Thu, 6 May 2021 15:10:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B362B55355; Thu, 6 May 2021 15:10:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8mWb008330 for ; Thu, 6 May 2021 11:08:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3C77260657; Thu, 6 May 2021 15:08:48 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 819E9620DE; Thu, 6 May 2021 15:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313866; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qBW4IyisTnMCjtCO3jOCqXpbY1aNbE366V1iIWOQL+Q=; b=du7c9Q/7fEZQ9peJQltDZMWZv3F3RtepW8GfD6vxWB5qmb5BLsnKtXbjVovE4m2pWFEju9 qMfI6AioAawlrfsBeu3q95bMB0O2ky00Bbi5W/HWp35YxoAysPCWPcr4yS3jX9tqW5xO7O 97yRE71XQMrTkipjK453/fS784o/5Uo= X-MC-Unique: q86szW2ZOkSSWI_WERPGSg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 5/7] tests: openvzutilstest: Remove duplicate linking with libvirt_openvz.a Date: Thu, 6 May 2021 17:08:36 +0200 Message-Id: <20210506150838.30129-6-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" "openvzutilstest" links, amongst others, against "libvirt_openvz.a" and "libvirt.so". The latter also links against "libvirt_openvz.a", leading to a One-Definition-Rule violation for "openvzLocateConfFile" in "openvz_conf.c". Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik --- tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 9900983d0c..3c73cbe3b5 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -430,7 +430,7 @@ endif =20 if conf.has('WITH_OPENVZ') tests +=3D [ - { 'name': 'openvzutilstest', 'link_with': [ openvz_lib ] }, + { 'name': 'openvzutilstest' }, ] endif =20 --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313872; cv=none; d=zohomail.com; s=zohoarc; b=WdRvTuZ8UTocdZbAuJa+CR+GZ8pdlbrrBg2Ud8Mqr3CFwULLDSRbrSHVdNb4dTpkt7+0o42M+Ecj5m+5wj0kiYo2Ekc9Rh5fvfO+ECa23Qo/jCO38QDVOfwzYG/nLR6jRO8AO8bAk0gys5PergfY6VvaGTx50HPPa710HRu8ebY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BZ5uxca03fvDDUjr4eggr9RFnKXRCyH8rxqpQJRCN7w=; b=lTx4m4kfDj2nPNUXf+lALvISufUgqmxrwdFxrt2yc5gePJ2IiPfD4PW2uxSuGNKEOXK9MazTS7Ri0U4zZWyN/eOIzkU7zhe5ly26kBj9/ZFYrlSVtOmDdGXT0HL+jVkv/kOqyvobEZJkhp2fFyRhp9cOqEUZhDXPNQWYN21E9Ao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620313872588218.6990202954196; Thu, 6 May 2021 08:11:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-XoI-51iTPNCLbdmjNfq2RQ-1; Thu, 06 May 2021 11:11:07 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 190321006C80; Thu, 6 May 2021 15:10:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF17B19C9B; Thu, 6 May 2021 15:10:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B6D23180B463; Thu, 6 May 2021 15:10:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8nuF008335 for ; Thu, 6 May 2021 11:08:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 71B6B60657; Thu, 6 May 2021 15:08:49 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E305189A5; Thu, 6 May 2021 15:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BZ5uxca03fvDDUjr4eggr9RFnKXRCyH8rxqpQJRCN7w=; b=V7ocUviY1UY7ytTAQrX5Ddk9iMRhZ3AyJK3OT8P6AUmmB7YNm3qZgfqwmywsaIxo6t10u2 p2M2KQGOjaOu4L1n1CJABaOPlCn2ceHRcEaRFoNMbcfsyDcA1tnup356eTXKwunhjvFKL1 PbWGa1Ehbt8xMFZQhv0aZhk3Jp8TOjs= X-MC-Unique: XoI-51iTPNCLbdmjNfq2RQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 6/7] virt-aa-helper: Remove duplicate linking with src/datatypes.o Date: Thu, 6 May 2021 17:08:37 +0200 Message-Id: <20210506150838.30129-7-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Pavel Hrdina , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" "virt-aa-helper" links, amongst others, against "datatypes.o" and "libvirt.so". The latter links against "libvirt_driver.a" which in turn also links against "datatypes.o", leading to a One-Definition-Rule violoation for "virConnectClass" et al. in "datatypes.c". Signed-off-by: Tim Wiederhake Reviewed-by: Pavel Hrdina Reviewed-by: Michal Privoznik --- src/security/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/src/security/meson.build b/src/security/meson.build index 416fec7900..6f5e1dec1d 100644 --- a/src/security/meson.build +++ b/src/security/meson.build @@ -41,7 +41,6 @@ if conf.has('WITH_LIBVIRTD') and conf.has('WITH_APPARMOR') 'name': 'virt-aa-helper', 'sources': [ apparmor_helper_sources, - datatypes_sources, dtrace_gen_objects, ], 'include': [ --=20 2.26.3 From nobody Thu May 16 11:58:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620313872; cv=none; d=zohomail.com; s=zohoarc; b=FU8F0GGMycmYO4uCorNXJnBzJz3kGw0gd7Bpe3pLJvLtyRQvtW0IY+I2nhJ3l/avGnf16hMkYAkfgANRwxdf+oeJx6uw0xyKQlklf/15EvzRjF44f+JwMqLGjVYGNnem1Du0aJWI0051s5SMw58rt9rtA4U9PNPA8klopajYopo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620313872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XtIFzBx7R5PeKXlFxgJzGjcBNB1Nn7+guhs0LaBDGwM=; b=nmmyY3pVfQG6koYsZ6cok8BwcrxkbG31hnH1wvkDTC/xctPKjXRsqmNdnsfKpskbMFXSneWF5RveqTK/5QeEq9brlj4IgTpjdpw+9+Tjx9QEwiV00w+CNI2KbH47CXP1QemoY+sLJdNFR/BsSKeAbhdHva19XUlUhCJ7UQoLeuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162031387205294.94353060101616; Thu, 6 May 2021 08:11:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-PAWGOlqpO6mmqc19iI1BBA-1; Thu, 06 May 2021 11:11:07 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24F8E1898297; Thu, 6 May 2021 15:11:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3BB15C22B; Thu, 6 May 2021 15:11:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B586555356; Thu, 6 May 2021 15:11:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146F8oCX008353 for ; Thu, 6 May 2021 11:08:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E4DC189A5; Thu, 6 May 2021 15:08:50 +0000 (UTC) Received: from work.redhat.com (ovpn-113-21.ams2.redhat.com [10.36.113.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id C47F319C9B; Thu, 6 May 2021 15:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620313869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XtIFzBx7R5PeKXlFxgJzGjcBNB1Nn7+guhs0LaBDGwM=; b=bAYMFTAD2niIQJRnJMBfn+EAg3fumm1Upb5b0KWepVCLIJpbtqypHjSlNy/BPGjKyO8cGw JQ5Zn7XSqLG2M2GYXVdo2BRVVuLza17haKmQB6NfAXFg4YwgSfn0P/b4usM5GhCDJ8f0Cg 4rZINeKG8YnBPvO1sgFKDsoOQcAxLJY= X-MC-Unique: PAWGOlqpO6mmqc19iI1BBA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 7/7] ci: Enable address and undefined behavior sanitizers Date: Thu, 6 May 2021 17:08:38 +0200 Message-Id: <20210506150838.30129-8-twiederh@redhat.com> In-Reply-To: <20210506150838.30129-1-twiederh@redhat.com> References: <20210506150838.30129-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" meson supports the following sanitizers: "address" (e.g. out-of-bounds memory access, use-after-free, etc.), "thread" (data races), "undefined" (e.g. signed integer overflow), and "memory" (use of uninitialized memory). Note that not all sanitizers are supported by all compilers, and that more sanitizers exist. Not all sanitizers can be enabled at the same time, but "address" and "undefined" can. Both thread and memory sanitizers require an instrumented build of all dependencies, including libc. gcc and clang use different implementations of these sanitizers and have proven to find different issues. Create CI jobs for both. Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik --- .gitlab-ci.yml | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 89f618e678..4de4c30d7f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -73,6 +73,26 @@ stages: rpmbuild --nodeps -ta build/meson-dist/libvirt-*.tar.xz; fi =20 +.sanitizer_build_job: + stage: builds + image: $CI_REGISTRY_IMAGE/ci-ubuntu-2004:latest + needs: + - x64-ubuntu-2004-container + rules: + - if: "$TEMPORARILY_DISABLED" + allow_failure: true + - when: on_success + cache: + paths: + - ccache/ + key: "$CI_JOB_NAME" + before_script: + - *script_variables + script: + - meson build --werror -Db_lundef=3Dfalse -Db_sanitize=3D"$SANITIZER" + - ninja -C build; + - ninja -C build test; + # Jobs that we delegate to Cirrus CI because they require an operating # system other than Linux. These jobs will only run if the required # setup has been performed on the GitLab account (see ci/README.rst). @@ -521,6 +541,21 @@ mingw64-fedora-rawhide: NAME: fedora-rawhide CROSS: mingw64 =20 +# Sanitizers + +sanitize-gcc: + extends: .sanitizer_build_job + variables: + ASAN_OPTIONS: verify_asan_link_order=3D0 + CC: gcc + SANITIZER: address,undefined + +sanitize-clang: + extends: .sanitizer_build_job + variables: + CC: clang + SANITIZER: address,undefined + =20 # This artifact published by this job is downloaded by libvirt.org to # be deployed to the web root: --=20 2.26.3