Refactor more XML parsing boilerplate code, part II

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II

Tim Wiederhake posted 10 patches 3 years ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210421133332.59662-1-twiederh@redhat.com

src/conf/domain_conf.c | 246 +++++++++--------------------------------
1 file changed, 52 insertions(+), 194 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II

Posted by Tim Wiederhake 3 years ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainVirtioOptionsParseXML: Use virXMLProp*
  virDomainDeviceBootParseXML: Use virXMLProp*
  virDomainDeviceISAAddressParseXML: Use virXMLProp*
  virDomainDiskSourceNVMeParse: Use virXMLProp*
  virDomainChrSourceDefParseFile: Use virXMLProp*
  virDomainChrSourceDefParseLog: Use virXMLProp*
  virDomainAudioJackParse: Use virXMLProp*
  virDomainVideoResolutionDefParseXML: Use virXMLProp*
  virDomainVsockDefParseXML: Use virXMLProp*
  virDomainLoaderDefParseXML: Use virXMLProp*

 src/conf/domain_conf.c | 246 +++++++++--------------------------------
 1 file changed, 52 insertions(+), 194 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II

Posted by Peter Krempa 3 years ago

On Wed, Apr 21, 2021 at 15:33:22 +0200, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>   virDomainVirtioOptionsParseXML: Use virXMLProp*
>   virDomainDeviceBootParseXML: Use virXMLProp*
>   virDomainDeviceISAAddressParseXML: Use virXMLProp*
>   virDomainDiskSourceNVMeParse: Use virXMLProp*
>   virDomainChrSourceDefParseFile: Use virXMLProp*
>   virDomainChrSourceDefParseLog: Use virXMLProp*
>   virDomainAudioJackParse: Use virXMLProp*
>   virDomainVideoResolutionDefParseXML: Use virXMLProp*
>   virDomainVsockDefParseXML: Use virXMLProp*
>   virDomainLoaderDefParseXML: Use virXMLProp*

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

and will be pushed shortly.