[v2] Refactor more XML parsing boilerplate code

[libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code

Tim Wiederhake posted 10 patches 3 years ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210421120808.35786-1-twiederh@redhat.com

src/conf/backup_conf.c |  57 +++-------
src/conf/device_conf.c | 237 ++++++++++++-----------------------------
2 files changed, 80 insertions(+), 214 deletions(-)

Expand all Fold all

[libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code

Posted by Tim Wiederhake 3 years ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Changes since V1:
* Rebased
* s/VIR_XML_PROP_OPTIONAL/VIR_XML_PROP_NONE/
* Declare variables 1 / line
* Commented on strictening of parser in patch #10

Tim Wiederhake (10):
  virDomainBackupDiskDefParseXML: Use virXMLProp*
  virDomainBackupDefParse: Use virXMLProp*
  virZPCIDeviceAddressParseXML: Use virXMLProp*
  virPCIDeviceAddressParseXML: Use virXMLProp*
  virDomainDeviceCCWAddressParseXML: Use virXMLProp*
  virDomainDeviceDriveAddressParseXML: Use virXMLProp*
  virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*
  virDomainDeviceCcidAddressParseXML: Use virXMLProp*
  virDomainDeviceUSBAddressParseXML: Use virXMLProp*
  virInterfaceLinkParseXML: Use virXMLProp*

 src/conf/backup_conf.c |  57 +++-------
 src/conf/device_conf.c | 237 ++++++++++++-----------------------------
 2 files changed, 80 insertions(+), 214 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code

Posted by Peter Krempa 3 years ago

On Wed, Apr 21, 2021 at 14:07:58 +0200, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Changes since V1:
> * Rebased
> * s/VIR_XML_PROP_OPTIONAL/VIR_XML_PROP_NONE/
> * Declare variables 1 / line
> * Commented on strictening of parser in patch #10
> 
> Tim Wiederhake (10):
>   virDomainBackupDiskDefParseXML: Use virXMLProp*
>   virDomainBackupDefParse: Use virXMLProp*
>   virZPCIDeviceAddressParseXML: Use virXMLProp*
>   virPCIDeviceAddressParseXML: Use virXMLProp*
>   virDomainDeviceCCWAddressParseXML: Use virXMLProp*
>   virDomainDeviceDriveAddressParseXML: Use virXMLProp*
>   virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*
>   virDomainDeviceCcidAddressParseXML: Use virXMLProp*
>   virDomainDeviceUSBAddressParseXML: Use virXMLProp*
>   virInterfaceLinkParseXML: Use virXMLProp*

Pushed now.