[libvirt PATCH v4 0/7] spec: Reorganize some packages

Andrea Bolognani posted 7 patches 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210420171322.544322-1-abologna@redhat.com
docs/kbase/rpm-deployment.rst         | 55 ++++---------------
libvirt.spec.in                       | 76 ++++++++++-----------------
tools/bash-completion/meson.build     | 24 +++++----
tools/bash-completion/{vsh => vsh.in} |  7 ++-
4 files changed, 54 insertions(+), 108 deletions(-)
rename tools/bash-completion/{vsh => vsh.in} (91%)
[libvirt PATCH v4 0/7] spec: Reorganize some packages
Posted by Andrea Bolognani 3 years ago
Changes from [v3]:

  * generate per-command bash completion scripts using Meson instead
    of tweaking the contents after the fact for RPM build;

  * update documentation as files are moved around and packages are
    dropped.

Changes from [v2]:

  * move virt-admin to -daemon rather than -client;

  * move other host-only tools from -client to -daemon;

  * move systemtap probes from -client to -libs.

Changes from [v1]:

  * add Obsoletes/Provides for a smooth transition.

[v3] https://listman.redhat.com/archives/libvir-list/2021-April/msg00900.html
[v2] https://listman.redhat.com/archives/libvir-list/2021-April/msg00613.html
[v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html

Andrea Bolognani (7):
  docs: Use consistent vertical spacing
  docs: Expand upon the contents of the -daemon package
  spec: Merge -admin package into -daemon
  spec: Move some files from -client to -daemon
  spec: Move systemtap probes from -client to -libs
  tools: Generate per-command bash completion script
  spec: Drop -bash-completion package

 docs/kbase/rpm-deployment.rst         | 55 ++++---------------
 libvirt.spec.in                       | 76 ++++++++++-----------------
 tools/bash-completion/meson.build     | 24 +++++----
 tools/bash-completion/{vsh => vsh.in} |  7 ++-
 4 files changed, 54 insertions(+), 108 deletions(-)
 rename tools/bash-completion/{vsh => vsh.in} (91%)

-- 
2.26.3


Re: [libvirt PATCH v4 0/7] spec: Reorganize some packages
Posted by Neal Gompa 3 years ago
On Tue, Apr 20, 2021 at 1:13 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> Changes from [v3]:
>
>   * generate per-command bash completion scripts using Meson instead
>     of tweaking the contents after the fact for RPM build;
>
>   * update documentation as files are moved around and packages are
>     dropped.
>
> Changes from [v2]:
>
>   * move virt-admin to -daemon rather than -client;
>
>   * move other host-only tools from -client to -daemon;
>
>   * move systemtap probes from -client to -libs.
>
> Changes from [v1]:
>
>   * add Obsoletes/Provides for a smooth transition.
>
> [v3] https://listman.redhat.com/archives/libvir-list/2021-April/msg00900.html
> [v2] https://listman.redhat.com/archives/libvir-list/2021-April/msg00613.html
> [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html
>
> Andrea Bolognani (7):
>   docs: Use consistent vertical spacing
>   docs: Expand upon the contents of the -daemon package
>   spec: Merge -admin package into -daemon
>   spec: Move some files from -client to -daemon
>   spec: Move systemtap probes from -client to -libs
>   tools: Generate per-command bash completion script
>   spec: Drop -bash-completion package
>
>  docs/kbase/rpm-deployment.rst         | 55 ++++---------------
>  libvirt.spec.in                       | 76 ++++++++++-----------------
>  tools/bash-completion/meson.build     | 24 +++++----
>  tools/bash-completion/{vsh => vsh.in} |  7 ++-
>  4 files changed, 54 insertions(+), 108 deletions(-)
>  rename tools/bash-completion/{vsh => vsh.in} (91%)
>
> --
> 2.26.3
>
>

Series LGTM.

Reviewed-by: Neal Gompa <ngompa13@gmail.com>


-- 
真実はいつも一つ!/ Always, there's only one truth!


Re: [libvirt PATCH v4 0/7] spec: Reorganize some packages
Posted by Michal Privoznik 3 years ago
On 4/20/21 7:13 PM, Andrea Bolognani wrote:
> Changes from [v3]:
> 
>    * generate per-command bash completion scripts using Meson instead
>      of tweaking the contents after the fact for RPM build;
> 
>    * update documentation as files are moved around and packages are
>      dropped.
> 
> Changes from [v2]:
> 
>    * move virt-admin to -daemon rather than -client;
> 
>    * move other host-only tools from -client to -daemon;
> 
>    * move systemtap probes from -client to -libs.
> 
> Changes from [v1]:
> 
>    * add Obsoletes/Provides for a smooth transition.
> 
> [v3] https://listman.redhat.com/archives/libvir-list/2021-April/msg00900.html
> [v2] https://listman.redhat.com/archives/libvir-list/2021-April/msg00613.html
> [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html
> 
> Andrea Bolognani (7):
>    docs: Use consistent vertical spacing
>    docs: Expand upon the contents of the -daemon package
>    spec: Merge -admin package into -daemon
>    spec: Move some files from -client to -daemon
>    spec: Move systemtap probes from -client to -libs
>    tools: Generate per-command bash completion script
>    spec: Drop -bash-completion package
> 
>   docs/kbase/rpm-deployment.rst         | 55 ++++---------------
>   libvirt.spec.in                       | 76 ++++++++++-----------------
>   tools/bash-completion/meson.build     | 24 +++++----
>   tools/bash-completion/{vsh => vsh.in} |  7 ++-
>   4 files changed, 54 insertions(+), 108 deletions(-)
>   rename tools/bash-completion/{vsh => vsh.in} (91%)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal