[libvirt PATCH 0/2] Fix some typos and spelling mistakes

Tim Wiederhake posted 2 patches 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210414101453.52893-1-twiederh@redhat.com
There is a newer version of this series
NEWS.rst                           | 12 ++++++------
docs/formatdomain.rst              |  6 +++---
docs/glib-adoption.rst             |  2 +-
docs/kbase/launch_security_sev.rst |  2 +-
docs/manpages/virtproxyd.rst       |  2 +-
docs/pci-addresses.rst             |  2 +-
src/hyperv/hyperv_wmi.c            |  2 +-
src/libvirt-domain.c               |  2 +-
src/libxl/libxl_logger.c           |  2 +-
src/qemu/qemu_capabilities.c       |  2 +-
src/qemu/qemu_command.c            |  2 +-
src/qemu/qemu_domain.c             |  4 ++--
src/qemu/qemu_domain.h             |  4 ++--
src/qemu/qemu_interface.c          |  2 +-
src/qemu/qemu_snapshot.c           |  4 ++--
src/util/virerror.c                |  3 ++-
src/util/virhash.c                 |  2 +-
src/util/virlog.c                  |  2 +-
src/util/virnetdev.c               |  2 +-
src/util/virpci.c                  |  2 +-
src/util/virpci.h                  |  2 +-
tests/meson.build                  |  2 +-
tools/meson.build                  |  2 +-
23 files changed, 34 insertions(+), 33 deletions(-)
[libvirt PATCH 0/2] Fix some typos and spelling mistakes
Posted by Tim Wiederhake 3 years ago
Found by codespell [1].

It would be nice to automate this, but I could not get codespell to
also check code comments, and ran into a known issue [2] with codespell
that prevents putting some terms with mixed letter cases on the skip list.

[1] https://github.com/codespell-project/codespell
[2] https://github.com/codespell-project/codespell/issues/1860

Tim Wiederhake (2):
  Fix spelling
  virlog: Remove stray "todo" in comment

 NEWS.rst                           | 12 ++++++------
 docs/formatdomain.rst              |  6 +++---
 docs/glib-adoption.rst             |  2 +-
 docs/kbase/launch_security_sev.rst |  2 +-
 docs/manpages/virtproxyd.rst       |  2 +-
 docs/pci-addresses.rst             |  2 +-
 src/hyperv/hyperv_wmi.c            |  2 +-
 src/libvirt-domain.c               |  2 +-
 src/libxl/libxl_logger.c           |  2 +-
 src/qemu/qemu_capabilities.c       |  2 +-
 src/qemu/qemu_command.c            |  2 +-
 src/qemu/qemu_domain.c             |  4 ++--
 src/qemu/qemu_domain.h             |  4 ++--
 src/qemu/qemu_interface.c          |  2 +-
 src/qemu/qemu_snapshot.c           |  4 ++--
 src/util/virerror.c                |  3 ++-
 src/util/virhash.c                 |  2 +-
 src/util/virlog.c                  |  2 +-
 src/util/virnetdev.c               |  2 +-
 src/util/virpci.c                  |  2 +-
 src/util/virpci.h                  |  2 +-
 tests/meson.build                  |  2 +-
 tools/meson.build                  |  2 +-
 23 files changed, 34 insertions(+), 33 deletions(-)

-- 
2.26.2


Re: [libvirt PATCH 0/2] Fix some typos and spelling mistakes
Posted by Ján Tomko 3 years ago
On a Wednesday in 2021, Tim Wiederhake wrote:
>Found by codespell [1].
>
>It would be nice to automate this, but I could not get codespell to
>also check code comments,

You can automate the spellchecking, but sometimes typos are included in
sentences that should be rewritten completely - you cannot (yet?)
automatically check for that.

Also, checking comments outside of public APIs is not that important - the
code will usually be harder to read than the comment with a typo.

>and ran into a known issue [2] with codespell
>that prevents putting some terms with mixed letter cases on the skip list.
>

With false positives and no way to silence the warnings, I'm afraid the
automation would not be useful.

Jano

>[1] https://github.com/codespell-project/codespell
>[2] https://github.com/codespell-project/codespell/issues/1860
>
>Tim Wiederhake (2):
>  Fix spelling
>  virlog: Remove stray "todo" in comment
>