[PATCH] virsh: Remove any reference of KVM device assignment

Michal Privoznik posted 1 patch 2 years ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/201d014ac43e6e193c7fcbe21f0949df73ca0bc6.1649148123.git.mprivozn@redhat.com
docs/manpages/virsh.rst | 7 +++----
tools/virsh-nodedev.c   | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
[PATCH] virsh: Remove any reference of KVM device assignment
Posted by Michal Privoznik 2 years ago
The KVM device assignment was removed in v5.7.0-rc1~103 but virsh
and its manpage still mention it. Don't do that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 docs/manpages/virsh.rst | 7 +++----
 tools/virsh-nodedev.c   | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index d2e6528533..215beabd96 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -5198,10 +5198,9 @@ guests via <hostdev> passthrough.  This is reversed with
 ``nodedev-reattach``, and is done automatically for managed devices.
 
 Different backend drivers expect the device to be bound to different
-dummy devices. For example, QEMU's "kvm" backend driver (the default)
-expects the device to be bound to pci-stub, but its "vfio" backend
-driver expects the device to be bound to vfio-pci. The *--driver*
-parameter can be used to specify the desired backend driver.
+dummy devices. For example, QEMU's "vfio" backend driver expects the
+device to be bound to vfio-pci. The *--driver* parameter can be used
+to specify the desired backend driver.
 
 
 nodedev-dumpxml
diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c
index d21b2baab6..90066249af 100644
--- a/tools/virsh-nodedev.c
+++ b/tools/virsh-nodedev.c
@@ -615,7 +615,7 @@ static const vshCmdOptDef opts_node_device_detach[] = {
     {.name = "driver",
      .type = VSH_OT_STRING,
      .completer = virshNodeDevicePCIBackendCompleter,
-     .help = N_("pci device assignment backend driver (e.g. 'vfio' or 'kvm')")
+     .help = N_("pci device assignment backend driver (e.g. 'vfio' or 'xen')")
     },
     {.name = NULL}
 };
-- 
2.35.1
Re: [PATCH] virsh: Remove any reference of KVM device assignment
Posted by Andrea Bolognani 2 years ago
On Tue, Apr 05, 2022 at 10:42:03AM +0200, Michal Privoznik wrote:
> The KVM device assignment was removed in v5.7.0-rc1~103 but virsh
> and its manpage still mention it. Don't do that.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  docs/manpages/virsh.rst | 7 +++----
>  tools/virsh-nodedev.c   | 2 +-
>  2 files changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization