[libvirt] [PATCH v2 0/8] virStr*cpy*() related fixes and cleanups

Andrea Bolognani posted 8 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180720144413.28226-1-abologna@redhat.com
Test syntax-check passed
docs/hacking.html.in                      | 29 +++++-----
src/conf/capabilities.c                   |  2 +-
src/conf/netdev_vport_profile_conf.c      |  2 +-
src/conf/nwfilter_conf.c                  |  3 +-
src/esx/esx_driver.c                      |  8 +--
src/esx/esx_vi.c                          |  6 +-
src/esx/esx_vi_types.c                    |  2 +-
src/hyperv/hyperv_driver.c                |  3 +-
src/libxl/libxl_conf.c                    |  2 +-
src/locking/lock_driver_sanlock.c         | 25 ++++----
src/lxc/lxc_driver.c                      |  8 +--
src/nwfilter/nwfilter_dhcpsnoop.c         |  2 +-
src/nwfilter/nwfilter_ebiptables_driver.c |  6 +-
src/nwfilter/nwfilter_learnipaddr.c       |  2 +-
src/openvz/openvz_conf.c                  |  8 +--
src/qemu/qemu_agent.c                     |  2 +-
src/qemu/qemu_command.c                   |  2 +-
src/qemu/qemu_monitor.c                   |  2 +-
src/remote/remote_daemon_dispatch.c       |  4 +-
src/remote/remote_driver.c                |  4 +-
src/rpc/virnetlibsshsession.c             |  4 +-
src/rpc/virnetsocket.c                    |  4 +-
src/security/security_apparmor.c          |  2 +-
src/security/virt-aa-helper.c             |  2 +-
src/test/test_driver.c                    |  4 +-
src/uml/uml_driver.c                      |  4 +-
src/util/virfdstream.c                    |  4 +-
src/util/virhostcpu.c                     |  4 +-
src/util/virhostmem.c                     |  6 +-
src/util/virlog.c                         |  5 +-
src/util/virnetdev.c                      | 12 ++--
src/util/virnetdevbridge.c                |  6 +-
src/util/virnetdevtap.c                   |  4 +-
src/util/virnetdevvportprofile.c          |  6 +-
src/util/virstring.c                      | 70 +++++++++++++++--------
src/util/virstring.h                      |  4 +-
src/util/virtypedparam.c                  |  8 +--
src/xenapi/xenapi_driver.c                |  4 +-
src/xenconfig/xen_common.c                | 38 ++++++------
src/xenconfig/xen_sxpr.c                  |  2 +-
src/xenconfig/xen_xl.c                    | 41 ++++++-------
src/xenconfig/xen_xm.c                    |  2 +-
42 files changed, 179 insertions(+), 179 deletions(-)
[libvirt] [PATCH v2 0/8] virStr*cpy*() related fixes and cleanups
Posted by Andrea Bolognani 5 years, 9 months ago
Changes from [v1]:

  * catch a bunch more suboptimal uses of the original API;

  * improve the API so that it's both more sensible and fits
    better with the rest of libvirt.

[v1] https://www.redhat.com/archives/libvir-list/2018-July/msg01044.html

Andrea Bolognani (8):
  src: Use virStrcpyStatic() to avoid truncation
  src: Use virStrcpyStatic() wherever possible
  src: Use VIR_STRDUP() wherever possible
  src: Use virStrcpy() wherever possible
  src: Don't rely on strncpy()-like behavior
  src: Make virStr*cpy*() functions return an int
  esx: Use memcpy() in esxVI_CURL_Debug()
  util: Improve virStrncpy() implementation

 docs/hacking.html.in                      | 29 +++++-----
 src/conf/capabilities.c                   |  2 +-
 src/conf/netdev_vport_profile_conf.c      |  2 +-
 src/conf/nwfilter_conf.c                  |  3 +-
 src/esx/esx_driver.c                      |  8 +--
 src/esx/esx_vi.c                          |  6 +-
 src/esx/esx_vi_types.c                    |  2 +-
 src/hyperv/hyperv_driver.c                |  3 +-
 src/libxl/libxl_conf.c                    |  2 +-
 src/locking/lock_driver_sanlock.c         | 25 ++++----
 src/lxc/lxc_driver.c                      |  8 +--
 src/nwfilter/nwfilter_dhcpsnoop.c         |  2 +-
 src/nwfilter/nwfilter_ebiptables_driver.c |  6 +-
 src/nwfilter/nwfilter_learnipaddr.c       |  2 +-
 src/openvz/openvz_conf.c                  |  8 +--
 src/qemu/qemu_agent.c                     |  2 +-
 src/qemu/qemu_command.c                   |  2 +-
 src/qemu/qemu_monitor.c                   |  2 +-
 src/remote/remote_daemon_dispatch.c       |  4 +-
 src/remote/remote_driver.c                |  4 +-
 src/rpc/virnetlibsshsession.c             |  4 +-
 src/rpc/virnetsocket.c                    |  4 +-
 src/security/security_apparmor.c          |  2 +-
 src/security/virt-aa-helper.c             |  2 +-
 src/test/test_driver.c                    |  4 +-
 src/uml/uml_driver.c                      |  4 +-
 src/util/virfdstream.c                    |  4 +-
 src/util/virhostcpu.c                     |  4 +-
 src/util/virhostmem.c                     |  6 +-
 src/util/virlog.c                         |  5 +-
 src/util/virnetdev.c                      | 12 ++--
 src/util/virnetdevbridge.c                |  6 +-
 src/util/virnetdevtap.c                   |  4 +-
 src/util/virnetdevvportprofile.c          |  6 +-
 src/util/virstring.c                      | 70 +++++++++++++++--------
 src/util/virstring.h                      |  4 +-
 src/util/virtypedparam.c                  |  8 +--
 src/xenapi/xenapi_driver.c                |  4 +-
 src/xenconfig/xen_common.c                | 38 ++++++------
 src/xenconfig/xen_sxpr.c                  |  2 +-
 src/xenconfig/xen_xl.c                    | 41 ++++++-------
 src/xenconfig/xen_xm.c                    |  2 +-
 42 files changed, 179 insertions(+), 179 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/8] virStr*cpy*() related fixes and cleanups
Posted by Michal Prívozník 5 years, 8 months ago
On 07/20/2018 04:44 PM, Andrea Bolognani wrote:
> Changes from [v1]:
> 
>   * catch a bunch more suboptimal uses of the original API;
> 
>   * improve the API so that it's both more sensible and fits
>     better with the rest of libvirt.
> 
> [v1] https://www.redhat.com/archives/libvir-list/2018-July/msg01044.html
> 
> Andrea Bolognani (8):
>   src: Use virStrcpyStatic() to avoid truncation
>   src: Use virStrcpyStatic() wherever possible
>   src: Use VIR_STRDUP() wherever possible
>   src: Use virStrcpy() wherever possible
>   src: Don't rely on strncpy()-like behavior
>   src: Make virStr*cpy*() functions return an int
>   esx: Use memcpy() in esxVI_CURL_Debug()
>   util: Improve virStrncpy() implementation
> 
>  docs/hacking.html.in                      | 29 +++++-----
>  src/conf/capabilities.c                   |  2 +-
>  src/conf/netdev_vport_profile_conf.c      |  2 +-
>  src/conf/nwfilter_conf.c                  |  3 +-
>  src/esx/esx_driver.c                      |  8 +--
>  src/esx/esx_vi.c                          |  6 +-
>  src/esx/esx_vi_types.c                    |  2 +-
>  src/hyperv/hyperv_driver.c                |  3 +-
>  src/libxl/libxl_conf.c                    |  2 +-
>  src/locking/lock_driver_sanlock.c         | 25 ++++----
>  src/lxc/lxc_driver.c                      |  8 +--
>  src/nwfilter/nwfilter_dhcpsnoop.c         |  2 +-
>  src/nwfilter/nwfilter_ebiptables_driver.c |  6 +-
>  src/nwfilter/nwfilter_learnipaddr.c       |  2 +-
>  src/openvz/openvz_conf.c                  |  8 +--
>  src/qemu/qemu_agent.c                     |  2 +-
>  src/qemu/qemu_command.c                   |  2 +-
>  src/qemu/qemu_monitor.c                   |  2 +-
>  src/remote/remote_daemon_dispatch.c       |  4 +-
>  src/remote/remote_driver.c                |  4 +-
>  src/rpc/virnetlibsshsession.c             |  4 +-
>  src/rpc/virnetsocket.c                    |  4 +-
>  src/security/security_apparmor.c          |  2 +-
>  src/security/virt-aa-helper.c             |  2 +-
>  src/test/test_driver.c                    |  4 +-
>  src/uml/uml_driver.c                      |  4 +-
>  src/util/virfdstream.c                    |  4 +-
>  src/util/virhostcpu.c                     |  4 +-
>  src/util/virhostmem.c                     |  6 +-
>  src/util/virlog.c                         |  5 +-
>  src/util/virnetdev.c                      | 12 ++--
>  src/util/virnetdevbridge.c                |  6 +-
>  src/util/virnetdevtap.c                   |  4 +-
>  src/util/virnetdevvportprofile.c          |  6 +-
>  src/util/virstring.c                      | 70 +++++++++++++++--------
>  src/util/virstring.h                      |  4 +-
>  src/util/virtypedparam.c                  |  8 +--
>  src/xenapi/xenapi_driver.c                |  4 +-
>  src/xenconfig/xen_common.c                | 38 ++++++------
>  src/xenconfig/xen_sxpr.c                  |  2 +-
>  src/xenconfig/xen_xl.c                    | 41 ++++++-------
>  src/xenconfig/xen_xm.c                    |  2 +-
>  42 files changed, 179 insertions(+), 179 deletions(-)
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list