[libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL

Daniel P. Berrangé posted 2 patches 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180720105529.13545-1-berrange@redhat.com
Test syntax-check passed
libvirt.spec.in | 246 ++++--------------------------------------------
1 file changed, 20 insertions(+), 226 deletions(-)
[libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL
Posted by Daniel P. Berrangé 5 years, 8 months ago
Drop conditionals for RHEL-6 and assume systemd is present

Daniel P. Berrangé (2):
  rpm: increase min required RHEL to 7
  rpm: remove conditionals for systemd

 libvirt.spec.in | 246 ++++--------------------------------------------
 1 file changed, 20 insertions(+), 226 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL
Posted by Fabiano Fidêncio 5 years, 8 months ago
On Fri, Jul 20, 2018 at 12:55 PM, Daniel P. Berrangé
<berrange@redhat.com> wrote:
> Drop conditionals for RHEL-6 and assume systemd is present
>
> Daniel P. Berrangé (2):
>   rpm: increase min required RHEL to 7
>   rpm: remove conditionals for systemd

While you're on this wouldn't worth to also bump the minimum fedora
version from 26 to 27 as f26 reached its EOL?

>
>  libvirt.spec.in | 246 ++++--------------------------------------------
>  1 file changed, 20 insertions(+), 226 deletions(-)
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


Best Regards,
-- 
Fabiano Fidêncio

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL
Posted by Andrea Bolognani 5 years, 8 months ago
On Fri, 2018-07-20 at 11:55 +0100, Daniel P. Berrangé wrote:
> Drop conditionals for RHEL-6 and assume systemd is present
> 
> Daniel P. Berrangé (2):
>   rpm: increase min required RHEL to 7
>   rpm: remove conditionals for systemd
> 
>  libvirt.spec.in | 246 ++++--------------------------------------------
>  1 file changed, 20 insertions(+), 226 deletions(-)

Love it!

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

And now either you or Fabiano can bump min_fedora as he suggested :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list