tools: Fix typo generating adapter_wwpn field

[libvirt] [PATCH] tools: Fix typo generating adapter_wwpn field

John Ferlan posted 1 patch 5 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180719180344.13492-1-jferlan@redhat.com

Test syntax-check passed

tools/virsh-pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] tools: Fix typo generating adapter_wwpn field

Posted by John Ferlan 5 years, 9 months ago

https://bugzilla.redhat.com/show_bug.cgi?id=1601377

Fix typo from commit id d45bee449 for the parent_wwpn field
resulting in parent_wwnn being printed twice.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 tools/virsh-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index cc49a5b96d..6faff781b2 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -371,7 +371,7 @@ virshBuildPoolXML(vshControl *ctl,
             if (adapterParent)
                 virBufferAsprintf(&buf, " parent='%s'", adapterParent);
             else if (adapterParentWwnn && adapterParentWwpn)
-                virBufferAsprintf(&buf, " parent_wwnn='%s' parent_wwnn='%s'",
+                virBufferAsprintf(&buf, " parent_wwnn='%s' parent_wwpn='%s'",
                                   adapterParentWwnn, adapterParentWwpn);
             else if (adapterParentFabricWwn)
                 virBufferAsprintf(&buf, " parent_fabric_wwn='%s'",
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tools: Fix typo generating adapter_wwpn field

Posted by Erik Skultety 5 years, 9 months ago

On Thu, Jul 19, 2018 at 02:03:44PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1601377
>
> Fix typo from commit id d45bee449 for the parent_wwpn field
> resulting in parent_wwnn being printed twice.
>
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com> (trivial)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list