On Tue, Jul 17, 2018 at 06:35:16PM +0200, Andrea Bolognani wrote:
> pylint is reasonably happy with the script now:
>
> $ pylint lcitool
> No config file found, using default configuration
> ************* Module lcitool
> C: 1, 0: Missing module docstring (missing-docstring)
> C: 37, 0: Missing class docstring (missing-docstring)
> C: 47, 4: Missing method docstring (missing-docstring)
> W:108,15: Catching too general exception Exception (broad-except)
> R:427, 4: Too many branches (14/12) (too-many-branches)
> R:289, 0: Too few public methods (1/2) (too-few-public-methods)
>
> -------------------------------------------------------------------
> Your code has been rated at 9.21/10 (previous run: 9.21/10, +0.00)
>
> The remaining issues are not considered blockers and will be
> addressed, if at all, later down the line.
>
> Changes from [v2]:
>
> * address review comments;
> * improve pycodestyle and pylint compliance;
> * replace FSF address with an URL.
>
> Changes from [v1]:
>
> * add Dockerfile generator;
> * rename the 'list' action to 'hosts' to better fit along with
> the additional 'projects' action;
> * always list items in alphabetical order;
> * move some generic functions to an Util class.
>
> [v2] https://www.redhat.com/archives/libvir-list/2018-July/msg00795.html
> [v1] https://www.redhat.com/archives/libvir-list/2018-July/msg00717.html
>
> Andrea Bolognani (12):
> lcitool: Drop shell implementation
> lcitool: Stub out Python implementation
> lcitool: Add tool configuration handling
> lcitool: Add inventory handling
> lcitool: Implement the 'hosts' action
> lcitool: Implement the 'install' action
> lcitool: Implement the 'update' action
> guests: Update documentation
> guests: Add Docker-related information to the inventory
> lcitool: Add projects information handling
> lcitool: Implement the 'projects' action
> lcitool: Implement the 'dockerfile' action
>
> guests/README.markdown | 8 +-
> guests/host_vars/libvirt-centos-7/docker.yml | 2 +
> guests/host_vars/libvirt-debian-8/docker.yml | 2 +
> guests/host_vars/libvirt-debian-9/docker.yml | 2 +
> .../host_vars/libvirt-debian-sid/docker.yml | 2 +
> guests/host_vars/libvirt-fedora-27/docker.yml | 2 +
> guests/host_vars/libvirt-fedora-28/docker.yml | 2 +
> .../libvirt-fedora-rawhide/docker.yml | 2 +
> guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 +
> guests/host_vars/libvirt-ubuntu-18/docker.yml | 2 +
> guests/lcitool | 730 ++++++++++++------
> 11 files changed, 529 insertions(+), 227 deletions(-)
> create mode 100644 guests/host_vars/libvirt-centos-7/docker.yml
> create mode 100644 guests/host_vars/libvirt-debian-8/docker.yml
> create mode 100644 guests/host_vars/libvirt-debian-9/docker.yml
> create mode 100644 guests/host_vars/libvirt-debian-sid/docker.yml
> create mode 100644 guests/host_vars/libvirt-fedora-27/docker.yml
> create mode 100644 guests/host_vars/libvirt-fedora-28/docker.yml
> create mode 100644 guests/host_vars/libvirt-fedora-rawhide/docker.yml
> create mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml
> create mode 100644 guests/host_vars/libvirt-ubuntu-18/docker.yml
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
For all patches in this series.
Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list