From nobody Sun Apr 28 19:52:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531739252246756.0111737522068; Mon, 16 Jul 2018 04:07:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EDE2356D2; Mon, 16 Jul 2018 11:07:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05D28600C9; Mon, 16 Jul 2018 11:07:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 88C724BB78; Mon, 16 Jul 2018 11:07:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6GB6CoK004667 for ; Mon, 16 Jul 2018 07:06:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9ACC3111E40F; Mon, 16 Jul 2018 11:06:12 +0000 (UTC) Received: from inaba.usersys.redhat.com (ovpn-204-249.brq.redhat.com [10.40.204.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0367F111E40D for ; Mon, 16 Jul 2018 11:06:09 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 16 Jul 2018 13:06:06 +0200 Message-Id: <20180716110606.5707-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] util: Drop virArgvToString() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 16 Jul 2018 11:07:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The last use has been removed in 026ae4933c6a. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- src/libvirt_private.syms | 1 - src/util/virstring.c | 27 --------------------------- src/util/virstring.h | 2 -- 3 files changed, 30 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e688981c3e..1caecb96b6 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2876,7 +2876,6 @@ virStorageFileBackendRegister; =20 =20 # util/virstring.h -virArgvToString; virAsprintfInternal; virSkipSpaces; virSkipSpacesAndBackslash; diff --git a/src/util/virstring.c b/src/util/virstring.c index 15f367af7c..31e71d7535 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -917,33 +917,6 @@ virStringIsEmpty(const char *str) return str[0] =3D=3D '\0'; } =20 -char * -virArgvToString(const char *const *argv) -{ - int len; - size_t i; - char *ret, *p; - - for (len =3D 1, i =3D 0; argv[i]; i++) - len +=3D strlen(argv[i]) + 1; - - if (VIR_ALLOC_N(ret, len) < 0) - return NULL; - p =3D ret; - - for (i =3D 0; argv[i]; i++) { - if (i !=3D 0) - *(p++) =3D ' '; - - strcpy(p, argv[i]); - p +=3D strlen(argv[i]); - } - - *p =3D '\0'; - - return ret; -} - /** * virStrdup: * @dest: where to store duplicated string diff --git a/src/util/virstring.h b/src/util/virstring.h index 726e02b98c..14948fdf1c 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -65,8 +65,6 @@ char *virStringListGetFirstWithPrefix(char **strings, const char *prefix) ATTRIBUTE_NONNULL(2); =20 -char *virArgvToString(const char *const *argv); - int virStrToLong_i(char const *s, char **end_ptr, int base, --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list