[libvirt] [PATCH] util: Drop virArgvToString()

Andrea Bolognani posted 1 patch 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180716110606.5707-1-abologna@redhat.com
Test syntax-check passed
src/libvirt_private.syms |  1 -
src/util/virstring.c     | 27 ---------------------------
src/util/virstring.h     |  2 --
3 files changed, 30 deletions(-)
[libvirt] [PATCH] util: Drop virArgvToString()
Posted by Andrea Bolognani 5 years, 8 months ago
The last use has been removed in 026ae4933c6a.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/libvirt_private.syms |  1 -
 src/util/virstring.c     | 27 ---------------------------
 src/util/virstring.h     |  2 --
 3 files changed, 30 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index e688981c3e..1caecb96b6 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -2876,7 +2876,6 @@ virStorageFileBackendRegister;
 
 
 # util/virstring.h
-virArgvToString;
 virAsprintfInternal;
 virSkipSpaces;
 virSkipSpacesAndBackslash;
diff --git a/src/util/virstring.c b/src/util/virstring.c
index 15f367af7c..31e71d7535 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -917,33 +917,6 @@ virStringIsEmpty(const char *str)
     return str[0] == '\0';
 }
 
-char *
-virArgvToString(const char *const *argv)
-{
-    int len;
-    size_t i;
-    char *ret, *p;
-
-    for (len = 1, i = 0; argv[i]; i++)
-        len += strlen(argv[i]) + 1;
-
-    if (VIR_ALLOC_N(ret, len) < 0)
-        return NULL;
-    p = ret;
-
-    for (i = 0; argv[i]; i++) {
-        if (i != 0)
-            *(p++) = ' ';
-
-        strcpy(p, argv[i]);
-        p += strlen(argv[i]);
-    }
-
-    *p = '\0';
-
-    return ret;
-}
-
 /**
  * virStrdup:
  * @dest: where to store duplicated string
diff --git a/src/util/virstring.h b/src/util/virstring.h
index 726e02b98c..14948fdf1c 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -65,8 +65,6 @@ char *virStringListGetFirstWithPrefix(char **strings,
                                       const char *prefix)
     ATTRIBUTE_NONNULL(2);
 
-char *virArgvToString(const char *const *argv);
-
 int virStrToLong_i(char const *s,
                    char **end_ptr,
                    int base,
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] util: Drop virArgvToString()
Posted by Peter Krempa 5 years, 8 months ago
On Mon, Jul 16, 2018 at 13:06:06 +0200, Andrea Bolognani wrote:
> The last use has been removed in 026ae4933c6a.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/libvirt_private.syms |  1 -
>  src/util/virstring.c     | 27 ---------------------------
>  src/util/virstring.h     |  2 --
>  3 files changed, 30 deletions(-)

ACK, trivial.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] util: Drop virArgvToString()
Posted by Ján Tomko 5 years, 8 months ago
On Mon, Jul 16, 2018 at 01:06:06PM +0200, Andrea Bolognani wrote:
>The last use has been removed in 026ae4933c6a.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/libvirt_private.syms |  1 -
> src/util/virstring.c     | 27 ---------------------------
> src/util/virstring.h     |  2 --
> 3 files changed, 30 deletions(-)
>

Beautiful diffstat.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list