[libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh

Han Han posted 2 patches 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180715100817.31003-1-hhan@redhat.com
Test syntax-check failed
tools/virsh-domain.c | 30 ++++++++++++++++++++++++++++--
tools/virsh.pod      |  7 +++++--
2 files changed, 33 insertions(+), 4 deletions(-)
[libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh
Posted by Han Han 5 years, 8 months ago
Fix make syntax-check failure in v1.
v1 link: https://www.redhat.com/archives/libvir-list/2018-July/msg00929.html

Han Han (2):
  virsh: Support alias in attach-disk
  virsh: Support alias in attach-interface

 tools/virsh-domain.c | 30 ++++++++++++++++++++++++++++--
 tools/virsh.pod      |  7 +++++--
 2 files changed, 33 insertions(+), 4 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh
Posted by Michal Prívozník 5 years, 8 months ago
On 07/15/2018 12:08 PM, Han Han wrote:
> Fix make syntax-check failure in v1.
> v1 link: https://www.redhat.com/archives/libvir-list/2018-July/msg00929.html
> 
> Han Han (2):
>   virsh: Support alias in attach-disk
>   virsh: Support alias in attach-interface
> 
>  tools/virsh-domain.c | 30 ++++++++++++++++++++++++++++--
>  tools/virsh.pod      |  7 +++++--
>  2 files changed, 33 insertions(+), 4 deletions(-)
> 

I'm fixing all the issues I've found, ACKing and pushing.

Might be worth providing news.xml entry though. Can you post a patch for
that please?

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh
Posted by Han Han 5 years, 8 months ago
On Mon, Jul 23, 2018 at 6:21 PM, Michal Prívozník <mprivozn@redhat.com>
wrote:

> On 07/15/2018 12:08 PM, Han Han wrote:
> > Fix make syntax-check failure in v1.
> > v1 link: https://www.redhat.com/archives/libvir-list/2018-
> July/msg00929.html
> >
> > Han Han (2):
> >   virsh: Support alias in attach-disk
> >   virsh: Support alias in attach-interface
> >
> >  tools/virsh-domain.c | 30 ++++++++++++++++++++++++++++--
> >  tools/virsh.pod      |  7 +++++--
> >  2 files changed, 33 insertions(+), 4 deletions(-)
> >
>
> I'm fixing all the issues I've found, ACKing and pushing.
>
> Might be worth providing news.xml entry though. Can you post a patch for
> that please?
>
Sure. The news patch link:
https://www.redhat.com/archives/libvir-list/2018-July/msg01516.html

>
> Michal
>



-- 
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan@redhat.com
Phone: +861065339333
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list