From nobody Fri Apr 26 13:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153393153506.0080119274145; Mon, 9 Jul 2018 09:23:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9553D3082140; Mon, 9 Jul 2018 16:23:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5ABDA19485; Mon, 9 Jul 2018 16:23:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 01A16245FD; Mon, 9 Jul 2018 16:23:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GMwos020178 for ; Mon, 9 Jul 2018 12:22:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id D5EE720155E3; Mon, 9 Jul 2018 16:22:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDF9A20155E2 for ; Mon, 9 Jul 2018 16:22:56 +0000 (UTC) Received: from mail-qk0-f182.google.com (mail-qk0-f182.google.com [209.85.220.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6741C308403A for ; Mon, 9 Jul 2018 16:22:45 +0000 (UTC) Received: by mail-qk0-f182.google.com with SMTP id b66-v6so9999329qkj.1 for ; Mon, 09 Jul 2018 09:22:45 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qB/fNDwnGLb6qs+0dG/GBNBuVcqdV7Iu/QDDPgIvNms=; b=pp+D7hrVrFc3sCGH3UAy7oFbbzKc8bmm2CLNhxKR0M+QF5pcs/TwgaEEnZUknhjYZE p5MbST/bTqcKEt6ysMjFiIB2b1fcfMYh2x56eGWqOfvn+V636K/VHbQvj7iBSOcFYokV 71vp4fzD7SyECwUPsFK+2kcS8FCvhb7sIhQhhJ7ZJtIt7XotZ03FaFRqjOfxhCYEFVLp pXYRhmwia+cZgey9fDfM4W0/v+YvOifcAqbpN6g5TNPS4qQwRe5ODlGlpfTytL4zMVJv SCDsNFvQw4QoCRXvmUJsae21Q8OG4zYOj3Xos/lNyeFZQiUfaZwezL92X5IaStTRK9MK mFIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qB/fNDwnGLb6qs+0dG/GBNBuVcqdV7Iu/QDDPgIvNms=; b=QGZAxIEd+2p4oD/U/Fn3B1PNp9Wdiqtdmoowoj1ti3BC8qHGvWXmTf6VyvDGgFv3wM fxc0GKRak6qhlIz/9PBXWvWKtiBMnG68vX48GlOlJOlZrGj+nJQrIjtRzW5gfYCNM7c2 EX8qTtSCqsRI9rkcPZuQgcmCSvwxLHMply/9Hol+kJRvrj3bIHg3VUPhlb/s3BnFaSFw cCgOy3N9ygLn+JlA1+8b39LsfqMaB+fcV9FdXeblysZNhQhLPM61ORCvUFkwK3LM89AS V28gjXiybILvjGJl8Eh/wOophu/FJUudLuQFmYK6NhDTs5u0BkusyzYu4heoDh//R9k6 CVLA== X-Gm-Message-State: APt69E3NA6MPHVLR3OvA9DYyDupXzfPC3Ep+hnnW75sIdYgqHbjkMKRm bWzujSAD/7ky6JFr6rm4YS3pLA== X-Google-Smtp-Source: AAOMgpcpQwMWUpvgf1gGgmjXXplNDYsZSuiDYBFb/41HBIoZjqsaEBp9rVZRbOCiVvxHYRZacb1u7g== X-Received: by 2002:a37:8103:: with SMTP id c3-v6mr18365671qkd.246.1531153364179; Mon, 09 Jul 2018 09:22:44 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:19 -0300 Message-Id: <20180709162223.5239-2-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 09 Jul 2018 16:22:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 09 Jul 2018 16:22:45 +0000 (UTC) for IP:'209.85.220.182' DOMAIN:'mail-qk0-f182.google.com' HELO:'mail-qk0-f182.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.301 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, SPF_PASS, T_DKIM_INVALID) 209.85.220.182 mail-qk0-f182.google.com 209.85.220.182 mail-qk0-f182.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.40 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 1/5] driver.h: Add remoteOnly member to virConnectDriver struct X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 09 Jul 2018 16:23:12 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This new flag will be set when a driver needs a remote URL in order to work, as ESX, HyperV and Phyp. Signed-off-by: Marcos Paulo de Souza --- src/driver.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/driver.h b/src/driver.h index 0b1f7a2269..c4d94ba294 100644 --- a/src/driver.h +++ b/src/driver.h @@ -81,6 +81,8 @@ typedef virConnectDriver *virConnectDriverPtr; struct _virConnectDriver { /* Wether driver permits a server in the URI */ bool localOnly; + /* Wether driver needs a server in the URI */ + bool remoteOnly; /* * NULL terminated list of supported URI schemes. * - Single element { NULL } list indicates no supported schemes --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 13:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153383555697.2534420206027; Mon, 9 Jul 2018 09:23:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F3A3C0587F8; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 576AE100190E; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB34824601; Mon, 9 Jul 2018 16:23:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GMw8V020173 for ; Mon, 9 Jul 2018 12:22:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD7C91001918; Mon, 9 Jul 2018 16:22:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B61E0100190E for ; Mon, 9 Jul 2018 16:22:58 +0000 (UTC) Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFCDD307D86B for ; Mon, 9 Jul 2018 16:22:47 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id t79-v6so9985071qke.4 for ; Mon, 09 Jul 2018 09:22:47 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hZ0P8M/OBzth6wkr6SwKNOn+yZuqdMH5ZH3EyhBx1EY=; b=T3kYoY0d8KxXU/WX7zL61urUzZ3eSTwCmcVwV52atZLkzNYS3En6QgABUVsNs6Vwl1 x3vT5ubuZu/CIYfpAEx18L+yUDL6BU9KnovZLEBEi1OYtGGuPqyKcLx9s5wme8kHDcFk M3plDRNrBTx/cUug6f5SkbZ8++ixPyiM2go72OzWKMBpGvNC3m+kvxGcucABInU+ECX6 wQB4LSzEznOg19LjV01XjznPjXTbuoUzbKB8ltBN56Iq5U1xhXj8TE6x6Kguf5rm7Eix 0CmhL3X00CgSZ7fS/2Ewiu26qvoJNdV3Zt/BrAMDFpRg2tOAJSVzGB2mtMso2K1fGlRS AHRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hZ0P8M/OBzth6wkr6SwKNOn+yZuqdMH5ZH3EyhBx1EY=; b=M9f9d2sz103OfBmETJ9SCckH0Qdy6WKnzNgCOuL54R0uKuKTos1vCf+Zruzf065jGN aFMgWSTEjH4A5gG9VbeRXSWnM5N213VbNqXwIUEmJgRGOvO8M8haFA1jbKqxz5RxEqC1 6mI+We/UaabnzbQnRzz6PL7+kivUVYODJYykUYOkiO15oKQP0nmbOnKz0RzLTUUipKHB wfKhypEnot8ARvEphqpb9gTvMA+3IVaX8scZja29FgWs0ccGEHhmz6lkr2RaCyxkR4r4 6xhPySWeWwsMF+A05VAh8xgoBKJJWouYIbdjaUrAjeONxIX+OAo9Kv7SLA88WoULDYuq riXg== X-Gm-Message-State: APt69E1jc7zgoyzOxZ6hp1Yg1Uhr2IzUuaI4PgWrdNdSSAlT+u86YO/d xxVcx63MmglpVgpVQlTMM+bJiQ== X-Google-Smtp-Source: AAOMgpeUpJI0I5q6/CBIVn1CHX9Y1sPS0HZ0s4BzfZFpzzkVVxjXWHlMmKnA+P3ZNjpqtCPw7iyz5w== X-Received: by 2002:a37:d1cc:: with SMTP id o73-v6mr17816354qkl.293.1531153366800; Mon, 09 Jul 2018 09:22:46 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:20 -0300 Message-Id: <20180709162223.5239-3-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 09 Jul 2018 16:22:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 09 Jul 2018 16:22:48 +0000 (UTC) for IP:'209.85.220.193' DOMAIN:'mail-qk0-f193.google.com' HELO:'mail-qk0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.193 mail-qk0-f193.google.com 209.85.220.193 mail-qk0-f193.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 2/5] libvirt.c: Return error when remoteOnly is set but server is empty X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 09 Jul 2018 16:23:02 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Some drivers require a server in order to work, so this flag removes the burden of esach driver to check for an server by doing it in virConnectOpenInternal. Signed-off-by: Marcos Paulo de Souza --- src/libvirt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 52f4dd2808..9ae4e774eb 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1005,6 +1005,11 @@ virConnectOpenInternal(const char *name, continue; } =20 + if (virConnectDriverTab[i]->remoteOnly && ret->uri && !ret->uri->s= erver) { + virReportError(VIR_ERR_INVALID_ARG, "%s", _("URI is missing th= e server part")); + goto failed; + } + /* Filter drivers based on declared URI schemes */ if (virConnectDriverTab[i]->uriSchemes) { bool matchScheme =3D false; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 13:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153395736172.68886008203845; Mon, 9 Jul 2018 09:23:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4845E804EB; Mon, 9 Jul 2018 16:23:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F358B60F93; Mon, 9 Jul 2018 16:23:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 912A01800541; Mon, 9 Jul 2018 16:23:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GN14s020193 for ; Mon, 9 Jul 2018 12:23:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8D7E4308BDAE; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83CB2308BDAD for ; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5E7D3082A47 for ; Mon, 9 Jul 2018 16:22:50 +0000 (UTC) Received: by mail-qk0-f194.google.com with SMTP id o2-v6so9978926qkc.13 for ; Mon, 09 Jul 2018 09:22:50 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hdCriKHXbp97DMPVwqCK2WZwu7y0atrvybYehX2uOg8=; b=afve3co7Gi7AchHBXNYFEozStQ22El9lP0iLLX7BplSisgdE1NgtA7naS42MliwLmV FwSdEZje14vsmP9Ixn7NJUlYgrbBm2VoIv+ECcgiSXIDPO1ZZWlhwyP5vO82CQnYI2uJ q7F/atqfmzDyeGIAxFE7DTPStE2kqZK2B9lvreLV3tNiDbn+jQVrKK7ScSpfZOL9Of62 pauc8NIit2N+A/FRhEvbq56Ha+q9UBtkrZX0QutR4adLwm07CHYCj9Ud/9LIREhL4PRt KRPv7TZarVR8GE+ttpLUldfeANBN7wPS4fpuPg8eGVgEXAf5fxP5shFvSbQhcOUIoLI+ K62Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hdCriKHXbp97DMPVwqCK2WZwu7y0atrvybYehX2uOg8=; b=npaad+cRBKz6RvEA2deEZG/iVsg//SzDKEDs8e5CO6PeJOj+poXs1SuGJIbJRASGgX iRa2FC+luj8rU1RHNQ1xlhIB9rWDrnkPnfJmriIkRnNVeLBuFTRvXhjXfOJyH6/erGWe +eIoAyZgPryK5zbnIdBlPP+ta1fxDWrWTojQR+8aWSrWPucyLT9qY0gNzgVRW1/7FDrO esj7R6BbR7Fuu/aaEWpRD0rldac5Rs+Gl4YtHGWVXSPJRxkh64kCm5rOGM6Y4h3vbOlN joB2cf8alOpP8qfAb6a9V8XdiAlfgEuh58DVLmGQs9+lIwTkX7Pu5jXK5b+sfttWgQNe wK6g== X-Gm-Message-State: APt69E3IjKHZ0Lshx2dE9gmHQSCoo5XzOkzs1MCMJTtmkfO+qqn3gpjN lww79Pw70Cw30We7PL4tTPjd4A== X-Google-Smtp-Source: AAOMgpdEOVVR0P/VZUcVRzAOgTsp0IYbubSaFS6+dWc/dqRVf2WOWYjXp+/cg2OAd+E1ziPpOcNbxg== X-Received: by 2002:a37:d197:: with SMTP id o23-v6mr18638701qkl.210.1531153369560; Mon, 09 Jul 2018 09:22:49 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:21 -0300 Message-Id: <20180709162223.5239-4-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 09 Jul 2018 16:22:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 09 Jul 2018 16:22:50 +0000 (UTC) for IP:'209.85.220.194' DOMAIN:'mail-qk0-f194.google.com' HELO:'mail-qk0-f194.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.194 mail-qk0-f194.google.com 209.85.220.194 mail-qk0-f194.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 3/5] esx_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 09 Jul 2018 16:23:15 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" ESX driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_driver.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 06e1238385..d937daac83 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -854,13 +854,6 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr a= uth, conn->uri->path, conn->uri->scheme); } =20 - /* Require server part */ - if (!conn->uri->server) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("URI is missing the server part")); - return VIR_DRV_OPEN_ERROR; - } - /* Require auth */ if (!auth || !auth->cb) { virReportError(VIR_ERR_INVALID_ARG, "%s", @@ -5218,6 +5211,7 @@ static virConnectDriver esxConnectDriver =3D { .interfaceDriver =3D &esxInterfaceDriver, .networkDriver =3D &esxNetworkDriver, .storageDriver =3D &esxStorageDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 13:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153402817676.0169937686554; Mon, 9 Jul 2018 09:23:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AFE23084037; Mon, 9 Jul 2018 16:23:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD06718E50; Mon, 9 Jul 2018 16:23:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5CDD81800B68; Mon, 9 Jul 2018 16:23:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GN573020203 for ; Mon, 9 Jul 2018 12:23:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8567D17CF4; Mon, 9 Jul 2018 16:23:05 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A2CE60928 for ; Mon, 9 Jul 2018 16:23:04 +0000 (UTC) Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4091368E7 for ; Mon, 9 Jul 2018 16:22:53 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id c5-v6so15843566qth.5 for ; Mon, 09 Jul 2018 09:22:53 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C2QWd9DEv7R44hgJsFy+GkqC5R3v40WkhCOd3s1RWis=; b=mZ7w8F0ANp/UPUwyWRDz/qGcbACXuLjmolmg1jVmOUVsqcbcG02hYYHKyxn7SYcj2H QnctHbEz5CjpZQcSbhlipj7v1ppS8chEykUaGZcpLhIRmxL8/++EbWKNGm1xcDnu/9VR pjaOBTdY5PWyttmJg8yfyRPczwZyTjBj5O5RSZlqwHYKD1NFjSXj8eb2n2ofQ1msXYAs kNmMkFqNsnQLQ48q/EW7ONCFe1t40MCTsd8V06pmg76FLoXmYV0B59YVbpc1ceDwPT5R iKYSgm/sAFBEw7QHlVrL897lHOESeArE7PtUQAorZEjeNOtCi7O+Am7/YUv6l7ERZmxA Wd8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C2QWd9DEv7R44hgJsFy+GkqC5R3v40WkhCOd3s1RWis=; b=s+oKoVUgvR8XvpazzVQpOD6pyoCjUL/Xf8zUDRFjtcZ5ATWfM5rTTP3ebP7gsI2tW7 joXJcD76BGXLqKc0srUbHCw+k9eRXc2XIYNOwdcuA0BZJpsyCmPVf/7XqxhBwPvzZ3YN 8Eo8a6Tyv9pANCkjO5iDqcgZEjq7rAst9u/y6U5keVwc4WilKlMDbB3YpQTHbNol2MI3 lRAT4CBg8hkmNRm6/5HlStT/Ps3fP7ZVj4kDTm+XeZcTUQsTzOEHq8PaVCNst7ab1Cip SJfZLz2fB5I3caaO0Qd1OMff3dDx2C/4kheKC+J3hVP8DPeWFPYmuKVvk0jm9Oc6PVAW /Rhg== X-Gm-Message-State: APt69E0stnARlARD4pvMB0n1S94ttf8Oi7egXmeqle4lSo4a6OzfXjBL JIoDRRjP0aCGKR6YjFlhyjwlfA== X-Google-Smtp-Source: AAOMgpfp7/ZW5w0RHf92i3CLw0tZKjOI6hgxKgxIPYRpsGpix0Y2gqESxuFzgzBiVzK+6USf+GZkjw== X-Received: by 2002:ac8:29a4:: with SMTP id 33-v6mr20298037qts.354.1531153372390; Mon, 09 Jul 2018 09:22:52 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:22 -0300 Message-Id: <20180709162223.5239-5-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 Jul 2018 16:22:54 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 Jul 2018 16:22:54 +0000 (UTC) for IP:'209.85.216.193' DOMAIN:'mail-qt0-f193.google.com' HELO:'mail-qt0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.193 mail-qt0-f193.google.com 209.85.216.193 mail-qt0-f193.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 4/5] hyperv_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 09 Jul 2018 16:23:21 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" HyperV driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/hyperv/hyperv_driver.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 95496bdf73..8bda334cf9 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -128,13 +128,6 @@ hypervConnectOpen(virConnectPtr conn, virConnectAuthPt= r auth, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - /* Require server part */ - if (conn->uri->server =3D=3D NULL) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("URI is missing the server part")); - return VIR_DRV_OPEN_ERROR; - } - /* Require auth */ if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { virReportError(VIR_ERR_INVALID_ARG, "%s", @@ -1664,6 +1657,7 @@ hypervDebugHandler(const char *message, debug_level_e= level, static virConnectDriver hypervConnectDriver =3D { .uriSchemes =3D (const char *[]){ "hyperv", NULL }, .hypervisorDriver =3D &hypervHypervisorDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 13:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153401551213.14187251602016; Mon, 9 Jul 2018 09:23:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06772356CA; Mon, 9 Jul 2018 16:23:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCBF9100191C; Mon, 9 Jul 2018 16:23:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 68F794BB78; Mon, 9 Jul 2018 16:23:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GNApC020214 for ; Mon, 9 Jul 2018 12:23:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8347A18529; Mon, 9 Jul 2018 16:23:10 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B3672A2C4 for ; Mon, 9 Jul 2018 16:23:07 +0000 (UTC) Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8C0544E4CB for ; Mon, 9 Jul 2018 16:22:56 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id f1-v6so15849701qti.3 for ; Mon, 09 Jul 2018 09:22:56 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1OcYfDKeqQFR2DKDXc518NAEyUxqxOMuGW+7sdp5N8U=; b=LURDq8TxswPyk/sBvqDAJj/bWyn8rXhLquwR5wtbIOq6bClRl6QasGrypn1EmPmjD/ qaO5TfyNJFoc3UF4zLegI4uSj8W4XVHwGPn74wgToQS/1zWFjLLB/VdQZx/X4N9FSIln tqTyTYJLYwESzD1C4AJE6xH/sLoJRroEAwkV1RaWLzxuCTArBbpD5Bg+jMEsBQZGr47r 6gY+sVPWvuLWC9RgVZREYri/O88Nf/+uT2DHMRHv7dAUovzWMQ4pYHP2sDkRNANq1qW9 /ql67MeO1bPXYGU5X9fiGU7AfPdsqxyC4gLcfgHAW9rNZFnghXG/wHvighKnYdFAP2kz UFGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1OcYfDKeqQFR2DKDXc518NAEyUxqxOMuGW+7sdp5N8U=; b=XznfCGxcjj1m0pypAtqR/WossYoFOYzAt23wYkCNelZ6KgFBuu7wYMiCuZ2+sKKziE dx5JGntasl5VqG64R1zDdl246h3rRWebYEZIMCdhxKiHa33d2kSRILdFSJ8GMGLyRpPq HM7xmUIHn13FI3ASUw2SYR1tamd9O32Dk4ODA/2GG/OpRNmrsQfLnGuXpseshVlQeLxX 1XKFZBr1GhHP6O+M+TWmUXO5izMPkY1QeG9zd4ltirR2/PUXYEiIOPp+Uau+QAE27Ks6 ptfkZpT2kAiJWjeHBd2SylJLQU7yhtFyB76SJ5q4UnvK1Xt3N5WV4tk5NZNVLlMoVk11 C6AA== X-Gm-Message-State: APt69E29PxfXtSBVDMHIeNS6bEsp8MoX4XQ2UhOkR/hTlgZpGtu0Ffv9 PuBODxojndGtyKY/fv6YHwzeVQ== X-Google-Smtp-Source: AAOMgpfOv9Dnpt2OJn1RqpTgWxiajXbgMfJHMaWE0WWaz/ry6mijBS3JdkV+yPoM0pO0VBLQWgW0iA== X-Received: by 2002:a0c:8a1b:: with SMTP id 27-v6mr18364357qvt.159.1531153375285; Mon, 09 Jul 2018 09:22:55 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:23 -0300 Message-Id: <20180709162223.5239-6-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 09 Jul 2018 16:22:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 09 Jul 2018 16:22:56 +0000 (UTC) for IP:'209.85.216.193' DOMAIN:'mail-qt0-f193.google.com' HELO:'mail-qt0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.193 mail-qt0-f193.google.com 209.85.216.193 mail-qt0-f193.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 5/5] phyp_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 Jul 2018 16:23:20 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Phyp driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/phyp/phyp_driver.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 67ce7903ba..303a7151b7 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1141,12 +1141,6 @@ phypConnectOpen(virConnectPtr conn, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - if (conn->uri->server =3D=3D NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Missing server name in phyp:// URI")); - return VIR_DRV_OPEN_ERROR; - } - if (VIR_ALLOC(phyp_driver) < 0) goto failure; =20 @@ -3764,6 +3758,7 @@ static virConnectDriver phypConnectDriver =3D { .hypervisorDriver =3D &phypHypervisorDriver, .interfaceDriver =3D &phypInterfaceDriver, .storageDriver =3D &phypStorageDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list