From nobody Sat May 4 04:06:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1529579114004642.9698497307809; Thu, 21 Jun 2018 04:05:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C25E48762F; Thu, 21 Jun 2018 11:05:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81A425FC36; Thu, 21 Jun 2018 11:05:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A3A71800539; Thu, 21 Jun 2018 11:05:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB568F010612 for ; Thu, 21 Jun 2018 07:05:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id D327B1117639; Thu, 21 Jun 2018 11:05:06 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77C441117638 for ; Thu, 21 Jun 2018 11:05:06 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:55 +0200 Message-Id: <20180621110459.27511-2-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 1/5] tests: Include xmldata.py in EXTRA_DIST X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 21 Jun 2018 11:05:12 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This fixes distcheck. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index e841627..3872d7b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,4 +1,5 @@ test_helpers =3D \ + xmldata.py \ libvirttest.py \ conftest.py =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 04:06:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1529579113352160.35301034604913; Thu, 21 Jun 2018 04:05:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B580781DEB; Thu, 21 Jun 2018 11:05:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76D82100190D; Thu, 21 Jun 2018 11:05:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 487991800531; Thu, 21 Jun 2018 11:05:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB570m010620 for ; Thu, 21 Jun 2018 07:05:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 74B291117639; Thu, 21 Jun 2018 11:05:07 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19A231117638 for ; Thu, 21 Jun 2018 11:05:06 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:56 +0200 Message-Id: <20180621110459.27511-3-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 2/5] run: Fix VIRT_DBUS_INTERFACES_DIR X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 21 Jun 2018 11:05:12 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The D-Bus interface files are in the source directory, not in the build directory. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- run.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/run.in b/run.in index e98edaf..03e7c64 100644 --- a/run.in +++ b/run.in @@ -14,9 +14,6 @@ # ./run gdb --args ./src/libvirt-dbus [args ...] # =20 -# Find this script -b=3D@abs_top_builddir@ - -export VIRT_DBUS_INTERFACES_DIR=3D"$b/data" +export VIRT_DBUS_INTERFACES_DIR=3D"@abs_top_srcdir@/data" =20 exec "$@" --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 04:06:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15295791240741016.0067413308219; Thu, 21 Jun 2018 04:05:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0FDA4E915; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54422798C6; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CDD614A469; Thu, 21 Jun 2018 11:05:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB58mM010627 for ; Thu, 21 Jun 2018 07:05:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1615F1117638; Thu, 21 Jun 2018 11:05:08 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEEA3111763A for ; Thu, 21 Jun 2018 11:05:07 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:57 +0200 Message-Id: <20180621110459.27511-4-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 3/5] run: Export abs_top_builddir X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 21 Jun 2018 11:05:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The test suite uses this environment variable, if it's present, to locate the libvirt-dbus binary. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- run.in | 1 + 1 file changed, 1 insertion(+) diff --git a/run.in b/run.in index 03e7c64..0744a80 100644 --- a/run.in +++ b/run.in @@ -14,6 +14,7 @@ # ./run gdb --args ./src/libvirt-dbus [args ...] # =20 +export abs_top_builddir=3D"@abs_top_builddir@" export VIRT_DBUS_INTERFACES_DIR=3D"@abs_top_srcdir@/data" =20 exec "$@" --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 04:06:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1529579123937838.8155919992747; Thu, 21 Jun 2018 04:05:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DCBD3082A37; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 53B5F68898; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CD6844A465; Thu, 21 Jun 2018 11:05:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB583U010632 for ; Thu, 21 Jun 2018 07:05:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id ABD291117638; Thu, 21 Jun 2018 11:05:08 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50A831117639 for ; Thu, 21 Jun 2018 11:05:08 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:58 +0200 Message-Id: <20180621110459.27511-5-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 4/5] tests: Drop fallback path for abs_top_builddir X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 21 Jun 2018 11:05:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We have made sure all callers set up the environment correctly, so it's pointless to have a fallback path now. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- tests/libvirttest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libvirttest.py b/tests/libvirttest.py index 06e52c0..3741abd 100644 --- a/tests/libvirttest.py +++ b/tests/libvirttest.py @@ -10,7 +10,7 @@ import time import xmldata =20 =20 -root =3D os.environ.get('abs_top_builddir', os.path.dirname(os.path.dirnam= e(__file__))) +root =3D os.environ.get('abs_top_builddir') exe =3D os.path.join(root, 'src', 'libvirt-dbus') =20 DBusGMainLoop(set_as_default=3DTrue) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 04:06:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1529579124083892.1040088498164; Thu, 21 Jun 2018 04:05:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E18C281DE6; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91F3B70133; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5C1C4A46C; Thu, 21 Jun 2018 11:05:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB59MH010640 for ; Thu, 21 Jun 2018 07:05:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4DC821117638; Thu, 21 Jun 2018 11:05:09 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E66A61117639 for ; Thu, 21 Jun 2018 11:05:08 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:59 +0200 Message-Id: <20180621110459.27511-6-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 5/5] tests: Use AM_TESTS_ENVIRONMENT X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 21 Jun 2018 11:05:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" According to the documentation[1], TESTS_ENVIRONMENT is reserved for the user, which means we shouldn't be using it. AM_TESTS_ENVIRONMENT needs to be terminated with a semicolon, which in turn requires exporting the variables instead of merely declaring them, so do both of those things; since we're rewriting the whole hunk anyway, we also take the opportunity use proper quoting. [1] https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbase= d-Testsuites.html Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- tests/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3872d7b..1fc240b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -37,6 +37,6 @@ EXTRA_DIST =3D \ =20 TESTS =3D $(test_programs) =20 -TESTS_ENVIRONMENT =3D \ - abs_top_builddir=3D$(abs_top_builddir) \ - VIRT_DBUS_INTERFACES_DIR=3D$(abs_top_srcdir)/data +AM_TESTS_ENVIRONMENT =3D \ + export abs_top_builddir=3D"$(abs_top_builddir)"; \ + export VIRT_DBUS_INTERFACES_DIR=3D"$(abs_top_srcdir)/data"; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list