[libvirt] [PATCH 0/5] Fix a couple of force snapshot revert issues

John Ferlan posted 5 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180619225419.32039-1-jferlan@redhat.com
Test syntax-check passed
src/qemu/qemu_domain.c |  3 ++-
src/qemu/qemu_driver.c | 22 +++++++++++++++-------
2 files changed, 17 insertions(+), 8 deletions(-)
[libvirt] [PATCH 0/5] Fix a couple of force snapshot revert issues
Posted by John Ferlan 5 years, 9 months ago
Well, at least I hope so. There's a couple of related bz's in
the last two patches with gobs more details, but the long and
short of it is that when using the force flag, the domain is
Stop'd and re-Start'd without applying any snapshot. For both
issues I've seen, the "error: internal error: unexpected async
job 6" occurs on the Start and thus the CPU's aren't started.
For one bz, when running managedsave the call never returns.
For the other bz, one cannot restart the paused domain.

If there's a better way to do this - I'm sure someone will
let me know.

John Ferlan (5):
  qemu: Adjust async job failure message
  qemu: Promote start_flags in qemuDomainRevertToSnapshot
  qemu: Use start_flags for RUNNING and PAUSED transitions
  qemu: Unset the genid start change flag for revert force
  qemu: Don't use asyncJob after stop during snapshot revert

 src/qemu/qemu_domain.c |  3 ++-
 src/qemu/qemu_driver.c | 22 +++++++++++++++-------
 2 files changed, 17 insertions(+), 8 deletions(-)

-- 
2.14.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Fix a couple of force snapshot revert issues
Posted by Michal Privoznik 5 years, 9 months ago
On 06/20/2018 12:54 AM, John Ferlan wrote:
> Well, at least I hope so. There's a couple of related bz's in
> the last two patches with gobs more details, but the long and
> short of it is that when using the force flag, the domain is
> Stop'd and re-Start'd without applying any snapshot. For both
> issues I've seen, the "error: internal error: unexpected async
> job 6" occurs on the Start and thus the CPU's aren't started.
> For one bz, when running managedsave the call never returns.
> For the other bz, one cannot restart the paused domain.
> 
> If there's a better way to do this - I'm sure someone will
> let me know.
> 
> John Ferlan (5):
>   qemu: Adjust async job failure message
>   qemu: Promote start_flags in qemuDomainRevertToSnapshot
>   qemu: Use start_flags for RUNNING and PAUSED transitions
>   qemu: Unset the genid start change flag for revert force
>   qemu: Don't use asyncJob after stop during snapshot revert
> 
>  src/qemu/qemu_domain.c |  3 ++-
>  src/qemu/qemu_driver.c | 22 +++++++++++++++-------
>  2 files changed, 17 insertions(+), 8 deletions(-)
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list