[libvirt] [dbus PATCH] maint: fix coding style

Katerina Koukiou posted 1 patch 5 years, 10 months ago
Failed in applying to current master (apply log)
src/connect.c | 12 ++++++------
src/domain.c  |  2 +-
src/events.c  | 24 ++++++++++++------------
src/network.c |  2 +-
src/util.c    |  6 +++---
src/util.h    |  4 ++--
6 files changed, 25 insertions(+), 25 deletions(-)
[libvirt] [dbus PATCH] maint: fix coding style
Posted by Katerina Koukiou 5 years, 10 months ago
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/connect.c | 12 ++++++------
 src/domain.c  |  2 +-
 src/events.c  | 24 ++++++++++++------------
 src/network.c |  2 +-
 src/util.c    |  6 +++---
 src/util.h    |  4 ++--
 6 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/src/connect.c b/src/connect.c
index 2e57d69..09e5628 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -1187,12 +1187,12 @@ virtDBusConnectNWFilterDefineXML(GVariant *inArgs,
 
 static void
 virtDBusConnectNWFilterLookupByName(GVariant *inArgs,
-                                   GUnixFDList *inFDs G_GNUC_UNUSED,
-                                   const gchar *objectPath G_GNUC_UNUSED,
-                                   gpointer userData,
-                                   GVariant **outArgs,
-                                   GUnixFDList **outFDs G_GNUC_UNUSED,
-                                   GError **error)
+                                    GUnixFDList *inFDs G_GNUC_UNUSED,
+                                    const gchar *objectPath G_GNUC_UNUSED,
+                                    gpointer userData,
+                                    GVariant **outArgs,
+                                    GUnixFDList **outFDs G_GNUC_UNUSED,
+                                    GError **error)
 {
     virtDBusConnect *connect = userData;
     g_autoptr(virNWFilter) nwfilter = NULL;
diff --git a/src/domain.c b/src/domain.c
index 4aeb855..5c5e6da 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -2189,7 +2189,7 @@ virtDBusDomainMigrateToURI3(GVariant *inArgs,
     virtDBusConnect *connect = userData;
     g_autoptr(virDomain) domain = NULL;
     g_autoptr(GVariantIter) iter = NULL;
-    const gchar* dconuri;
+    const gchar *dconuri;
     g_auto(virtDBusUtilTypedParams) params = { 0 };
     guint flags;
 
diff --git a/src/events.c b/src/events.c
index 7cdc71d..e635a61 100644
--- a/src/events.c
+++ b/src/events.c
@@ -546,10 +546,10 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection G_GNUC_UNUSED,
 
 static gint
 virtDBusEventsNetworkEvent(virConnectPtr connection G_GNUC_UNUSED,
-                               virNetworkPtr network,
-                               gint event,
-                               gint detail G_GNUC_UNUSED,
-                               gpointer opaque)
+                           virNetworkPtr network,
+                           gint event,
+                           gint detail G_GNUC_UNUSED,
+                           gpointer opaque)
 {
     virtDBusConnect *connect = opaque;
     g_autofree gchar *path = NULL;
@@ -592,10 +592,10 @@ virtDBusEventsNodeDeviceEvent(virConnectPtr connection G_GNUC_UNUSED,
 
 static gint
 virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED,
-                              virSecretPtr secret,
-                              gint event,
-                              gint detail,
-                              gpointer opaque)
+                          virSecretPtr secret,
+                          gint event,
+                          gint detail,
+                          gpointer opaque)
 {
     virtDBusConnect *connect = opaque;
     g_autofree gchar *path = NULL;
@@ -615,10 +615,10 @@ virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED,
 
 static gint
 virtDBusEventsStoragePoolEvent(virConnectPtr connection G_GNUC_UNUSED,
-                                   virStoragePoolPtr storagePool,
-                                   gint event,
-                                   gint detail,
-                                   gpointer opaque)
+                               virStoragePoolPtr storagePool,
+                               gint event,
+                               gint detail,
+                               gpointer opaque)
 {
     virtDBusConnect *connect = opaque;
     g_autofree gchar *path = NULL;
diff --git a/src/network.c b/src/network.c
index 1bacb81..3957ee6 100644
--- a/src/network.c
+++ b/src/network.c
@@ -235,7 +235,7 @@ virtDBusNetworkGetDHCPLeases(GVariant *inArgs,
         g_variant_builder_add(&builder, "(sxisssuss)",
                               lease->iface, lease->expirytime,
                               lease->type, lease->mac,
-                              lease->iaid ? lease->iaid : "" ,
+                              lease->iaid ? lease->iaid : "",
                               lease->ipaddr, lease->prefix,
                               lease->hostname ? lease->hostname : "",
                               lease->clientid ? lease->clientid : "");
diff --git a/src/util.c b/src/util.c
index a1b29dd..8c822f2 100644
--- a/src/util.c
+++ b/src/util.c
@@ -348,8 +348,8 @@ virtDBusUtilVirNodeDeviceListFree(virNodeDevicePtr *devs)
 
 virNWFilterPtr
 virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection,
-                                  const gchar *path,
-                                  const gchar *nwfilterPath)
+                                   const gchar *path,
+                                   const gchar *nwfilterPath)
 {
     g_autofree gchar *name = NULL;
     gsize prefixLen = strlen(nwfilterPath) + 1;
@@ -361,7 +361,7 @@ virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection,
 
 gchar *
 virtDBusUtilBusPathForVirNWFilter(virNWFilterPtr nwfilter,
-                                 const gchar *nwfilterPath)
+                                  const gchar *nwfilterPath)
 {
     gchar uuid[VIR_UUID_STRING_BUFLEN] = "";
     g_autofree gchar *newUuid = NULL;
diff --git a/src/util.h b/src/util.h
index 7db0e25..a688a3d 100644
--- a/src/util.h
+++ b/src/util.h
@@ -67,8 +67,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainStatsRecordPtr, virDomainStatsRecordListF
 
 virNetworkPtr
 virtDBusUtilVirNetworkFromBusPath(virConnectPtr connection,
-                                 const gchar *path,
-                                 const gchar *networkPath);
+                                  const gchar *path,
+                                  const gchar *networkPath);
 
 gchar *
 virtDBusUtilBusPathForVirNetwork(virNetworkPtr network,
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH] maint: fix coding style
Posted by Erik Skultety 5 years, 10 months ago
On Tue, Jun 19, 2018 at 06:43:07PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---

Does libvirt-dbus fancy a trivial rule? Anyways,

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list