Hello,

here's a second version of the RISV-V support patch set, initally
submitted just under a month ago [1].

[1] https://www.redhat.com/archives/libvir-list/2018-May/thread.html#01008

Thanks to the Andrea's suggestions the patch is now considerably
thinner, and split to hopefully more manageable changes.

Aside from the test suite, my test case is this (with images from [2]):

  virt-install \
    --import --name riscv64 \
    --arch riscv64 --machine virt \
    --memory 2048 \
    --rng /dev/urandom \
    --disk /var/lib/libvirt/images/stage4-disk.img,bus=virtio  \
    --boot kernel=/var/lib/libvirt/images/bbl,kernel_args="console=ttyS0 ro root=/dev/vda"

[2] https://fedorapeople.org/groups/risc-v/disk-images/

Note that the large test suite changes that touch the '*.replies' files
seem to upset the mail server, thus you're unlikely to receive them from
the list. You can get them straight from my repository instead:

  git fetch https://github.com/lkundrak/libvirt.git lr/riscv-v2:riscv-v2
  git checkout riscv-v2

Thanks!
Lubo

Diffstat follows.

Lubomir Rintel (11):
  qemu: rename qemuDomainMachineIsVirt()
  qemu: rename qemuDomainArmVirt()
  util: add RISC-V architectures
  docs/schemas: add RISC-V architectures
  qemu: no USB by default on RISC-V machines
  qemu: assign addresses to virtio devices on RISC-V
  tests/capabilitiestest: add RISC-V capability tests
  tests/util: add RISC-V capabilities
  tests/captest: check RISC-V capabilities lookup
  tests/qemuxml2argvtest: test RISC-V virt machine arguments
  tests/virschematest: add RISC-V to capabilityschemadata/caps-qemu-kvm

 docs/schemas/basictypes.rng                   |     2 +
 src/qemu/qemu_capabilities.c                  |     6 +-
 src/qemu/qemu_command.c                       |     4 +-
 src/qemu/qemu_domain.c                        |    27 +-
 src/qemu/qemu_domain.h                        |     6 +-
 src/qemu/qemu_domain_address.c                |    23 +-
 src/util/virarch.c                            |     3 +
 src/util/virarch.h                            |     6 +
 tests/capabilityschemadata/caps-qemu-kvm.xml  |    36 +
 .../caps_2.12.0.riscv32.replies               | 14679 ++++++++++++++++
 .../caps_2.12.0.riscv32.xml                   |   126 +
 .../caps_2.12.0.riscv64.replies               | 14679 ++++++++++++++++
 .../caps_2.12.0.riscv64.xml                   |   126 +
 tests/qemucapabilitiestest.c                  |     2 +
 tests/qemuxml2argvdata/riscv64-virt.args      |    31 +
 tests/qemuxml2argvdata/riscv64-virt.xml       |    32 +
 tests/qemuxml2argvtest.c                      |     3 +
 .../riscv64-virt.xml                          |    39 +
 tests/testutilsqemu.c                         |    72 +
 tests/vircapstest.c                           |     6 +
 20 files changed, 29887 insertions(+), 21 deletions(-)
 create mode 100644 tests/qemucapabilitiesdata/caps_2.12.0.riscv32.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_2.12.0.riscv32.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_2.12.0.riscv64.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_2.12.0.riscv64.xml
 create mode 100644 tests/qemuxml2argvdata/riscv64-virt.args
 create mode 100644 tests/qemuxml2argvdata/riscv64-virt.xml
 create mode 100644 tests/qemuxml2startupxmloutdata/riscv64-virt.xml

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, 2018-06-14 at 22:32 +0200, Lubomir Rintel wrote:
> Hello,
> 
> here's a second version of the RISV-V support patch set, initally
> submitted just under a month ago [1].

One more hint: you should update the release notes (docs/news.xml)
as part of your series, since you're introducing a significant new
feature.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list