[libvirt] [PATCH v4 0/2] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio posted 2 patches 5 years, 10 months ago
Failed in applying to current master (apply log)
Test syntax-check passed
There is a newer version of this series
src/xenconfig/xen_common.c | 535 +++++++++++++++++++++++----------------------
1 file changed, 273 insertions(+), 262 deletions(-)
[libvirt] [PATCH v4 0/2] Finish the conversion to virConfGetValue* functions
Posted by Fabiano Fidêncio 5 years, 10 months ago
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.

Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.

Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
can be removed.

- Changes since v1:
  All the "values" from virConfGetValueString() are freed

- Changes since v2:
  All comments from Ján Tomko have been addressed;
  A few leaks were (possibly) found and they're addressed in the last
  patch of the series;

- Changes since v3:
  All commentes from Ján Tomko have been addressed in order to lower the
  non-whitespace changes in the first patch;

Fabiano Fidêncio (2):
  xen_common: Split per-Vif logic from xenParseVif()
  xen_common: convert to typesafe virConf acessors

 src/xenconfig/xen_common.c | 535 +++++++++++++++++++++++----------------------
 1 file changed, 273 insertions(+), 262 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list