From nobody Tue Apr 30 18:53:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528721306424408.75841425829094; Mon, 11 Jun 2018 05:48:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BC20C0587E8; Mon, 11 Jun 2018 12:48:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E29789F0F; Mon, 11 Jun 2018 12:48:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA40B4CA80; Mon, 11 Jun 2018 12:48:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5BCmIMe023722 for ; Mon, 11 Jun 2018 08:48:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5515420283B6; Mon, 11 Jun 2018 12:48:18 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB34120283A3 for ; Mon, 11 Jun 2018 12:48:17 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Mon, 11 Jun 2018 14:48:16 +0200 Message-Id: <20180611124816.8501-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH] Implement Undefine method for NWFilter Interface X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 11 Jun 2018 12:48:25 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Katerina Koukiou Reviewed-by: J=EF=BF=BDn Tomko --- All other NWFilter APIs are merged but I forgot this one as Jano noticed. data/org.libvirt.NWFilter.xml | 4 ++++ src/nwfilter.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index 69e3357..b8aae02 100644 --- a/data/org.libvirt.NWFilter.xml +++ b/data/org.libvirt.NWFilter.xml @@ -19,5 +19,9 @@ + + + diff --git a/src/nwfilter.c b/src/nwfilter.c index acfbdd5..3fc6e12 100644 --- a/src/nwfilter.c +++ b/src/nwfilter.c @@ -92,6 +92,26 @@ virtDBusNWFilterGetXMLDesc(GVariant *inArgs, *outArgs =3D g_variant_new("(s)", xml); } =20 +static void +virtDBusNWFilterUndefine(GVariant *inArgs G_GNUC_UNUSED, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath, + gpointer userData, + GVariant **outArgs G_GNUC_UNUSED, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect =3D userData; + g_autoptr(virNWFilter) nwfilter =3D NULL; + + nwfilter =3D virtDBusNWFilterGetVirNWFilter(connect, objectPath, error= ); + if (!nwfilter) + return; + + if (virNWFilterUndefine(nwfilter) < 0) + virtDBusUtilSetLastVirtError(error); +} + static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] =3D { { "Name", virtDBusNWFilterGetName, NULL }, { "UUID", virtDBusNWFilterGetUUID, NULL }, @@ -100,6 +120,7 @@ static virtDBusGDBusPropertyTable virtDBusNWFilterPrope= rtyTable[] =3D { =20 static virtDBusGDBusMethodTable virtDBusNWFilterMethodTable[] =3D { { "GetXMLDesc", virtDBusNWFilterGetXMLDesc }, + { "Undefine", virtDBusNWFilterUndefine}, { 0 } }; =20 --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list