From nobody Sat Apr 20 00:00:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528470047831517.2116140076461; Fri, 8 Jun 2018 08:00:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD13987631; Fri, 8 Jun 2018 15:00:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3602F67CCB; Fri, 8 Jun 2018 15:00:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AB5104CA81; Fri, 8 Jun 2018 15:00:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58F0ch8030323 for ; Fri, 8 Jun 2018 11:00:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 733C52166BD6; Fri, 8 Jun 2018 15:00:38 +0000 (UTC) Received: from vhost2.laine.org (ovpn-117-114.phx2.redhat.com [10.3.117.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC2B92166BB2; Fri, 8 Jun 2018 15:00:37 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 11:00:34 -0400 Message-Id: <20180608150034.192341-1-laine@laine.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH] scripts: shorten netdev/domain name to prevent overflow X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 08 Jun 2018 15:00:47 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When new pids are more than 9 digits long The nwfilter tests use tck-test${pid} as the auto-generated name for their test domains (and therefore the tap devices created for those test domains). When the pid is > 9 digits long, the total length of the name is > 16, which is the maximum length for any network device name (IFNAMSIZ), and this causes failure to create the tap device, thus failure of the test: /home/laine/devel/libvirt-tck/scripts/nwfilter/050-apply-verify-host.t .. error: Failed to start domain tck-test10513851 error: Network interface name 'tck-test10513851' is too long: Numerical result out of range The solution is to just remove "test" from the name template, so pid can be up to 12 digits long before the test fails. Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/nwfilter/nwfilter2vmtest.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/nwfilter/nwfilter2vmtest.sh b/scripts/nwfilter/nwfilte= r2vmtest.sh index ae28b73..778013b 100644 --- a/scripts/nwfilter/nwfilter2vmtest.sh +++ b/scripts/nwfilter/nwfilter2vmtest.sh @@ -638,8 +638,8 @@ main() { cd "${curdir}" || { echo "cd failed" >&2; exit 1; } fi =20 - vm1=3D"tck-test$$1" - vm2=3D"tck-test$$2" + vm1=3D"tck-$$1" + vm2=3D"tck-$$2" =20 createTestFilters "${flags}" if [ $? -ne 0 ]; then --=20 2.14.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list