From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152846973190067.45279546289191; Fri, 8 Jun 2018 07:55:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E403D356DE; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1CAE6F44D; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 451F21800C9C; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58Et9Io029453 for ; Fri, 8 Jun 2018 10:55:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1F6C82024CA4; Fri, 8 Jun 2018 14:55:09 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D9432024CA1; Fri, 8 Jun 2018 14:55:08 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:53 +0100 Message-Id: <20180608145507.11295-2-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 01/15] rpm: use standard perl variables X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Jun 2018 14:55:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 We don't need to manually build variables for perl install locations as RPM includes that. Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index aac6cf6..4b1683f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -24,13 +24,6 @@ close SPEC; __DATA__ # Automatically generated by perl-Sys-Virt-TCK.spec.PL =20 -%define perlvendorarch %(perl -e 'use Config; print $Config{installvendora= rch}') -%define perlvendorlib %(perl -e 'use Config; print $Config{installvendorli= b}') -%define perlvendorprefix %(perl -e 'use Config; print $Config{vendorprefix= }') -%define perlvendorman1 %{perlvendorprefix}/share/man/man1 -%define perlvendorman3 %{perlvendorprefix}/share/man/man3 -%define perlversion %(perl -e 'use Config; print $Config{version}') - %define appname Sys-Virt-TCK =20 Summary: Sys::Virt::TCK - libvirt Technology Compatibility Kit @@ -42,7 +35,7 @@ Group: Development/Tools Source: http://libvirt.org/sources/tck/%{appname}-v%{version}.tar.gz Url: http://libvirt.org/ BuildRoot: %{_tmppath}/%{appname}-%{version}-%{release}-root-%(%{__id_u} -= n) -Requires: perl >=3D %{perlversion} +Requires: perl >=3D %{perl_version} Requires: libvirt >=3D 0.6.2 BuildRequires: perl(accessors) BuildRequires: perl(App::Prove) @@ -118,10 +111,9 @@ rm -rf $RPM_BUILD_ROOT %{_bindir}/libvirt-tck %dir %{_datadir}/libvirt-tck %{_datadir}/libvirt-tck/* -%{perlvendorman1}/* -#%{perlvendorman3}/* -%{perlvendorlib}/Sys/Virt/TCK.pm -%{perlvendorlib}/Sys/Virt/TCK/ +%{_mandir}/man1/* +%{perl_vendorlib}/Sys/Virt/TCK.pm +%{perl_vendorlib}/Sys/Virt/TCK/ %dir %{_localstatedir}/cache/libvirt-tck =20 %changelog --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469861999581.423116888179; Fri, 8 Jun 2018 07:57:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B3E93082131; Fri, 8 Jun 2018 14:57:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C578060BB3; Fri, 8 Jun 2018 14:57:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6AAB24CA80; Fri, 8 Jun 2018 14:57:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58Et9Pw029461 for ; Fri, 8 Jun 2018 10:55:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id D29D72024CA4; Fri, 8 Jun 2018 14:55:09 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A1662024CA1; Fri, 8 Jun 2018 14:55:09 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:54 +0100 Message-Id: <20180608145507.11295-3-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 02/15] rpm: add some missing dependencies X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 08 Jun 2018 14:57:41 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 4b1683f..69e5621 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -35,8 +35,12 @@ Group: Development/Tools Source: http://libvirt.org/sources/tck/%{appname}-v%{version}.tar.gz Url: http://libvirt.org/ BuildRoot: %{_tmppath}/%{appname}-%{version}-%{release}-root-%(%{__id_u} -= n) -Requires: perl >=3D %{perl_version} -Requires: libvirt >=3D 0.6.2 +Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $versi= on)) +Requires: libvirt >=3D 4.4.0 +%if 0%{?fedora} || 0%{?rhel} > 7 +BuildRequires: perl-interpreter +BuildRequires: perl-generators +%endif BuildRequires: perl(accessors) BuildRequires: perl(App::Prove) BuildRequires: perl(Config::Record) @@ -57,9 +61,12 @@ BuildRequires: perl(TAP::Harness::Archive) BuildRequires: perl(Test::Builder) BuildRequires: perl(Test::More) BuildRequires: perl(Sub::Uplevel) -BuildRequires: perl(Sys::Virt) >=3D 0.2.0 +BuildRequires: perl(Sys::Virt) >=3D 0.2.1 BuildRequires: perl(XML::Twig) BuildRequires: perl(XML::Writer) +BuildRequires: perl(XML::XPath) +BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) # RPM autoprovides misses these 3 Requires: perl(Test::Exception) Requires: perl(TAP::Formatter::HTML) @@ -69,6 +76,8 @@ Requires: perl(Net::OpenSSH) Requires: perl(IO::Pty) Requires: libguestfs-tools Requires: /usr/bin/mkisofs +# Want to force this minimal version, so don't rely on RPM autoprov +Requires: perl(Sys::Virt) >=3D 0.2.1 BuildArchitectures: noarch =20 %description --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469717228726.581262991461; Fri, 8 Jun 2018 07:55:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E46C2356D3; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9652A3001A6F; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 205161800FD8; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtApk029471 for ; Fri, 8 Jun 2018 10:55:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8EFF52024CA4; Fri, 8 Jun 2018 14:55:10 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 198C72024CA1; Fri, 8 Jun 2018 14:55:09 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:55 +0100 Message-Id: <20180608145507.11295-4-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 03/15] rpm: remove obsolete clean section X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Jun 2018 14:55:16 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 4 ---- 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 69e5621..be40d40 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,6 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/= dev/null \; =20 %__install -m 0755 -d $RPM_BUILD_ROOT%{_localstatedir}/cache/libvirt-tck =20 -%clean -rm -rf $RPM_BUILD_ROOT - - %files %defattr(-,root,root) #%doc AUTHORS --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469731226746.0003410863511; Fri, 8 Jun 2018 07:55:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B490A356CA; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BB68308BDA9; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0BDCD4CA80; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtBBc029478 for ; Fri, 8 Jun 2018 10:55:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4BCAF2024CA2; Fri, 8 Jun 2018 14:55:11 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id C97B42024CA1; Fri, 8 Jun 2018 14:55:10 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:56 +0100 Message-Id: <20180608145507.11295-5-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 04/15] rpm: remove obsolete build root setting X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Jun 2018 14:55:30 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index be40d40..ab2194f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -34,7 +34,6 @@ License: GPLv2 Group: Development/Tools Source: http://libvirt.org/sources/tck/%{appname}-v%{version}.tar.gz Url: http://libvirt.org/ -BuildRoot: %{_tmppath}/%{appname}-%{version}-%{release}-root-%(%{__id_u} -= n) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $versi= on)) Requires: libvirt >=3D 4.4.0 %if 0%{?fedora} || 0%{?rhel} > 7 --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469736914579.4820036308973; Fri, 8 Jun 2018 07:55:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F1133086246; Fri, 8 Jun 2018 14:55:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5353A5C8B9; Fri, 8 Jun 2018 14:55:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DD59E4CA82; Fri, 8 Jun 2018 14:55:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtCPT029483 for ; Fri, 8 Jun 2018 10:55:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0E1652024CA2; Fri, 8 Jun 2018 14:55:12 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 859BC2024CA1; Fri, 8 Jun 2018 14:55:11 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:57 +0100 Message-Id: <20180608145507.11295-6-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 05/15] rpm: remove obsolete group setting X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 08 Jun 2018 14:55:36 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index ab2194f..0dea8de 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -31,7 +31,6 @@ Name: perl-%{appname} Version: @VERSION@ Release: 1 License: GPLv2 -Group: Development/Tools Source: http://libvirt.org/sources/tck/%{appname}-v%{version}.tar.gz Url: http://libvirt.org/ Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $versi= on)) --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469867515637.2001758186392; Fri, 8 Jun 2018 07:57:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 605935D697; Fri, 8 Jun 2018 14:57:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 297D35D755; Fri, 8 Jun 2018 14:57:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BD58D1800FC1; Fri, 8 Jun 2018 14:57:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtCo9029488 for ; Fri, 8 Jun 2018 10:55:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD3A02024CA2; Fri, 8 Jun 2018 14:55:12 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 481942024CA1; Fri, 8 Jun 2018 14:55:12 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:58 +0100 Message-Id: <20180608145507.11295-7-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 06/15] rpm: cleanup docs file list X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 08 Jun 2018 14:57:47 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 0dea8de..a9b4148 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,8 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/= dev/null \; =20 %files %defattr(-,root,root) -#%doc AUTHORS -%doc LICENSE +%license LICENSE %doc README -#%doc INSTALL %dir %{_sysconfdir}/libvirt-tck %config(noreplace) %{_sysconfdir}/libvirt-tck/default.cfg %{_bindir}/libvirt-tck --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469873174908.3167225915876; Fri, 8 Jun 2018 07:57:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8F40308FB96; Fri, 8 Jun 2018 14:57:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 973D2611C2; Fri, 8 Jun 2018 14:57:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2BCDE1800C9C; Fri, 8 Jun 2018 14:57:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtDRg029493 for ; Fri, 8 Jun 2018 10:55:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 790432024CA2; Fri, 8 Jun 2018 14:55:13 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 035E92024CA1; Fri, 8 Jun 2018 14:55:12 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:54:59 +0100 Message-Id: <20180608145507.11295-8-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 07/15] rpm: delete redundant changelog X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 08 Jun 2018 14:57:52 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The changelog entries only make sense in the context of a distro, not upstream. Signed-off-by: Daniel P. Berrang=C3=A9 --- perl-Sys-Virt-TCK.spec.PL | 2 -- 1 file changed, 2 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index a9b4148..0026b7e 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -118,5 +118,3 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/d= ev/null \; %dir %{_localstatedir}/cache/libvirt-tck =20 %changelog -* Fri Mar 24 2006 - 0.0.1-1 -- Initial build --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469856330627.8563612382998; Fri, 8 Jun 2018 07:57:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56C194E90E; Fri, 8 Jun 2018 14:57:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 178BE308BDA9; Fri, 8 Jun 2018 14:57:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B6EA74BB78; Fri, 8 Jun 2018 14:57:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtEbx029501 for ; Fri, 8 Jun 2018 10:55:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 353022024CA2; Fri, 8 Jun 2018 14:55:14 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2DB32024CA1; Fri, 8 Jun 2018 14:55:13 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:00 +0100 Message-Id: <20180608145507.11295-9-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 08/15] build: misc updates the Module::Build config X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 08 Jun 2018 14:57:35 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- Build.PL | 12 +++++++----- MANIFEST | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Build.PL b/Build.PL index bf2d7a9..75a1436 100644 --- a/Build.PL +++ b/Build.PL @@ -61,6 +61,9 @@ EOF my $b =3D $class->new( module_name =3D> "Sys::Virt::TCK", license =3D> 'gpl', + configure_requires =3D> { + 'Module::Build' =3D> 0, + }, dist_author =3D> 'Daniel Berrange ', dist_abstract =3D> 'libvirt Technology Compatability Kit', requires =3D> { @@ -100,13 +103,12 @@ my $b =3D $class->new( script_files =3D> [ "bin/libvirt-tck", ], - create_makefile_pl =3D> 'passthrough', meta_add =3D> { resources =3D> { - license =3D> "http://www.gnu.org/licenses/gpl.html", - homepage =3D> "http://libvirt.org/", - repository =3D> "http://libvirt.org/hg/libvirt-tck", - MailingList =3D> "http://www.redhat.com/mailman/listinfo/libvi= r-list", + license =3D> "https://www.gnu.org/licenses/gpl.html", + homepage =3D> "https://libvirt.org/", + repository =3D> "https://libvirt.org/git/?p=3Dlibvirt-tck.git;= a=3Dsummary", + MailingList =3D> "https://www.redhat.com/mailman/listinfo/libv= ir-list", }, }, conf_files =3D> { diff --git a/MANIFEST b/MANIFEST index b632328..9338981 100644 --- a/MANIFEST +++ b/MANIFEST @@ -15,7 +15,6 @@ lib/Sys/Virt/TCK/StorageVolBuilder.pm lib/Sys/Virt/TCK/TAP/XMLFormatter.pm lib/Sys/Virt/TCK/TAP/XMLFormatterSession.pm LICENSE -Makefile.PL MANIFEST META.json META.yml --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469862506612.8310553768767; Fri, 8 Jun 2018 07:57:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B42E5F7A6; Fri, 8 Jun 2018 14:57:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 259D03001A68; Fri, 8 Jun 2018 14:57:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CEC6D4CA85; Fri, 8 Jun 2018 14:57:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtFYN029514 for ; Fri, 8 Jun 2018 10:55:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id E7AC82024CA2; Fri, 8 Jun 2018 14:55:14 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 725012024CA1; Fri, 8 Jun 2018 14:55:14 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:01 +0100 Message-Id: <20180608145507.11295-10-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 09/15] conf: update URLs for Fedora 28 images X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 08 Jun 2018 14:57:41 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- conf/default.cfg | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index d9d858c..494c303 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images =3D ( hvm xen ) - osname =3D fedora-27 + osname =3D fedora-28 } ) =20 @@ -75,15 +75,15 @@ images =3D ( # empty sparse root FS will be created # kernels =3D ( - # Fedora 15 i686 PAE has pv_ops, so one kernel can do both Xen and KVM = guests here + # Fedora 28 i686 PAE has pv_ops, so one kernel can do both Xen and KVM = guests here { arch =3D i686 ostype =3D ( hvm xen ) - kernel =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/27/E= verything/i386/os/images/pxeboot/vmlinuz-PAE - initrd =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/27/E= verything/i386/os/images/pxeboot/initrd-PAE.img + kernel =3D http://dl.fedoraproject.org/pub/fedora-secondary/releases/= 28/Everything/i386/os/images/pxeboot/vmlinuz + initrd =3D http://dl.fedoraproject.org/pub/fedora-secondary/releases/= 28/Everything/i386/os/images/pxeboot/initrd.img } # Fedora 15 x86_64 has pv_ops, so one kernel can do both Xen and KVM gu= ests here { @@ -92,8 +92,8 @@ kernels =3D ( hvm xen ) - kernel =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/27/E= verything/x86_64/os/images/pxeboot/vmlinuz - initrd =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/27/E= verything/x86_64/os/images/pxeboot/initrd.img + kernel =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/28/E= verything/x86_64/os/images/pxeboot/vmlinuz + initrd =3D http://dl.fedoraproject.org/pub/fedora/linux/releases/28/E= verything/x86_64/os/images/pxeboot/initrd.img } # User mode linux i686 needs custom kernel + root filesystem { --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15284698785201020.3555088168454; Fri, 8 Jun 2018 07:57:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7CFB5307D85E; Fri, 8 Jun 2018 14:57:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF33EB1A2B; Fri, 8 Jun 2018 14:57:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F505180BA80; Fri, 8 Jun 2018 14:57:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtFQ8029527 for ; Fri, 8 Jun 2018 10:55:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id A2B2B2024CA4; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D8992024CA1; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:02 +0100 Message-Id: <20180608145507.11295-11-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 10/15] build: ignore more auto generated files X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 08 Jun 2018 14:57:58 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index ca3e424..65b446f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,10 @@ *.orig *~ Build +META.json META.yml +MYMETA.json +MYMETA.yml Makefile Makefile.PL Makefile.old --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469723870256.70358708323454; Fri, 8 Jun 2018 07:55:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ADB8185363; Fri, 8 Jun 2018 14:55:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71AE4B1A05; Fri, 8 Jun 2018 14:55:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E2424BB78; Fri, 8 Jun 2018 14:55:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtG2l029534 for ; Fri, 8 Jun 2018 10:55:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5FA542024CA2; Fri, 8 Jun 2018 14:55:16 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCD802024CA1; Fri, 8 Jun 2018 14:55:15 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:03 +0100 Message-Id: <20180608145507.11295-12-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 08 Jun 2018 14:55:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Despite having StrictHostKeyChecking=3Dno, SSH still complains about the host key mismatch and disables password auth as a result. Using /dev/null as the known_hosts file ensures the keys are never saved to the user's profile. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- scripts/nwfilter/210-no-mac-spoofing.t | 3 ++- scripts/nwfilter/220-no-ip-spoofing.t | 3 ++- scripts/nwfilter/230-no-mac-broadcast.t | 3 ++- scripts/nwfilter/240-no-arp-spoofing.t | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/scripts/nwfilter/210-no-mac-spoofing.t b/scripts/nwfilter/210-= no-mac-spoofing.t index 99c5058..95b1499 100644 --- a/scripts/nwfilter/210-no-mac-spoofing.t +++ b/scripts/nwfilter/210-no-mac-spoofing.t @@ -97,7 +97,8 @@ diag "ssh'ing into $guestip"; my $ssh =3D Net::OpenSSH->new($guestip, user =3D> "root", password =3D> $tck->root_password(), - master_opts =3D> [-o =3D> "StrictHostKeyChecki= ng=3Dno"]); + master_opts =3D> [-o =3D> "UserKnownHostsFile= =3D/dev/null", + -o =3D> "StrictHostKeyChecking= =3Doff"]); =20 # now bring eth0 down, change MAC and bring it up again diag "fiddling with mac"; diff --git a/scripts/nwfilter/220-no-ip-spoofing.t b/scripts/nwfilter/220-n= o-ip-spoofing.t index 85c4807..a1da6eb 100644 --- a/scripts/nwfilter/220-no-ip-spoofing.t +++ b/scripts/nwfilter/220-no-ip-spoofing.t @@ -91,7 +91,8 @@ diag "ssh'ing into $guestip"; my $ssh =3D Net::OpenSSH->new($guestip, user =3D> "root", password =3D> $tck->root_password(), - master_opts =3D> [-o =3D> "StrictHostKeyChecki= ng=3Dno"]); + master_opts =3D> [-o =3D> "UserKnownHostsFile= =3D/dev/null", + -o =3D> "StrictHostKeyChecking= =3Dno"]); =20 # now bring eth0 down, change IP and bring it up again diag "preparing ip spoof"; diff --git a/scripts/nwfilter/230-no-mac-broadcast.t b/scripts/nwfilter/230= -no-mac-broadcast.t index b65b3fc..4254e7c 100644 --- a/scripts/nwfilter/230-no-mac-broadcast.t +++ b/scripts/nwfilter/230-no-mac-broadcast.t @@ -119,7 +119,8 @@ diag "ssh'ing into $guestip"; my $ssh =3D Net::OpenSSH->new($guestip, user =3D> "root", password =3D> $tck->root_password(), - master_opts =3D> [-o =3D> "StrictHostKeyCheck= ing=3Dno"]); + master_opts =3D> [-o =3D> "UserKnownHostsFile= =3D/dev/null", + -o =3D> "StrictHostKeyCheckin= g=3Dno"]); =20 # now generate a mac broadcast paket=20 diag "generate mac broadcast"; diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-= no-arp-spoofing.t index 69851b6..882a385 100644 --- a/scripts/nwfilter/240-no-arp-spoofing.t +++ b/scripts/nwfilter/240-no-arp-spoofing.t @@ -100,7 +100,8 @@ diag "ssh'ing into $guestip"; my $ssh =3D Net::OpenSSH->new($guestip, user =3D> "root", password =3D> $tck->root_password(), - master_opts =3D> [-o =3D> "StrictHostKeyChecki= ng=3Dno"]); + master_opts =3D> [-o =3D> "UserKnownHostsFile= =3D/dev/null", + -o =3D> "StrictHostKeyChecking= =3Dno"]); =20 # now generate a arp spoofing packets=20 diag "generate arpspoof script"; --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469884581467.9030478982801; Fri, 8 Jun 2018 07:58:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 822D230C10F8; Fri, 8 Jun 2018 14:58:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 532C126E5C; Fri, 8 Jun 2018 14:58:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AAAE21800C9C; Fri, 8 Jun 2018 14:58:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtHO1029540 for ; Fri, 8 Jun 2018 10:55:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 214722024CA4; Fri, 8 Jun 2018 14:55:17 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A44B2024CA1; Fri, 8 Jun 2018 14:55:16 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:04 +0100 Message-Id: <20180608145507.11295-13-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 12/15] lib: use Test::More directly instead of Test::Builder X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 08 Jun 2018 14:58:04 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- lib/Sys/Virt/TCK.pm | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 29280f6..1a835bd 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -35,7 +35,7 @@ use XML::XPath; use Carp qw(cluck carp); use Fcntl qw(O_RDONLY SEEK_END); =20 -use Test::Builder; +use Test::More; use Sub::Uplevel qw(uplevel); use base qw(Exporter); =20 @@ -1035,8 +1035,6 @@ sub _try_as_caller { }; =20 =20 -my $Tester =3D Test::Builder->new; - sub ok_object($$$;$) { my $coderef =3D shift; my $class =3D shift; @@ -1052,16 +1050,16 @@ sub ok_object($$$;$) { $ret && ref($ret) && $ret->isa($class) && (!defined $name || ($ret->get_name() eq $name)); =20 - $Tester->ok($ok, $description); + ok($ok, $description); unless ($ok) { - $Tester->diag("expected $class object" . ($name ? " with name $nam= e" : "")); + diag("expected $class object" . ($name ? " with name $name" : "")); if ($exception) { - $Tester->diag("found '$exception'"); + diag("found '$exception'"); } else { if ($ret && ref($ret) && $ret->isa($class)) { - $Tester->diag("found $class object with name " . $ret->get= _name); + diag("found $class object with name " . $ret->get_name); } else { - $Tester->diag("found '$ret'"); + diag("found '$ret'"); } } } @@ -1137,10 +1135,10 @@ sub ok_error(&$;$) { my $ok =3D ref($exception) && $exception->isa("Sys::Virt::Error") && (!defined $code || ($exception->code() =3D=3D $code)); =20 - $Tester->ok($ok, $description); + ok($ok, $description); unless ($ok) { - $Tester->diag("expecting Sys::Virt::Error object" . ($code ? " wi= th code $code" : "")); - $Tester->diag("found '$exception'"); + diag("expecting Sys::Virt::Error object" . ($code ? " with code $= code" : "")); + diag("found '$exception'"); } $@ =3D $exception; return $ok; --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152846986764985.61018252546796; Fri, 8 Jun 2018 07:57:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 964B1C04AC54; Fri, 8 Jun 2018 14:57:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59AD83001A75; Fri, 8 Jun 2018 14:57:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 01FC04CA83; Fri, 8 Jun 2018 14:57:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtIc7029552 for ; Fri, 8 Jun 2018 10:55:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id D22EA2024CA4; Fri, 8 Jun 2018 14:55:17 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C4EF2024CA1; Fri, 8 Jun 2018 14:55:17 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:05 +0100 Message-Id: <20180608145507.11295-14-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 08 Jun 2018 14:57:47 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The TCK module requires stuff in the NetworkHelpers and also vica-verca. This circular dependancy causes import problems, when trying to use the functions in NetworkHelpers from the TCK module. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- MANIFEST | 1 - lib/Sys/Virt/TCK.pm | 71 +++++++++++++++++++++- lib/Sys/Virt/TCK/NetworkHelpers.pm | 72 ----------------------- scripts/domain/180-interface-parameters.t | 1 - scripts/nwfilter/100-ping-still-working.t | 1 - scripts/nwfilter/210-no-mac-spoofing.t | 1 - scripts/nwfilter/220-no-ip-spoofing.t | 1 - scripts/nwfilter/230-no-mac-broadcast.t | 1 - scripts/nwfilter/240-no-arp-spoofing.t | 1 - scripts/nwfilter/300-vsitype.t | 1 - 10 files changed, 70 insertions(+), 81 deletions(-) delete mode 100644 lib/Sys/Virt/TCK/NetworkHelpers.pm diff --git a/MANIFEST b/MANIFEST index 9338981..79f93c0 100644 --- a/MANIFEST +++ b/MANIFEST @@ -8,7 +8,6 @@ lib/Sys/Virt/TCK/Capabilities.pm lib/Sys/Virt/TCK/DomainBuilder.pm lib/Sys/Virt/TCK/Hooks.pm lib/Sys/Virt/TCK/NetworkBuilder.pm -lib/Sys/Virt/TCK/NetworkHelpers.pm lib/Sys/Virt/TCK/SELinux.pm lib/Sys/Virt/TCK/StoragePoolBuilder.pm lib/Sys/Virt/TCK/StorageVolBuilder.pm diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 1a835bd..60bd136 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -34,6 +34,7 @@ use IO::Uncompress::Bunzip2 qw(bunzip2); use XML::XPath; use Carp qw(cluck carp); use Fcntl qw(O_RDONLY SEEK_END); +use NetAddr::IP qw(:lower); =20 use Test::More; use Sub::Uplevel qw(uplevel); @@ -41,7 +42,9 @@ use base qw(Exporter); =20 our @EXPORT =3D qw(ok_error ok_domain ok_domain_snapshot ok_pool ok_volume ok_network ok_interface ok_node_device - xpath err_not_implemented); + xpath err_not_implemented get_first_macaddress + get_first_interface_target_dev get_network_ip + get_ip_from_leases shutdown_vm_gracefully); =20 our $VERSION =3D 'v0.1.0'; =20 @@ -1230,4 +1233,70 @@ sub get_host_network_device { return $self->config("host_network_devices/[$devindex]", undef); } =20 +sub get_first_macaddress { + my $dom =3D shift; + my $mac =3D xpath($dom, "string(/domain/devices/interface[1]/mac/\@add= ress)"); + utf8::encode($mac); + return $mac; +} + +sub get_first_interface_target_dev { + my $dom =3D shift; + my $targetdev =3D xpath($dom, "string(/domain/devices/interface[1]/tar= get/\@dev)"); + return $targetdev; +} + +sub get_network_ip { + my $conn =3D shift; + my $netname =3D shift; + diag "getting ip for network $netname"; + my $net =3D $conn->get_network_by_name($netname); + my $net_ip =3D xpath($net, "string(/network/ip[1]/\@address"); + my $net_mask =3D xpath($net, "string(/network/ip[1]/\@netmask"); + my $net_prefix =3D xpath($net, "string(/network/ip[1]/\@prefix"); + my $ip; + + if ($net_mask) { + $ip =3D NetAddr::IP->new($net_ip, $net_mask); + } elsif ($net_prefix) { + $ip =3D NetAddr::IP->new("$net_ip/$net_mask"); + } else { + $ip =3D NetAddr::IP->new("$net_ip"); + } + return $ip; +} + + +sub get_ip_from_leases{ + my $conn =3D shift; + my $netname =3D shift; + my $mac =3D shift; + + my $net =3D $conn->get_network_by_name($netname); + if ($net->can('get_dhcp_leases')) { + my @leases =3D $net->get_dhcp_leases($mac); + return @leases ? @leases[0]->{'ipaddr'} : undef; + } + + my $tmp =3D `grep $mac /var/lib/libvirt/dnsmasq/default.leases`; + my @fields =3D split(/ /, $tmp); + my $ip =3D $fields[2]; + return $ip; +} + + +sub shutdown_vm_gracefully { + my $dom =3D shift; + + my $target =3D time() + 30; + $dom->shutdown; + while ($dom->is_active()) { + sleep(1); + diag ".. waiting for virtual machine to shutdown.. "; + $dom->destroy() if time() > $target; + } + sleep(1); + diag ".. shutdown complete.. "; +} + 1; diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm b/lib/Sys/Virt/TCK/NetworkH= elpers.pm deleted file mode 100644 index 50ade0f..0000000 --- a/lib/Sys/Virt/TCK/NetworkHelpers.pm +++ /dev/null @@ -1,72 +0,0 @@ -use Sys::Virt::TCK qw(xpath); -use NetAddr::IP qw(:lower); -use strict; -use utf8; - -sub get_first_macaddress { - my $dom =3D shift; - my $mac =3D xpath($dom, "string(/domain/devices/interface[1]/mac/\@add= ress)"); - utf8::encode($mac); - return $mac; -} - -sub get_first_interface_target_dev { - my $dom =3D shift; - my $targetdev =3D xpath($dom, "string(/domain/devices/interface[1]/tar= get/\@dev)"); - return $targetdev; -} - -sub get_network_ip { - my $conn =3D shift; - my $netname =3D shift; - diag "getting ip for network $netname"; - my $net =3D $conn->get_network_by_name($netname); - my $net_ip =3D xpath($net, "string(/network/ip[1]/\@address"); - my $net_mask =3D xpath($net, "string(/network/ip[1]/\@netmask"); - my $net_prefix =3D xpath($net, "string(/network/ip[1]/\@prefix"); - my $ip; - - if ($net_mask) { - $ip =3D NetAddr::IP->new($net_ip, $net_mask); - } elsif ($net_prefix) { - $ip =3D NetAddr::IP->new("$net_ip/$net_mask"); - } else { - $ip =3D NetAddr::IP->new("$net_ip"); - } - return $ip; -} - - -sub get_ip_from_leases{ - my $conn =3D shift; - my $netname =3D shift; - my $mac =3D shift; - - my $net =3D $conn->get_network_by_name($netname); - if ($net->can('get_dhcp_leases')) { - my @leases =3D $net->get_dhcp_leases($mac); - return @leases ? @leases[0]->{'ipaddr'} : undef; - } - - my $tmp =3D `grep $mac /var/lib/libvirt/dnsmasq/default.leases`; - my @fields =3D split(/ /, $tmp); - my $ip =3D $fields[2]; - return $ip; -} - - -sub shutdown_vm_gracefully { - my $dom =3D shift; - - my $target =3D time() + 30; - $dom->shutdown; - while ($dom->is_active()) { - sleep(1); - diag ".. waiting for virtual machine to shutdown.. "; - $dom->destroy() if time() > $target; - } - sleep(1); - diag ".. shutdown complete.. "; -} - -1; diff --git a/scripts/domain/180-interface-parameters.t b/scripts/domain/180= -interface-parameters.t index 66c7ed6..b3f0c19 100644 --- a/scripts/domain/180-interface-parameters.t +++ b/scripts/domain/180-interface-parameters.t @@ -33,7 +33,6 @@ use warnings; use Test::More tests =3D> 10; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use File::stat; =20 diff --git a/scripts/nwfilter/100-ping-still-working.t b/scripts/nwfilter/1= 00-ping-still-working.t index 12f2c7c..a88eb02 100644 --- a/scripts/nwfilter/100-ping-still-working.t +++ b/scripts/nwfilter/100-ping-still-working.t @@ -30,7 +30,6 @@ use warnings; use Test::More tests =3D> 4; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; =20 use File::Spec::Functions qw(catfile catdir rootdir); diff --git a/scripts/nwfilter/210-no-mac-spoofing.t b/scripts/nwfilter/210-= no-mac-spoofing.t index 95b1499..87c19e7 100644 --- a/scripts/nwfilter/210-no-mac-spoofing.t +++ b/scripts/nwfilter/210-no-mac-spoofing.t @@ -29,7 +29,6 @@ use warnings; use Test::More tests =3D> 5; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use Net::OpenSSH; =20 diff --git a/scripts/nwfilter/220-no-ip-spoofing.t b/scripts/nwfilter/220-n= o-ip-spoofing.t index a1da6eb..bacb861 100644 --- a/scripts/nwfilter/220-no-ip-spoofing.t +++ b/scripts/nwfilter/220-no-ip-spoofing.t @@ -29,7 +29,6 @@ use warnings; use Test::More tests =3D> 4; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use Net::OpenSSH; =20 diff --git a/scripts/nwfilter/230-no-mac-broadcast.t b/scripts/nwfilter/230= -no-mac-broadcast.t index 4254e7c..b518a81 100644 --- a/scripts/nwfilter/230-no-mac-broadcast.t +++ b/scripts/nwfilter/230-no-mac-broadcast.t @@ -29,7 +29,6 @@ use warnings; use Test::More tests =3D> 4; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-= no-arp-spoofing.t index 882a385..77b36d2 100644 --- a/scripts/nwfilter/240-no-arp-spoofing.t +++ b/scripts/nwfilter/240-no-arp-spoofing.t @@ -29,7 +29,6 @@ use warnings; use Test::More tests =3D> 4; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); diff --git a/scripts/nwfilter/300-vsitype.t b/scripts/nwfilter/300-vsitype.t index 90d237f..3af9d4f 100644 --- a/scripts/nwfilter/300-vsitype.t +++ b/scripts/nwfilter/300-vsitype.t @@ -29,7 +29,6 @@ use warnings; use Test::More; =20 use Sys::Virt::TCK; -use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; use File::Spec::Functions qw(catfile catdir rootdir); =20 --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15284698899791006.68940158373; Fri, 8 Jun 2018 07:58:09 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8F48308FB81; Fri, 8 Jun 2018 14:58:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3C796F7EB; Fri, 8 Jun 2018 14:58:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 52F451801218; Fri, 8 Jun 2018 14:58:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtI7G029562 for ; Fri, 8 Jun 2018 10:55:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8F4112024CA5; Fri, 8 Jun 2018 14:55:18 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1895E2024CA1; Fri, 8 Jun 2018 14:55:17 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:06 +0100 Message-Id: <20180608145507.11295-15-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 08 Jun 2018 14:58:09 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The source file headers all say GPL and do not mention the Artistic license, likewise the Build.PL file and RPM Spec. Remove bogus references to the Artistic license from the LICENSE file. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- LICENSE | 159 -------------------------------------------------------- 1 file changed, 159 deletions(-) diff --git a/LICENSE b/LICENSE index 2fce945..f8bb166 100644 --- a/LICENSE +++ b/LICENSE @@ -1,18 +1,3 @@ -This program is free software; you can redistribute it and/or modify -it under the terms of either: - -a) the GNU General Public License as published by the Free - Software Foundation; either version 2, or (at your option) any - later version - -or - -b) the "Artistic License" - -The text of both licenses follows below... - ---------------------------------------------------------------------------- - GNU GENERAL PUBLIC LICENSE Version 2, June 1991 =20 @@ -295,147 +280,3 @@ POSSIBILITY OF SUCH DAMAGES. =20 END OF TERMS AND CONDITIONS =20 ---------------------------------------------------------------------------- - -The "Artistic License" - - Preamble - - The intent of this document is to state the conditions under which a - Package may be copied, such that the Copyright Holder maintains some - semblance of artistic control over the development of the package, - while giving the users of the package the right to use and distribu= te - the Package in a more-or-less customary fashion, plus the right to = make - reasonable modifications. - - Definitions - - "Package" - refers to the collection of files distributed by the Copyright - Holder, and derivatives of that collection of files created thr= ough - textual modification. - - "Standard Version" - refers to such a Package if it has not been modified, or has be= en - modified in accordance with the wishes of the Copyright Holder = as - specified below. - - "Copyright Holder" - is whoever is named in the copyright or copyrights for the pack= age. - - "You" - is you, if you're thinking about copying or distributing this P= ack- - age. - - "Reasonable copying fee" - is whatever you can justify on the basis of media cost, duplica= tion - charges, time of people involved, and so on. (You will not be - required to justify it to the Copyright Holder, but only to the - computing community at large as a market that must bear the fee= .) - - "Freely Available" - means that no fee is charged for the item itself, though there = may - be fees involved in handling the item. It also means that recip= i- - ents of the item may redistribute it under the same conditions = they - received it. - - Conditions - - 1. You may make and give away verbatim copies of the source form of - the Standard Version of this Package without restriction, provi= ded - that you duplicate all of the original copyright notices and as= so- - ciated disclaimers. - - 2. You may apply bug fixes, portability fixes and other modificati= ons - derived from the Public Domain or from the Copyright Holder. A - Package modified in such a way shall still be considered the St= an- - dard Version. - - 3. You may otherwise modify your copy of this Package in any way, = pro- - vided that you insert a prominent notice in each changed file s= tat- - ing how and when you changed that file, and provided that you d= o at - least ONE of the following: - - a) place your modifications in the Public Domain or otherwise = make - them Freely Available, such as by posting said modification= s to - Usenet or an equivalent medium, or placing the modification= s on - a major archive site such as uunet.uu.net, or by allowing t= he - Copyright Holder to include your modifications in the Stand= ard - Version of the Package. - - b) use the modified Package only within your corporation or or= ga- - nization. - - c) rename any non-standard executables so the names do not con- - flict with standard executables, which must also be provide= d, - and provide a separate manual page for each non-standard ex= e- - cutable that clearly documents how it differs from the Stan= dard - Version. - - d) make other distribution arrangements with the Copyright Hol= der. - - 4. You may distribute the programs of this Package in object code = or - executable form, provided that you do at least ONE of the follo= w- - ing: - - a) distribute a Standard Version of the executables and library - files, together with instructions (in the manual page or eq= uiv- - alent) on where to get the Standard Version. - - b) accompany the distribution with the machine-readable source= of - the Package with your modifications. - - c) give non-standard executables non-standard names, and clear= ly - document the differences in manual pages (or equivalent), - together with instructions on where to get the Standard Ver- - sion. - - d) make other distribution arrangements with the Copyright Hol= der. - - 5. You may charge a reasonable copying fee for any distribution of - this Package. You may charge any fee you choose for support of - this Package. You may not charge a fee for this Package itself. - However, you may distribute this Package in aggregate with other - (possibly commercial) programs as part of a larger (possibly co= m- - mercial) software distribution provided that you do not adverti= se - this Package as a product of your own. You may embed this Pack- - age's interpreter within an executable of yours (by linking); t= his - shall be construed as a mere form of aggregation, provided that= the - complete Standard Version of the interpreter is so embedded. - - 6. The scripts and library files supplied as input to or produced = as - output from the programs of this Package do not automatically f= all - under the copyright of this Package, but belong to whoever gene= r- - ated them, and may be sold commercially, and may be aggregated = with - this Package. If such scripts or library files are aggregated = with - this Package via the so-called "undump" or "unexec" methods of = pro- - ducing a binary executable image, then distribution of such an - image shall neither be construed as a distribution of this Pack= age - nor shall it fall under the restrictions of Paragraphs 3 and 4, - provided that you do not represent such an executable image as a - Standard Version of this Package. - - 7. C subroutines (or comparably compiled subroutines in other lan- - guages) supplied by you and linked into this Package in order to - emulate subroutines and variables of the language defined by th= is - Package shall not be considered part of this Package, but are t= he - equivalent of input as in Paragraph 6, provided these subroutin= es - do not change the language in any way that would cause it to fa= il - the regression tests for the language. - - 8. Aggregation of this Package with a commercial distribution is - always permitted provided that the use of this Package is embed= ded; - that is, when no overt attempt is made to make this Package's - interfaces visible to the end user of the commercial distributi= on. - Such use shall not be construed as a distribution of this Packa= ge. - - 9. The name of the Copyright Holder may not be used to endorse or = pro- - mote products derived from this software without specific prior - written permission. - - 10. THIS PACKAGE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR IMP= LIED - WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTI= ES - OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. - - The End ---------------------------------------------------------------------------- --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 14:24:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528469731036292.1114048895249; Fri, 8 Jun 2018 07:55:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D211681DEC; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7295E67646; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0EC734CA84; Fri, 8 Jun 2018 14:55:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w58EtJb3029575 for ; Fri, 8 Jun 2018 10:55:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4F0A02024CA4; Fri, 8 Jun 2018 14:55:19 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9C302024CA1; Fri, 8 Jun 2018 14:55:18 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 8 Jun 2018 15:55:07 +0100 Message-Id: <20180608145507.11295-16-berrange@redhat.com> In-Reply-To: <20180608145507.11295-1-berrange@redhat.com> References: <20180608145507.11295-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 15/15] lib: fix array value accessor to use preferred style X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 08 Jun 2018 14:55:30 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- lib/Sys/Virt/TCK.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 60bd136..78d3774 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -1275,7 +1275,7 @@ sub get_ip_from_leases{ my $net =3D $conn->get_network_by_name($netname); if ($net->can('get_dhcp_leases')) { my @leases =3D $net->get_dhcp_leases($mac); - return @leases ? @leases[0]->{'ipaddr'} : undef; + return @leases ? $leases[0]->{'ipaddr'} : undef; } =20 my $tmp =3D `grep $mac /var/lib/libvirt/dnsmasq/default.leases`; --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list