From nobody Thu May 2 09:22:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528180409169484.2536216670338; Mon, 4 Jun 2018 23:33:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04CFDC07227A; Tue, 5 Jun 2018 06:33:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8770B600C0; Tue, 5 Jun 2018 06:33:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D8795EEF0; Tue, 5 Jun 2018 06:33:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w556XI9i019585 for ; Tue, 5 Jun 2018 02:33:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF38F308BDA2; Tue, 5 Jun 2018 06:33:18 +0000 (UTC) Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A413D308BDA1 for ; Tue, 5 Jun 2018 06:33:16 +0000 (UTC) Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6191623E6F7 for ; Tue, 5 Jun 2018 06:33:05 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id l10-v6so1033214wrn.2 for ; Mon, 04 Jun 2018 23:33:05 -0700 (PDT) Received: from rst.Home ([2a02:c7d:692a:c500:1ebc:73f3:5f60:b131]) by smtp.gmail.com with ESMTPSA id o12-v6sm71029248wrf.30.2018.06.04.23.33.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 23:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=seYK78APN0HnU1cD50Tp5jnCLla82FSk7+GlW/FoxcU=; b=KSOpr7KbhuheGelqhMGQCnbiewhhrxwqUTjo+Ez7rci4f6nxVw5AfQ2W5fPq4Haudl l48fM1GpC1X6J5GxHZ9MjMzt12GfqONTXYvrKqPWAHg9bf5JV+qy5TZ4y+qQfYcH/2UA 1EXpqLDUyHEIWu+iZ1XRqiYngmXhAQjfKwJnZvj2r9sIHTDIpZEcAVmHhML1oxiDcyBO uZ6n6axB5cGRa/uJQexOs0yyRIz77R+qEIpX/Ehh687R1Dey2LRvKsl8KL1tzXCktecN 6z+8x3RbB0iLOigXTghDH/DnIBYpwqXszIIoqeqaEX0pWSZrgLZ/EPUIj2AZd+zzXDND 2d/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=seYK78APN0HnU1cD50Tp5jnCLla82FSk7+GlW/FoxcU=; b=YG60L2n4pOCOhCwBJ5Xtv9H+HoIZPTKZgbL32D1oq2F385Mc2Glu9VP7vizdUXFOm8 n9DAG60stKj9ZPsEaZjVhdIkV5V7EzXpXiB9buVCe3xvM5A4qJx5UGxUIeSJbpnjKrtw 3L6nDlEggE7K8D8W/uvw+65ciTVvN1CXZmBg6H0BPPkwTXMOrVS5zjSFtooTabZm9C1K pBVfufbUI2JxP0SJiQrBteoRRu0eef+FrQZQ6WkFq248QeG+OvGQIXA5gLdxaPcKz4Nm SmaNSwANHGBMVi42ceLNZBPzNdX+Iea5LWh0ovnuwWger88cZK9SAsN51+QP89NuseD+ D2dA== X-Gm-Message-State: ALKqPwdk/u3yPHSFflHcy1yNBwdLvQcdaFCkPm79aqN4oowU55knDnK3 G/F5A5D/4b3u6rVzAL3PZRcht1M+ X-Google-Smtp-Source: ADUXVKJV1aJy03QfV+gSsVAvwf/KUL5aOBUctBVmalbPhg/IsdaPBCCdXkmxFU2AOkDJASi0/OEuwg== X-Received: by 2002:adf:a60c:: with SMTP id k12-v6mr18984213wrc.200.1528180383780; Mon, 04 Jun 2018 23:33:03 -0700 (PDT) From: Radostin Stoyanov To: libvir-list@redhat.com Date: Tue, 5 Jun 2018 07:32:57 +0100 Message-Id: <20180605063257.20190-1-rstoyanov1@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 05 Jun 2018 06:33:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 05 Jun 2018 06:33:05 +0000 (UTC) for IP:'209.85.128.194' DOMAIN:'mail-wr0-f194.google.com' HELO:'mail-wr0-f194.google.com' FROM:'rstoyanov1@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.756 (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.194 mail-wr0-f194.google.com 209.85.128.194 mail-wr0-f194.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-loop: libvir-list@redhat.com Cc: Radostin Stoyanov Subject: [libvirt] [PATCH] virFork: Remove redundant forkRet variable X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 05 Jun 2018 06:33:27 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The variable forkRest is not used after commit 25f8781 https://github.com/libvirt/libvirt/commit/25f8781#diff-d2023c1ac4f688aa2021= e21cfb60d4f0L1861 Signed-off-by: Radostin Stoyanov --- src/util/virfile.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 523241f64f..a2c4cebb56 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -2117,7 +2117,6 @@ virFileAccessibleAs(const char *path, int mode, { pid_t pid =3D 0; int status, ret =3D 0; - int forkRet =3D 0; gid_t *groups; int ngroups; =20 @@ -2152,15 +2151,6 @@ virFileAccessibleAs(const char *path, int mode, return 0; } =20 - /* child. - * Return positive value here. Parent - * will change it to negative one. */ - - if (forkRet < 0) { - ret =3D errno; - goto childerror; - } - if (virSetUIDGID(uid, gid, groups, ngroups) < 0) { ret =3D errno; goto childerror; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list