bug: fixup USB input bus check

[libvirt] [PATCH 0/1] bug: fixup USB input bus check

Posted by Xiao Feng Ren 5 years, 10 months ago

There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB.
Let's fix it.

Xiao Feng Ren (1):
  Fixup USB input bus check

 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.16.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/1] bug: fixup USB input bus check

Posted by Ján Tomko 5 years, 10 months ago

On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
>There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB.
>Let's fix it.
>

The fix looks good to me, but the explanation (which is not really and the mention
of the commit that broke it should be a part of the commit message, not
the cover letter.

(Also, a cover letter is not required for single patches)

Jano

>Xiao Feng Ren (1):
>  Fixup USB input bus check
>
> src/conf/domain_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>-- 
>2.16.3
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/1] bug: fixup USB input bus check

Posted by Xiao Feng Ren 5 years, 10 months ago


On 5/31/2018 4:21 PM, Ján Tomko wrote:
> On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
>> There's one explicit bug(introduced in commit:317badb) when checking 
>> the bus of one input device is USB.
>> Let's fix it.
>>
>
> The fix looks good to me, but the explanation (which is not really and 
> the mention
> of the commit that broke it should be a part of the commit message, not
> the cover letter.
>
> (Also, a cover letter is not required for single patches)
>
> Jano

Ok,  will modify.
>
>> Xiao Feng Ren (1):
>>  Fixup USB input bus check
>>
>> src/conf/domain_conf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> -- 
>> 2.16.3
>>
>> -- 
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list