From nobody Thu May 2 20:15:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527524902401827.8016677686569; Mon, 28 May 2018 09:28:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC4386375E; Mon, 28 May 2018 16:28:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8417D308BDA8; Mon, 28 May 2018 16:28:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C19974CA83; Mon, 28 May 2018 16:28:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4SGSHIG006657 for ; Mon, 28 May 2018 12:28:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD83CA0A71; Mon, 28 May 2018 16:28:17 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B74F95C7C8 for ; Mon, 28 May 2018 16:28:17 +0000 (UTC) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96D39309F89E for ; Mon, 28 May 2018 16:28:06 +0000 (UTC) Received: by mail-wm0-f45.google.com with SMTP id v131-v6so14268140wma.1 for ; Mon, 28 May 2018 09:28:06 -0700 (PDT) Received: from kloomba.my.domain ([213.147.223.87]) by smtp.gmail.com with ESMTPSA id o80-v6sm6932673lfb.41.2018.05.28.09.28.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 May 2018 09:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C5qiQA53I8GNfs0Z4cdg2eIdRuCoVcqamMj08LZNiSs=; b=rUJoxAKQxpavz1trIdcLQfZay06bBpzob4kOqH8zF82ciaxnbsjdOYaD8BprW948gM SoFWbklJ2v7TlaHAFKKaBLKqncKmT6RzVO6IvSBQp4Ydcr5cf2kze2ugINVM1RpTl8wU NMLS+KkAZiVdano6N2/xcfG+eWm/IC7dkrP7o4nVdmeptHbUIMOob+eR4i9Zkch/1SZQ hJdB46pl6T9NY2d6GavC4or3aaHPp6M6k45uHhhMSPauMcxsgdiQn3++fGVs2HuwvPqp ZukMp/3YDZ0XJhSI6rvcPtEa0WQctlxdTy6ivSNeGycxCG20x2lJ7fHH2u5wtAUsJN38 6ITg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C5qiQA53I8GNfs0Z4cdg2eIdRuCoVcqamMj08LZNiSs=; b=iRvzZex/YmBQpdyZk5nryIfp7zxxau4MIU5IwpzNHMi7lDhzd6NGEPMCgFvzaNxxhA pB3mkttP4cbwbBrihPXx82Y2AXNRq82l4rtg+1Z9LXbd38dfJUT0jHzU3ZCk9uwl4mwn 2c73gt83xTLd96jxaqVwF0MJvHSWB3F3YWqk5RFE5KBG+cdEyGPKv1rmG3ycOCQbti0c WmB40iZh/IMx7tJ1UQ1+tFGvorU7xZvLAmai1uh2s6F3Z55OB118HnWr28pbV261G0nP 8j/SNWjIGHiBais52cbnrlBKyAKwxsrd9o077uSP1gtpf9Aj1DTiqwsDPXmN9z4Si8pU eLJg== X-Gm-Message-State: ALKqPwfeNnyy1VJKbV4ZEqRPgm7LmGUccHb82Zh55uE/Krs7FtomYvbz Aun3Lr9BzYLtUpehJBwUzT5LWA== X-Google-Smtp-Source: ADUXVKLoD5PswNStY3+b0AfILQCNfskVqvG2Rwl3h4H2qIYZAl8v7A4ocII1zACZsolKU2ZeI9li1Q== X-Received: by 2002:a2e:9b4a:: with SMTP id o10-v6mr8934977ljj.49.1527524884974; Mon, 28 May 2018 09:28:04 -0700 (PDT) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Mon, 28 May 2018 20:27:50 +0400 Message-Id: <20180528162751.14377-2-bogorodskiy@gmail.com> In-Reply-To: <20180528162751.14377-1-bogorodskiy@gmail.com> References: <20180528162751.14377-1-bogorodskiy@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 28 May 2018 16:28:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 28 May 2018 16:28:06 +0000 (UTC) for IP:'74.125.82.45' DOMAIN:'mail-wm0-f45.google.com' HELO:'mail-wm0-f45.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 74.125.82.45 mail-wm0-f45.google.com 74.125.82.45 mail-wm0-f45.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH 1/2] bhyve: add CPU topology support X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 28 May 2018 16:28:21 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Recently, bhyve started supporting specifying guest CPU topology. It looks this way: bhyve -c cpus=3DC,sockets=3DS,cores=3DC,threads=3DT ... The old behaviour with bhyve -c C, where C is a number of vCPUs, is still supported. So if we have CPU topology in the domain XML, use the new syntax, otherwise keeps the old behaviour. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_capabilities.c | 7 +++-- src/bhyve/bhyve_capabilities.h | 1 + src/bhyve/bhyve_command.c | 17 +++++++++++- .../bhyvexml2argv-cputopology.args | 9 +++++++ .../bhyvexml2argv-cputopology.ldargs | 3 +++ .../bhyvexml2argv-cputopology.xml | 26 +++++++++++++++++++ tests/bhyvexml2argvtest.c | 7 ++++- 7 files changed, 66 insertions(+), 4 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index e13085b1d5..a3229cea75 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -227,7 +227,7 @@ bhyveProbeCapsDeviceHelper(unsigned int *caps, } =20 static int -bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) +bhyveProbeCapsFromHelp(unsigned int *caps, char *binary) { char *help; virCommandPtr cmd =3D NULL; @@ -244,6 +244,9 @@ bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) if (strstr(help, "-u:") !=3D NULL) *caps |=3D BHYVE_CAP_RTC_UTC; =20 + if (strstr(help, "sockets=3Dn][,cores=3Dn][,threads=3Dn") !=3D NULL) + *caps |=3D BHYVE_CAP_CPUTOPOLOGY; + out: VIR_FREE(help); virCommandFree(cmd); @@ -314,7 +317,7 @@ virBhyveProbeCaps(unsigned int *caps) if (binary =3D=3D NULL) goto out; =20 - if ((ret =3D bhyveProbeCapsRTC_UTC(caps, binary))) + if ((ret =3D bhyveProbeCapsFromHelp(caps, binary))) goto out; =20 if ((ret =3D bhyveProbeCapsAHCI32Slot(caps, binary))) diff --git a/src/bhyve/bhyve_capabilities.h b/src/bhyve/bhyve_capabilities.h index 0e310e6eda..873bc9c12d 100644 --- a/src/bhyve/bhyve_capabilities.h +++ b/src/bhyve/bhyve_capabilities.h @@ -49,6 +49,7 @@ typedef enum { BHYVE_CAP_LPC_BOOTROM =3D 1 << 3, BHYVE_CAP_FBUF =3D 1 << 4, BHYVE_CAP_XHCI =3D 1 << 5, + BHYVE_CAP_CPUTOPOLOGY =3D 1 << 6, } virBhyveCapsFlags; =20 int virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps); diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index e3f7ded7db..b319518520 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -467,7 +467,22 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, =20 /* CPUs */ virCommandAddArg(cmd, "-c"); - virCommandAddArgFormat(cmd, "%d", virDomainDefGetVcpus(def)); + if (def->cpu && def->cpu->sockets) { + if ((bhyveDriverGetCaps(conn) & BHYVE_CAP_CPUTOPOLOGY) !=3D 0) { + virCommandAddArgFormat(cmd, "cpus=3D%d,sockets=3D%d,cores=3D%d= ,threads=3D%d", + virDomainDefGetVcpus(def), + def->cpu->sockets, + def->cpu->cores, + def->cpu->threads); + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Installed bhyve binary does not support " + "defining CPU topology")); + goto error; + } + } else { + virCommandAddArgFormat(cmd, "%d", virDomainDefGetVcpus(def)); + } =20 /* Memory */ virCommandAddArg(cmd, "-m"); diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args b/tests= /bhyvexml2argvdata/bhyvexml2argv-cputopology.args new file mode 100644 index 0000000000..2d175a4178 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args @@ -0,0 +1,9 @@ +/usr/sbin/bhyve \ +-c cpus=3D2,sockets=3D1,cores=3D2,threads=3D1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b9:94:02 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs b/tes= ts/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs new file mode 100644 index 0000000000..32538b558e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs @@ -0,0 +1,3 @@ +/usr/sbin/bhyveload \ +-m 214 \ +-d /tmp/freebsd.img bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml b/tests/= bhyvexml2argvdata/bhyvexml2argv-cputopology.xml new file mode 100644 index 0000000000..83c7d423c4 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml @@ -0,0 +1,26 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 2 + + + + + hvm + + + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index b08b1675f3..1c12bfcff3 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -176,7 +176,8 @@ mymain(void) driver.grubcaps =3D BHYVE_GRUB_CAP_CONSDEV; driver.bhyvecaps =3D BHYVE_CAP_RTC_UTC | BHYVE_CAP_AHCI32SLOT | \ BHYVE_CAP_NET_E1000 | BHYVE_CAP_LPC_BOOTROM | \ - BHYVE_CAP_FBUF | BHYVE_CAP_XHCI; + BHYVE_CAP_FBUF | BHYVE_CAP_XHCI | \ + BHYVE_CAP_CPUTOPOLOGY; =20 DO_TEST("base"); DO_TEST("wired"); @@ -207,6 +208,7 @@ mymain(void) DO_TEST("vnc-vgaconf-off"); DO_TEST("vnc-vgaconf-io"); DO_TEST("vnc-autoport"); + DO_TEST("cputopology"); =20 /* Address allocation tests */ DO_TEST("addr-single-sata-disk"); @@ -243,6 +245,9 @@ mymain(void) driver.bhyvecaps &=3D ~BHYVE_CAP_FBUF; DO_TEST_FAILURE("vnc"); =20 + driver.bhyvecaps &=3D ~BHYVE_CAP_CPUTOPOLOGY; + DO_TEST_FAILURE("cputopology"); + virObjectUnref(driver.caps); virObjectUnref(driver.xmlopt); virPortAllocatorRangeFree(driver.remotePorts); --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu May 2 20:15:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527524910976211.56191536624908; Mon, 28 May 2018 09:28:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14F6230A915A; Mon, 28 May 2018 16:28:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3DD4100190D; Mon, 28 May 2018 16:28:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 836391800C92; Mon, 28 May 2018 16:28:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4SGSPUF006670 for ; Mon, 28 May 2018 12:28:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 83AF092AA5; Mon, 28 May 2018 16:28:25 +0000 (UTC) Received: from mx1.redhat.com (ext-mx20.extmail.prod.ext.phx2.redhat.com [10.5.110.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D7F690CFC for ; Mon, 28 May 2018 16:28:22 +0000 (UTC) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F092030BBE75 for ; Mon, 28 May 2018 16:28:11 +0000 (UTC) Received: by mail-wr0-f196.google.com with SMTP id y15-v6so21132418wrg.11 for ; Mon, 28 May 2018 09:28:11 -0700 (PDT) Received: from kloomba.my.domain ([213.147.223.87]) by smtp.gmail.com with ESMTPSA id o80-v6sm6932673lfb.41.2018.05.28.09.28.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 May 2018 09:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lrxSXkhVSOLHqlnbiV136ShX3d9r7XJ1DH1LoTm2Jh8=; b=dWLOlUQI6C3lvPCPizj0Wf3R4UGYosXpnqEAOZAgakhdbGSS3m3k2HT10JMLTGGQtS baT1emKLv5+s2PpAQop7JLabG4LPXDt3Vn734Ip+ZjGl80V0czxY46Avv8RXSq6QqLgV I+POlN7Y0Ft/kyFVagK6zI32G5zxkPkSeHzg03qbshNsJKlLP1Xy8RPInP8CsI2pm+qN 98PFKgqO5EMloJ+ogSx6whyZIhRSq2YumnAWPp3AMUfns2pBgTRiJ/imRNsZXwY9sDO0 wg8g8m9wF6D2ZKRX7EBYSVrXV+u4OrPlB3A5sOKge6Hi7I9yFepcN8qm+oUqf/US2fT4 LkyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lrxSXkhVSOLHqlnbiV136ShX3d9r7XJ1DH1LoTm2Jh8=; b=Bu9jg55tWOM2soh3ux29qGsajP58jBI2ccoFfD6zNFW5HMabSJcfo34pwqgl3AtpKq pJiVVrT69bOvyJJ/k+DH5lKETzEMHZWTrbWJIuTRGS27adQilnRtx1JmD+RsaD3g3sxn WbKgH7XnzR5ujsARKafZQgfS8DE3MPevXklgGOX+A8fZ5sCbR4UetLi/ICW97lVhgDMi o9DXptHcx3RKY9UfAM/Ek58NT49LXDzvJwqRnjz5fvfcQ6vYDLrfv9PwIxE0mls8oJNr BT7yKbTAzdfGTJopi0Pqrk1FHkFZ/nF3ohk4yi9z2Nb/q8uTAHZ+ppfHbpsICEZEnwk9 nYQQ== X-Gm-Message-State: ALKqPwdF0geGEQlOWg8+5kKwoZgRGGNot9V2aacg5Y8pcFMBO+vIe5bB xCP+i7aSkklVMECkoAChOtn9VQ== X-Google-Smtp-Source: ADUXVKI2eRGZJD/SJ+lJtCzm6oUZjXUikBCxhMvaI+qPbc/F0m+fAh5UDiFkWUyrNDZJ2wXAqHUzvQ== X-Received: by 2002:a19:4355:: with SMTP id m21-v6mr5440556lfj.121.1527524890410; Mon, 28 May 2018 09:28:10 -0700 (PDT) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Mon, 28 May 2018 20:27:51 +0400 Message-Id: <20180528162751.14377-3-bogorodskiy@gmail.com> In-Reply-To: <20180528162751.14377-1-bogorodskiy@gmail.com> References: <20180528162751.14377-1-bogorodskiy@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 28 May 2018 16:28:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 28 May 2018 16:28:12 +0000 (UTC) for IP:'209.85.128.196' DOMAIN:'mail-wr0-f196.google.com' HELO:'mail-wr0-f196.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.396 (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.196 mail-wr0-f196.google.com 209.85.128.196 mail-wr0-f196.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.49 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH 2/2] docs: bhyve: document guest CPU topology feature X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 28 May 2018 16:28:29 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Roman Bogorodskiy --- docs/drvbhyve.html.in | 16 ++++++++++++++++ docs/news.xml | 9 +++++++++ 2 files changed, 25 insertions(+) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index 5b5513d3df..78a291c6bb 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -444,6 +444,22 @@ be wired and cannot be swapped out as follows:

</memoryBacking> ... </domain> + + +

CPU topology

+ +

Since 4.4.0, it's possible to specify gues= t CPU topology, if bhyve +supports that. Support for specifying guest CPU topology was added to bhyv= e in +r332298 fo= r -CURRENT. +Example:

+
+<domain type=3D"bhyve">
+    ...
+    <cpu>
+      <topology sockets=3D'1' cores=3D'2' threads=3D'1'/>
+    </cpu>
+    ...
+</domain>
=20 diff --git a/docs/news.xml b/docs/news.xml index c45850f625..318bca5de1 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -94,6 +94,15 @@ both new APIs consider capabilities of a specific hypervisor. + + + bhyve: Support specifying guest CPU topology + + + Bhyve's guest CPU topology could be specified using the + <cpu><topology ../></cpu> element. + +
--=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list