1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio posted 7 patches 5 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180527222826.18525-1-fabiano@fidencio.org
Test syntax-check failed
There is a newer version of this series
src/vmx/vmx.c              | 194 +++++--------
src/xenconfig/xen_common.c | 701 +++++++++++++++++++++++----------------------
src/xenconfig/xen_xm.c     | 306 ++++++++++----------
3 files changed, 595 insertions(+), 606 deletions(-)
[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
Posted by Fabiano Fidêncio 5 years, 11 months ago 
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.

Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.

Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
can be removed.

- Changes since v1:
  All the "values" from virConfGetValueString() are freed

- Changes since v2:
  All comments from Ján Tomko have been addressed;
  A few leaks were (possibly) found and they're addressed in the last
  patch of the series;

Fabiano Fidêncio (7):
  xen_xm: Split the per-disk logic from xenParseXMDisk()
  xen_vm: convert to typesafe virConf accessors
  vmx: convert to typesafe virConf accessors
  xen_common: Split per-PCI logic from xenParsePCI()
  xen_common: Split per-Vfi logic from xenParseVif()
  xen_common: convert to typesafe virConf acessors
  xen_common: Fix a few memory leaks

 src/vmx/vmx.c              | 194 +++++--------
 src/xenconfig/xen_common.c | 701 +++++++++++++++++++++++----------------------
 src/xenconfig/xen_xm.c     | 306 ++++++++++----------
 3 files changed, 595 insertions(+), 606 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
Posted by Ján Tomko 5 years, 10 months ago 
On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote:
>This patchset finishes the conversion to virConfGetValue* functions,
>started by Daniel Berrange a few months ago.
>
>Please, mind that although we could make virConfGetValue* functions more
>generic in order to support numbers and booleans as strings, that
>doesn't seem the safest path to take. The side-effect of this is that we
>will have to live with some specific code doing that as part of vmx and
>xen_common.
>
>Once this patchset gets merged,
>https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
>can be removed.
>
>- Changes since v1:
>  All the "values" from virConfGetValueString() are freed
>
>- Changes since v2:
>  All comments from Ján Tomko have been addressed;
>  A few leaks were (possibly) found and they're addressed in the last
>  patch of the series;
>
>Fabiano Fidêncio (7):
>  xen_xm: Split the per-disk logic from xenParseXMDisk()
>  xen_vm: convert to typesafe virConf accessors
>  vmx: convert to typesafe virConf accessors
>  xen_common: Split per-PCI logic from xenParsePCI()

I have pushed the first four patches.

>  xen_common: Split per-Vfi logic from xenParseVif()
>  xen_common: convert to typesafe virConf acessors


>  xen_common: Fix a few memory leaks
>

This one won't be necessary.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
Posted by Fabiano Fidêncio 5 years, 10 months ago 
On Mon, Jun 11, 2018 at 3:34 PM, Ján Tomko <jtomko@redhat.com> wrote:
> On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote:
>>
>> This patchset finishes the conversion to virConfGetValue* functions,
>> started by Daniel Berrange a few months ago.
>>
>> Please, mind that although we could make virConfGetValue* functions more
>> generic in order to support numbers and booleans as strings, that
>> doesn't seem the safest path to take. The side-effect of this is that we
>> will have to live with some specific code doing that as part of vmx and
>> xen_common.
>>
>> Once this patchset gets merged,
>>
>> https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
>> can be removed.
>>
>> - Changes since v1:
>>  All the "values" from virConfGetValueString() are freed
>>
>> - Changes since v2:
>>  All comments from Ján Tomko have been addressed;
>>  A few leaks were (possibly) found and they're addressed in the last
>>  patch of the series;
>>
>> Fabiano Fidêncio (7):
>>  xen_xm: Split the per-disk logic from xenParseXMDisk()
>>  xen_vm: convert to typesafe virConf accessors
>>  vmx: convert to typesafe virConf accessors
>>  xen_common: Split per-PCI logic from xenParsePCI()
>
>
> I have pushed the first four patches.
>
>>  xen_common: Split per-Vfi logic from xenParseVif()
>>  xen_common: convert to typesafe virConf acessors
>

Okay, I'll re-work these other 2 and submit a v3.

>
>
>>  xen_common: Fix a few memory leaks
>>
>
> This one won't be necessary.
>
> Jano


Thanks for the review!
-- 
Fabiano Fidêncio

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.