[v1] Finish the conversion to virConfGetValue* functions

[libvirt] [PATCHv2 0/3] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio posted 3 patches 5 years, 10 months ago

Diff against v1 v1 v4 v5 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180526210027.12066-1-fabiano@fidencio.org

Test syntax-check failed

There is a newer version of this series

src/vmx/vmx.c              | 196 ++++++--------
src/xenconfig/xen_common.c | 637 ++++++++++++++++++++++-----------------------
src/xenconfig/xen_xm.c     | 268 ++++++++++---------
3 files changed, 512 insertions(+), 589 deletions(-)

Expand all Fold all

[libvirt] [PATCHv2 0/3] Finish the conversion to virConfGetValue* functions

Posted by Fabiano Fidêncio 5 years, 10 months ago

This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.

Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.

Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
can be removed.

- Changes since v1:
  All the "values" from virConfGetValueString() are freed

Fabiano Fidêncio (3):
  xen_vm: convert to typesafe virConf accessors
  vmx: convert to typesafe virConf accessors
  xen_common: convert to typesafe virConf accessors

 src/vmx/vmx.c              | 196 ++++++--------
 src/xenconfig/xen_common.c | 637 ++++++++++++++++++++++-----------------------
 src/xenconfig/xen_xm.c     | 268 ++++++++++---------
 3 files changed, 512 insertions(+), 589 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list