On Fri, May 25, 2018 at 3:27 PM, Fabiano Fidêncio <fidencio@redhat.com> wrote:
> This patchset finishes the conversion to virConfGetValue* functions,
> started by Daniel Berrange a few months ago.
>
> Please, mind that although we could make virConfGetValue* functions more
> generic in order to support numbers and booleans as strings, that
> doesn't seem the safest path to take. The side-effect of this is that we
> will have to live with some specific code doing that as part of vmx and
> xen_common.
Self-nack! In the third patch I'm leaking some lists.
I'll submit a v2.
>
> Fabiano Fidêncio (3):
> xen_vm: convert to typesafe virConf accessors
> vmx: convert to typesafe virConf accessors
> xen_common: convert to typesafe virConf accessors
>
> src/vmx/vmx.c | 197 +++++-------
> src/xenconfig/xen_common.c | 631 ++++++++++++++++++-------------------
> src/xenconfig/xen_xm.c | 268 ++++++++--------
> 3 files changed, 504 insertions(+), 592 deletions(-)
>
> --
> 2.17.0
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list