From nobody Mon Apr 29 01:22:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527239801930658.0571449827116; Fri, 25 May 2018 02:16:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 808273166889; Fri, 25 May 2018 09:16:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 447C22010CB0; Fri, 25 May 2018 09:16:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EA26180BA81; Fri, 25 May 2018 09:16:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4P9GWRJ017039 for ; Fri, 25 May 2018 05:16:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9289C111AF31; Fri, 25 May 2018 09:16:32 +0000 (UTC) Received: from inaba.usersys.redhat.com (ovpn-204-255.brq.redhat.com [10.40.204.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC5B6111AF0D for ; Fri, 25 May 2018 09:16:29 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 25 May 2018 11:16:24 +0200 Message-Id: <20180525091624.11856-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH] guests: Don't backup files when changing them X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 25 May 2018 09:16:40 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since our entire guest state is fully reproducible, keeping backups around is not very useful; moreover, on CentOS 6 it results in us hitting https://github.com/ansible/ansible/issues/31982 Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- guests/tasks/bootloader.yml | 2 -- guests/tasks/jenkins.yml | 1 - guests/tasks/users.yml | 2 -- 3 files changed, 5 deletions(-) diff --git a/guests/tasks/bootloader.yml b/guests/tasks/bootloader.yml index face3dd..3de8c0d 100644 --- a/guests/tasks/bootloader.yml +++ b/guests/tasks/bootloader.yml @@ -19,7 +19,6 @@ path: /etc/default/grub regexp: '^{{ item.key }}=3D.*$' line: '{{ item.key }}=3D"{{ item.value }}"' - backup: yes with_items: - { key: 'GRUB_TIMEOUT', value: '1' } - { key: 'GRUB_CMDLINE_LINUX_DEFAULT', value: 'console=3DttyS0' } @@ -45,7 +44,6 @@ regexp: '^{{ item.key }}=3D.*$' line: '{{ item.key }}=3D"{{ item.value }}"' create: yes - backup: yes with_items: - { key: 'console', value: 'comconsole' } - { key: 'autoboot_delay', value: '1' } diff --git a/guests/tasks/jenkins.yml b/guests/tasks/jenkins.yml index 10aeec7..9076c34 100644 --- a/guests/tasks/jenkins.yml +++ b/guests/tasks/jenkins.yml @@ -23,7 +23,6 @@ lineinfile: path: /etc/rc.local create: yes - backup: yes regexp: '^nohup.*jenkins.*java.*slave\.jar.*&$' line: "nohup {{ su }} - jenkins -c '{{ java }} -jar /home/jenkins/slav= e.jar -jnlpUrl \"{{ jenkins_url }}\" -secret \"{{ jenkins_secret }}\"' >/va= r/log/jenkins.log 2>&1 &" insertbefore: '^exit .*$' diff --git a/guests/tasks/users.yml b/guests/tasks/users.yml index 033ca2a..0aa6230 100644 --- a/guests/tasks/users.yml +++ b/guests/tasks/users.yml @@ -17,7 +17,6 @@ regexp: '^#*\s*PermitRootLogin\s*.*$' line: 'PermitRootLogin without-password' state: present - backup: yes =20 - name: '{{ flavor }}: Create user account' user: @@ -46,7 +45,6 @@ path: '{{ sudoers }}' line: '{{ flavor }} ALL=3D(ALL) NOPASSWD: ALL' state: present - backup: yes validate: 'visudo -cf %s' when: - flavor =3D=3D 'test' --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list