[v1] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

[libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

Roland Schulz posted 1 patch 5 years, 11 months ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180523140806.6635-1-schullzroll@gmail.com

Test syntax-check passed

There is a newer version of this series

tools/virsh-completer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

Posted by Roland Schulz 5 years, 11 months ago

---
 tools/virsh-completer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index cbd5326d0..1df4d55af 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -568,8 +568,8 @@ virshSnapshotNameCompleter(vshControl *ctl,
 
 char **
 virshAllocpagesPagesizeCompleter(vshControl *ctl,
-                        const vshCmd *cmd ATTRIBUTE_UNUSED,
-                        unsigned int flags)
+                                 const vshCmd *cmd ATTRIBUTE_UNUSED,
+                                 unsigned int flags)
 {
     unsigned long long byteval = 0;
     xmlXPathContextPtr ctxt = NULL;
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

Posted by Michal Privoznik 5 years, 11 months ago

On 05/23/2018 04:08 PM, Roland Schulz wrote:
> ---
>  tools/virsh-completer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch is missing SoB line. I cannot push this patch without it. Can
you please confirm here that I can add is there (funny, because your
other patches have the line) so that I can push this patch?

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

Posted by Michal Privoznik 5 years, 11 months ago

On 05/24/2018 03:51 PM, Michal Privoznik wrote:
> On 05/23/2018 04:08 PM, Roland Schulz wrote:
>> ---
>>  tools/virsh-completer.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch is missing SoB line. I cannot push this patch without it. Can
> you please confirm here that I can add is there (funny, because your
> other patches have the line) so that I can push this patch?

Ah, disregard this. You've sent v2 which is fixed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list